New issue
Advanced search Search tips

Issue 631314 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Rubies inside multi-column layout are broken up into columns

Reported by hakatashi@pixiv.co.jp, Jul 26 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36

Example URL:
https://codepen.io/hakatashi/pen/grzJBa

Steps to reproduce the problem:
1. Create column layout with ruby element inside of it.

What is the expected behavior?
Ruby base and its notation appears in the same column and does not break into columns.

What went wrong?
The ruby texts between columns are unexpectedly broken up into columns and partly cut off to the another column.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 52.0.2743.82  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 22.0 r0

result.png was shot in Chrome 52.0.2743.82 m on Windows 10.
expected.png was shot in Firefox 47.0 on Windows 10.

I've confirmed the following browsers render the same as expected.png:

* Firefox 47.0
* Internet Explorer 11.494.10586.0
* Microsoft Edge 25.10586.0.0
 
result.png
2.9 KB View Download
expected.png
2.3 KB View Download

Comment 1 by b...@chromium.org, Jul 26 2016

Components: Blink

Comment 2 by bokan@chromium.org, Jul 26 2016

Components: -Blink Blink>Layout>Ruby

Comment 3 by e...@chromium.org, Jul 26 2016

Cc: msten...@opera.com
Components: -Blink>Layout>Ruby Blink>Layout>MultiCol

Comment 4 by e...@chromium.org, Jul 26 2016

Cc: kojii@chromium.org
Components: Blink>Layout>Ruby
Status: Available (was: Unconfirmed)

Comment 5 by msten...@opera.com, Aug 9 2016

Cc: -msten...@opera.com
Owner: msten...@opera.com

Comment 6 by msten...@opera.com, Sep 29 2016

The problem seems to be that lines (RootInlineBox) are pushed down to make room for the ruby above them (so that the ruby doesn't overlap with previous content, etc). But why not just expand the line box height to include the ruby, and put the ruby at position 0, rather than putting it at a negative position? Because of vertical alignment, maybe?

Anyway, the way it is implemented now makes it hard for pagination to do anything about it, unless we want to expose APIs to make the pagination code ruby-aware (which seems like a bad idea to me).

See what RootInlineBox::alignBoxesInBlockDirection() does with beforeAnnotationsAdjustment(). And there's even a FIXME for pagination there. :)
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 2 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by e...@chromium.org, Oct 2 2017

Status: WontFix (was: Untriaged)
This will be fixed when ruby is re-implemented on top of LayoutNG.
Cc: mstensho@chromium.org
Owner: ----
Cc: vamshi.kommuri@chromium.org
 Issue 916259  has been merged into this issue.
Cc: z...@kobo.com
Labels: -Pri-2 -Type-Compat -Hotlist-Recharge-Cold Pri-3 Type-Bug
Status: Available (was: WontFix)
Reopening as Jeff wanted to look into this.

Sign in to add a comment