Sheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago |
||||
Issue descriptionSheriffbot-Auto-triage Rule: Needs-Feedback Bugs, already received feedback 7 days ago. Add Bug number which got updated: Issue 630618 Issue/Concern or feedback: I asked for more feedback, leaving the Needs-Feedback label intact. The last comment on the issue was from me, but sheriffbot asked me to review it, even though I had just reviewed it and asked for more feedback.
,
Jul 26 2016
Sheriff-bot checks to see if a ping from reporter was given after the "Needs-Feedback" and then assigns back. Here in the bug Issue 630618 the label was added and a ping was received from reporter. We have modified this rule so that sheriff bot waits for 7 days before adding "Needs-Review" label rather than checking daily and updating. This change went in today and from tomorrow's run you should see a waiting time of 7 days. I'll leave the bug open, let us know if this works. Thanks
,
Jul 26 2016
> Here in the bug Issue 630618 the label was added and a ping was received from reporter. But then the feedback-requester also pinged, asking for more feedback. Is this taken into account?
,
Jul 26 2016
We discussed this in issue 593390 comment #5 and 596470 We decided to continually checking for responses/ removes needs-feedback quickly. Since now we wait 7 days before checking, we should consider this. Anthony, could you please provide your input on this. Thanks
,
Jul 27 2016
In our instructions for Mac triage, we archive bugs that have Needs-Feedback, but no feedback, after 30 days. 7 days is too soon. Also assigning the feedback *requester* as owner for feedback-requested-but-no-feedback bugs is always the wrong thing to do -- all the requester can do is close the bug. Pinging the bug so that the *reporter* is reminded to provide feedback might be OK, but there's nothing for someone who's just asked for feedback to do except wait for that feedback or close the bug. (and, nit: in the Mac triage, closing feedback-requested-but-no-feedback bugs is the job of the triage person, not the feedback-requester).
,
Jul 27 2016
We too archive the bug only after 30 days if feedback is not received. [This is not changed] All we changed is now we wait for 7 days before checking to see if feedback is provided. And if feedback is provided we don't change any bug status ( we add owner as a requester only when there is no owner). No bug status will be changed.
,
Jul 27 2016
> And if feedback is provided we don't change any bug status What if feedback is *NOT* provided? If feedback *IS* provided, and it's being ignored, then that's bad. I actually would suggest doing something to the bug. But when feedback is *NOT* provided (yet) then there's nothing for the requester to act on -- why make them an owner?
,
Jul 27 2016
if Feedback is not provided, then we shouldn't update to bug until it reaches 30 days.
,
Jul 27 2016
Checked again: if Feedback is *NOT* provided (i.e no ping from reporter is sent after "Needs-Feedback" label), then we are not updating to bug until it reaches 30 days. Thanks
,
Jul 27 2016
OK - that's very different to what happened at http://crbug.com/630618#c5 , but if the wait-30-days behavior only rolled out in the last ~day then that would explain it. Thanks for looking into this. From my end, feel free to close this out unless you're waiting for further comments.
,
Aug 3 2016
Thanks closing this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Jul 26 2016