Bookmarks bar tweaks |
||||||
Issue descriptionMerging 618378 within this more complete bug. I took a stab at the current states of the bookmark bar and created a complete and precise spec of what it should look like. Right now there are a few spacing issues I think the following tweaks will make it look better. See attached. the "current-overlap.png" in which I I overlapped the current implementation over the expected spec. Key modifications: - First bookmark icon should be 12pt from the left. - Bookmarks should be separated by 12pt (from end of textbox to icon) - Hover/pressed states should have 4pt padding on each side. - Dropdown menu should also have 4pt padding left/top/bottom. - Dropdown menu selected row should be full bleed. Spec attached.
,
Jul 26 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3 2016
,
Aug 5 2016
sgabriel@ - I noticed that the bookmark folder menu has a different background than your screenshot. It looks like it's a slightly transparent 0xF8 - is that the correct background color?
,
Aug 6 2016
This is due to the template I used to replicated mac default menu background, sorry. Just use the one we have today.
,
Aug 10 2016
Looking great. Thank you! Assigning to you, feel free to close if there's nothing else you'd like me to check or help with.
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f11f9261224faead4686ba6c33403ac4fca2e9b commit 5f11f9261224faead4686ba6c33403ac4fca2e9b Author: shrike <shrike@chromium.org> Date: Tue Aug 23 00:13:00 2016 [Mac][Material Design] Adjust bookmark spacing and folder menu drawing. This cl adjusts the bookmark bar item spacing and bookmark folder menu item drawing per sgabriel@. R=tapted@chromium.org BUG= 631275 Review-Url: https://codereview.chromium.org/2200303004 Cr-Commit-Position: refs/heads/master@{#413593} [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.h [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/gradient_button_cell.h [modify] https://crrev.com/5f11f9261224faead4686ba6c33403ac4fca2e9b/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Aug 23 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sgabr...@chromium.org
, Jul 26 2016