New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 631271 link

Starred by 2 users
Status: Fixed
Owner:
s...@chromium.org
Closed: Jan 2018
Cc:
█ maxbogue@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 626114
Blocking:
issue 637950


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

[Sync] Rearrange sync code to adhere to a better folder structure

Project Member Reported by maxbogue@chromium.org, Jul 25 2016 
There isn't a clear reason that core should exist separately from api(_impl), driver(_impl), and engine(_impl) once sync and sync_driver are merged into one component.

Comment 1 by maxbogue@chromium.org, Aug 15 2016

Blocking: 637950

Comment 2 by maxbogue@chromium.org, Aug 30 2016

Summary: [Sync] Rearrange sync code to adhere to a better folder structure (was: [Sync] core(_impl) should be split into driver/engine/api)
We want to move around a lot of things in core*/ and driver/:

https://docs.google.com/document/d/12N17NM5m2pz3A9y5HghHd6_KNq8tdsO4Vn5ZYo2M7uw/edit#

Comment 3 by maxbogue@chromium.org, Oct 6 2016

Labels: Sync-Code-Health

Comment 4 by maxbogue@chromium.org, Oct 6 2016

Labels: Pri-1

Comment 5 by maxbogue@chromium.org, Oct 6 2016

Labels: -Sync-Code-Health Hotlist-CodeHealth
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f960e56d62d371d1c79653cb131213c663eb422

commit 2f960e56d62d371d1c79653cb131213c663eb422
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Oct 07 01:24:15 2016

[Sync] Move some things from driver to base.

Things moved:

- invalidation_adapter
- invalidation_helper
- pref_names
- report_unrecoverable_error (renamed from chrome_*)
- sync_prefs
- system_encryptor

This CL was mostly generated by a script but required tweaking the
SyncPrefs interface slightly to remove a dependency.

BUG= 631271 
TBR=stuartmorgan,jochen

Review-Url: https://codereview.chromium.org/2395533003
Cr-Commit-Position: refs/heads/master@{#423773}

[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/autocomplete/search_provider_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/permissions/permission_uma_util_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/sync/profile_sync_service_android.h
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/sync/test/integration/fake_server_invalidation_service.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/chrome/browser/ui/webui/settings/people_handler_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/browser_sync/profile_sync_service_startup_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/BUILD.gn
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/DEPS
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/invalidation_adapter.cc
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/invalidation_adapter.h
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/invalidation_helper.cc
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/invalidation_helper.h
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/pref_names.cc
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/pref_names.h
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/report_unrecoverable_error.cc
[add] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/report_unrecoverable_error.h
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/sync_prefs.cc
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/sync_prefs.h
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/sync_prefs_unittest.cc
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/system_encryptor.cc
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/system_encryptor.h
[rename] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/base/system_encryptor_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/DEPS
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/fake_sync_client.cc
[delete] https://crrev.com/80e6cf8d1fa064239b919bd111dc9304209dc9d3/components/sync/driver/glue/chrome_report_unrecoverable_error.h
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/glue/sync_backend_host_core.h
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/model_type_controller.h
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/startup_controller.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/startup_controller_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/sync_policy_handler.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/sync_policy_handler_unittest.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/driver/sync_service_utils.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/tools/sync_client.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync/tools/sync_listen_notifications.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/components/sync_sessions/sessions_sync_manager.h
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/ios/chrome/browser/prefs/browser_prefs.mm
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/ios/chrome/browser/sync/ios_chrome_sync_client.mm
[modify] https://crrev.com/2f960e56d62d371d1c79653cb131213c663eb422/ios/chrome/browser/sync/sync_setup_service.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ed9ccefbec84b7e228a415449876a9bb5b3e105

commit 7ed9ccefbec84b7e228a415449876a9bb5b3e105
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Oct 07 20:25:51 2016

[Sync] Move attachments code out of core/.

Things moved to...

api/attachments/
  attachment_service
  attachment_service_proxy

api_impl/attachments/
  attachment_service_impl
  task_queue

engine/attachments/
  attachment_downloader
  attachment_store_backend
  attachment_store_frontend
  attachment_uploader
  attachment_util
  fake_attachment_downloader
  fake_attachment_uploader
  in_memory_attachment_store
  on_disk_attachment_store

engine_impl/attachments/
  attachment_downloader_impl
  attachment_uploader_impl
  proto/

I'm unfamiliar with the attachments code so this was as best as I could tell
where they should go... The store things in particular are a bit weird and
hard to place.

BUG= 631271 
TBR=thakis,sdefresne

Review-Url: https://codereview.chromium.org/2399953002
Cr-Commit-Position: refs/heads/master@{#423954}

[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/chromeos/preferences_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/extensions/api/sessions/sessions_apitest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/themes/theme_syncable_service_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/ui/webui/signin/signin_create_profile_handler_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/dom_distiller/core/dom_distiller_store_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/history/core/browser/history_service_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/history/core/browser/typed_url_syncable_service_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/BUILD.gn
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/DEPS
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment.cc
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service_proxy.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service_proxy.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service_proxy_for_test.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service_proxy_for_test.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_service_proxy_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_store.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/attachments/attachment_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/sync_change_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/sync_data.h
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api/sync_data_unittest.cc
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/DEPS
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/attachments/DEPS
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/attachments/attachment_service_impl.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/attachments/attachment_service_impl.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/attachments/attachment_service_impl_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/attachments/task_queue.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/api_impl/attachments/task_queue_unittest.cc
[delete] https://crrev.com/43e96977b3a7e5d5855712ca17c9943a38de053f/components/sync/core/attachments/attachment_uploader.h
[delete] https://crrev.com/43e96977b3a7e5d5855712ca17c9943a38de053f/components/sync/core_impl/attachments/DEPS
[delete] https://crrev.com/43e96977b3a7e5d5855712ca17c9943a38de053f/components/sync/core_impl/attachments/attachment_service.cc
[delete] https://crrev.com/43e96977b3a7e5d5855712ca17c9943a38de053f/components/sync/core_impl/attachments/attachment_uploader.cc
[delete] https://crrev.com/43e96977b3a7e5d5855712ca17c9943a38de053f/components/sync/core_impl/attachments/task_queue.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/device_info/device_info_sync_service_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/driver/fake_generic_change_processor.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/driver/generic_change_processor.h
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/driver/generic_change_processor_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/driver/shared_change_processor_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/driver/sync_api_component_factory.h
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/driver/sync_api_component_factory_mock.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/DEPS
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/DEPS
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_downloader.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_downloader.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_store_backend.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_store_backend.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_store_frontend.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_store_frontend.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_store_frontend_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_store_test_template.h
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_uploader.cc
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_uploader.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_util.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/attachment_util.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/fake_attachment_downloader.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/fake_attachment_downloader.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/fake_attachment_downloader_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/fake_attachment_uploader.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/fake_attachment_uploader.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/fake_attachment_uploader_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/in_memory_attachment_store.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/in_memory_attachment_store.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/in_memory_attachment_store_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/on_disk_attachment_store.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/on_disk_attachment_store.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine/attachments/on_disk_attachment_store_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/DEPS
[add] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/DEPS
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/attachment_downloader_impl.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/attachment_downloader_impl.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/attachment_uploader_impl.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/attachment_uploader_impl.h
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/attachment_uploader_impl_unittest.cc
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/proto/BUILD.gn
[rename] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync/engine_impl/attachments/proto/attachment_store.proto
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync_sessions/favicon_cache_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/sync_sessions/lost_navigations_recorder_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/syncable_prefs/pref_service_syncable_unittest.cc
[modify] https://crrev.com/7ed9ccefbec84b7e228a415449876a9bb5b3e105/components/wifi_sync/wifi_credential_syncable_service_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ab40f5b918737b09312cd19a337ddb20edc1be

commit f0ab40f5b918737b09312cd19a337ddb20edc1be
Author: maxbogue <maxbogue@chromium.org>
Date: Tue Oct 11 16:12:40 2016

[Sync] Move network-related code from core/ to engine/net/.

Everything is being moved out of core/ to better places.

engine/net/
  http_bridge
  http_bridge_network_resources
  http_post_provider_factory
  http_post_provider_interface
  network_resources
  network_time_update_callback

engine_impl/net/
  syncapi_server_connection_manager -> server_connection_manager_impl

BUG= 631271 

Review-Url: https://codereview.chromium.org/2408463002
Cr-Commit-Position: refs/heads/master@{#424445}

[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/browser_sync/test_http_bridge_factory.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/BUILD.gn
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/core/sync_manager.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/core_impl/sync_manager_impl.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/core_impl/sync_manager_impl.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/core_impl/sync_manager_impl_unittest.cc
[delete] https://crrev.com/b3ee8b8327b2300fcf48859ddac62384e0a634cb/components/sync/core_impl/syncapi_server_connection_manager.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/core_impl/test/fake_sync_manager.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[add] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/DEPS
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_bridge.cc
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_bridge.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_bridge_network_resources.cc
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_bridge_network_resources.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_bridge_unittest.cc
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_post_provider_factory.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/http_post_provider_interface.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/network_resources.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine/net/network_time_update_callback.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine_impl/net/sync_server_connection_manager.cc
[add] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine_impl/net/sync_server_connection_manager.h
[rename] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/engine_impl/net/sync_server_connection_manager_unittest.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/test/fake_server/android/fake_server_helper_android.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/test/fake_server/fake_server_http_post_provider.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/test/fake_server/fake_server_network_resources.cc
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/test/fake_server/fake_server_network_resources.h
[modify] https://crrev.com/f0ab40f5b918737b09312cd19a337ddb20edc1be/components/sync/tools/sync_client.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7efba4aa0524c9e5086005bd98d295bdc57723f

commit d7efba4aa0524c9e5086005bd98d295bdc57723f
Author: maxbogue <maxbogue@chromium.org>
Date: Wed Oct 12 15:32:45 2016

[Sync] Move some directory-related things from core/ to syncable/.

Everything is being moved out of core to better homes. Things moved:

syncable/
  base_node
  base_transaction
  change_record
  change_reorder_buffer
  delete_journal
  read_node
  read_transaction
  test_user_share
  user_share
  write_node
  write_transaction

My knowledge of the role each of these plays is not perfect, so let me
know if something should not have been moved.

BUG= 631271 

Review-Url: https://codereview.chromium.org/2407163004
Cr-Commit-Position: refs/heads/master@{#424743}

[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/chrome/browser/sync/profile_sync_service_android.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/abstract_profile_sync_service_test.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/browser_sync/profile_sync_service_typed_url_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/BUILD.gn
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core/sync_manager.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core/test/fake_sync_manager.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/js_sync_manager_observer.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/sync_encryption_handler_impl.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/sync_encryption_handler_impl_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/sync_manager_impl.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/sync_manager_impl.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/core_impl/test/sync_manager_for_profile_sync_test.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/backend_migrator.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/backend_migrator_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/change_processor.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/data_type_controller.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/directory_data_type_controller.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/fake_sync_service.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/generic_change_processor.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/generic_change_processor_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/glue/sync_backend_registrar.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/glue/sync_backend_registrar_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/driver/shared_change_processor_unittest.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/model/sync_data.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/DEPS
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/base_node.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/base_node.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/base_transaction.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/base_transaction.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/change_record.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/change_record.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/change_record_unittest.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/change_reorder_buffer.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/change_reorder_buffer.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/delete_journal.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/delete_journal.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/read_node.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/read_node.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/read_transaction.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/read_transaction.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/test_user_share.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/test_user_share.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/user_share.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/user_share.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/write_node.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/write_node.h
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/write_transaction.cc
[rename] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/syncable/write_transaction.h
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/tools/DEPS
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync/tools/sync_client.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync_bookmarks/bookmark_change_processor.cc
[modify] https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f/components/sync_bookmarks/bookmark_model_associator.cc

Comment 10 by pav...@chromium.org, Oct 12 2016

Labels: -Pri-1 Pri-2
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a1e232d951e2069ca2cb98e5beb6923a13036a5

commit 2a1e232d951e2069ca2cb98e5beb6923a13036a5
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Oct 13 00:32:49 2016

[Sync] Move SharedModelTypeProcessor to model_impl/.

- Move shared_model_type_processor* to model_impl/
- Move processor_entity_tracker* to model_impl/
- Replace SharedModelTypeProcessor::CreateAsChangeProcessor() with
  ModelTypeChangeProcessor::Create().
- Remove model_type_connector_proxy_unittest.cc as it mostly just tests
  WeakPtr functionality or things covered in the worker tests.
- Introduce ModelTypeDebugInfo, a friend class of SMTP, to hold all the
  debug logic Gang has been adding to SMTP.
- An unrelated cleanup tweak in the worker test.

BUG= 631271 

Review-Url: https://codereview.chromium.org/2412193002
Cr-Commit-Position: refs/heads/master@{#424921}

[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/BUILD.gn
[delete] https://crrev.com/a2cab6d035bef91d027bbc642304eeeece680f62/components/sync/core_impl/model_type_connector_proxy_unittest.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/driver/model_type_controller.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/driver/model_type_controller_unittest.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/driver/sync_client.h
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model/model_type_change_processor.cc
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model/model_type_change_processor.h
[add] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model/model_type_debug_info.cc
[add] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model/model_type_debug_info.h
[modify] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/DEPS
[rename] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/processor_entity_tracker.cc
[rename] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/processor_entity_tracker.h
[rename] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/processor_entity_tracker_unittest.cc
[rename] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/shared_model_type_processor.cc
[rename] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/shared_model_type_processor.h
[rename] https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5/components/sync/model_impl/shared_model_type_processor_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/233bfebf0ee3eed7e6a559b3314d60e873d85b97

commit 233bfebf0ee3eed7e6a559b3314d60e873d85b97
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Oct 14 16:42:40 2016

[Sync] Move some things from core/ to model(_impl)/.

Everything is being moved out of core/ to better homes.

model/
  data_batch_impl -> mutable_data_batch
  model_type_store_test_util
  simple_metadata_change_list

model_impl/
  model_type_store_backend
  model_type_store_impl

BUG= 631271 

Review-Url: https://codereview.chromium.org/2416823003
Cr-Commit-Position: refs/heads/master@{#425354}

[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/BUILD.gn
[delete] https://crrev.com/41781b5c4d26bc86779212a9dea21e36d0566622/components/sync/core/data_batch_impl.cc
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/device_info/device_info_service.cc
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/device_info/device_info_service.h
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/device_info/device_info_service_unittest.cc
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/fake_model_type_service.cc
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/model_type_store.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/model_type_store_test_util.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/model_type_store_test_util.h
[add] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/mutable_data_batch.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/mutable_data_batch.h
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/mutable_data_batch_unittest.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/simple_metadata_change_list.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/simple_metadata_change_list.h
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model/simple_metadata_change_list_unittest.cc
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/DEPS
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/model_type_store_backend.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/model_type_store_backend.h
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/model_type_store_backend_unittest.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/model_type_store_impl.cc
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/model_type_store_impl.h
[rename] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/model_type_store_impl_unittest.cc
[modify] https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97/components/sync/model_impl/shared_model_type_processor_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f690e24c680fb3c07fa7ea4a064b4244689da028

commit f690e24c680fb3c07fa7ea4a064b4244689da028
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Oct 14 22:15:11 2016

[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG= 631271 
TBR=jochen

Review-Url: https://codereview.chromium.org/2413313004
Cr-Commit-Position: refs/heads/master@{#425491}

[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/chrome/browser/sync/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/browser_sync/profile_sync_service_bookmark_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/browsing_data/core/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/dom_distiller/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/password_manager/sync/browser/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/BUILD.gn
[delete] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/components/sync/core/DEPS
[delete] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/components/sync/core_impl/DEPS
[delete] https://crrev.com/6cd3a6a5c19014f91361982145d5c454967454e7/components/sync/core_impl/README
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/device_info/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/backend_data_type_configurer.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/backend_migrator.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/data_type_manager.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/data_type_manager_impl.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/data_type_manager_impl_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/generic_change_processor_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host_core.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_host_mock.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/glue/sync_backend_registrar.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/model_association_manager.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/model_type_controller.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/model_type_controller_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/sync_frontend.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/sync_service.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/driver/sync_service.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/DEPS
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/activation_context.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/activation_context.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/commit_queue.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/configure_reason.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/connection_status.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/data_type_association_stats.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/data_type_association_stats.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/data_type_debug_info_listener.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/data_type_debug_info_listener.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/engine_components_factory.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/engine_components_factory_impl.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/engine_components_factory_impl.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/engine_util.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/engine_util.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/fake_model_type_connector.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/fake_model_type_connector.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/fake_model_type_processor.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/fake_model_type_processor.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/fake_sync_manager.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/fake_sync_manager.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/model_type_connector.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/model_type_connector.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/model_type_processor.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/model_type_processor.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/model_type_processor_proxy.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/model_type_processor_proxy.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/non_blocking_sync_common.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/non_blocking_sync_common.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/shutdown_reason.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_auth_provider.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_encryption_handler.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_encryption_handler.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_manager.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_manager.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_manager_factory.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_manager_factory.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_manager_factory_for_profile_sync_test.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_manager_factory_for_profile_sync_test.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_status.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/sync_string_conversions.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/test_engine_components_factory.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine/test_engine_components_factory.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/apply_control_data_updates_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/debug_info_event_listener.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/debug_info_event_listener.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/debug_info_event_listener_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/directory_update_handler_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/events/protocol_event_buffer.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/events/protocol_event_buffer.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/events/protocol_event_buffer_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_mutation_event_observer.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_mutation_event_observer.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_mutation_event_observer_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_sync_encryption_handler_observer.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_sync_encryption_handler_observer.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_sync_encryption_handler_observer_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_sync_manager_observer.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_sync_manager_observer.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/js_sync_manager_observer_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_connector_proxy.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_connector_proxy.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_registry.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_registry.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_registry_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_worker.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_worker.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/non_blocking_type_commit_contribution.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_encryption_handler_impl.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_encryption_handler_impl.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_manager_for_profile_sync_test.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_manager_for_profile_sync_test.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_manager_impl.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_manager_impl.h
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/syncer_util_unittest.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/test_entry_factory.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/test_entry_factory.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/engine_impl/worker_entity_tracker.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model/fake_model_type_service.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model/model_type_change_processor.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model/model_type_service.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model/simple_metadata_change_list.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model_impl/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model_impl/processor_entity_tracker.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model_impl/processor_entity_tracker_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model_impl/shared_model_type_processor.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model_impl/shared_model_type_processor.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/model_impl/shared_model_type_processor_unittest.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/syncable/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/syncable/base_node.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/syncable/sync_db_util.cc
[rename] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/syncable/sync_db_util.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/syncable/user_share.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/syncable/write_node.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/test/engine/mock_model_type_processor.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/test/engine/mock_model_type_worker.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/test/engine/single_type_mock_server.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/test/fake_sync_encryption_handler.h
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/tools/DEPS
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync/tools/sync_client.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/sync_bookmarks/bookmark_model_associator.cc
[modify] https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028/components/wifi_sync/DEPS
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ee60688589640ea58b3b29477fc1b5990b1ce8

commit 91ee60688589640ea58b3b29477fc1b5990b1ce8
Author: maxbogue <maxbogue@chromium.org>
Date: Mon Oct 17 20:09:46 2016

[Sync] Fix test support targets + duplicate namespaces.

Now there are four primary test support targets: base, engine, model,
and driver. Hypothetically a model type would only need to depend on
test_support_model, and an embedder would only need to depend on
test_support_driver. This is currently not necessarily the case since
some model-y things still live in driver, but we can dream.

test_support_base is exposed via the public_deps of all three others so
it should essentially never need to be depended on directly.

The main sync target is now not exposed via the public_deps of
the test support targets. Almost everywhere seemed to be explicitly adding
it anyways, so I just made it required.

All test_support_sync_* targets have been renamed test_support_*, as
with the switch to GN the "sync" no longer adds anything.

This CL also fixes some files that had two "namespace syncer" blocks
left over from the namespace changes.

BUG= 631271 
TBR=thestig,caitkp,lazyboy

Review-Url: https://codereview.chromium.org/2419793005
Cr-Commit-Position: refs/heads/master@{#425762}

[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/chrome/android/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/chrome/test/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/browser_sync/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/browsing_data/core/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/history/core/browser/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/password_manager/sync/browser/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/search_engines/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/suggestions/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync/base/proto_value_ptr.h
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync/device_info/device_info_service.h
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync/driver/shared_change_processor.cc
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync/engine_impl/model_type_registry.h
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync/tools/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync_bookmarks/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/sync_sessions/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/syncable_prefs/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/components/wifi_sync/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/extensions/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/ios/chrome/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/ios/chrome/browser/BUILD.gn
[modify] https://crrev.com/91ee60688589640ea58b3b29477fc1b5990b1ce8/tools/android/eclipse/.classpath
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3cb90f72a87ae95c715ab92b251a01c66d303af

commit d3cb90f72a87ae95c715ab92b251a01c66d303af
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Oct 21 19:42:46 2016

[Sync] Move events files around a bit.

These things landed in the wrong place during the sync componentization.
ProtocolEvent implementations are moved to engine_impl, and the
ProtocolEventObserver is moved from driver to engine.

engine/events/
  protocol_event_observer

engine_impl/events/
  clear_server_data_request_event
  clear_server_data_response_event
  commit_request_event
  commit_response_event
  configure_get_updates_request_event
  get_updates_response_event
  normal_get_updates_request_event
  poll_get_updates_request_event

BUG= 631271 
TBR=bauerb

Review-Url: https://chromiumcodereview.appspot.com/2436863005
Cr-Commit-Position: refs/heads/master@{#426866}

[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/chrome/browser/ui/webui/sync_internals_message_handler.h
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/BUILD.gn
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine/events/protocol_event_observer.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine/events/protocol_event_observer.h
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/clear_server_data.cc
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/commit.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/clear_server_data_request_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/clear_server_data_request_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/clear_server_data_response_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/clear_server_data_response_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/commit_request_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/commit_request_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/commit_response_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/commit_response_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/configure_get_updates_request_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/configure_get_updates_request_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/get_updates_response_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/get_updates_response_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/normal_get_updates_request_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/normal_get_updates_request_event.h
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/poll_get_updates_request_event.cc
[rename] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/poll_get_updates_request_event.h
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/events/protocol_event_buffer_unittest.cc
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/get_updates_delegate.cc
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/components/sync/engine_impl/get_updates_processor.cc
[modify] https://crrev.com/d3cb90f72a87ae95c715ab92b251a01c66d303af/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c9a8fb0c390c21b77340455df70734abaf61342

commit 6c9a8fb0c390c21b77340455df70734abaf61342
Author: maxbogue <maxbogue@chromium.org>
Date: Thu Nov 17 20:08:36 2016

[Sync] Move ChangeProcessor to model/.

BUG= 631271 , 663125 

Review-Url: https://codereview.chromium.org/2508003002
Cr-Commit-Position: refs/heads/master@{#432938}

[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/browser_sync/profile_sync_service_mock.h
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/BUILD.gn
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/driver/frontend_data_type_controller.cc
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/driver/frontend_data_type_controller_unittest.cc
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/driver/generic_change_processor.h
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/driver/glue/sync_backend_registrar.cc
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/driver/glue/sync_backend_registrar_unittest.cc
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/driver/sync_api_component_factory_mock.cc
[rename] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/model/change_processor.cc
[rename] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/model/change_processor.h
[rename] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/model/change_processor_mock.cc
[rename] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync/model/change_processor_mock.h
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync_bookmarks/bookmark_change_processor.h
[modify] https://crrev.com/6c9a8fb0c390c21b77340455df70734abaf61342/components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/288c6917ae57645088e0b3346a150be9a2bf5c2c

commit 288c6917ae57645088e0b3346a150be9a2bf5c2c
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Nov 18 05:27:32 2016

[Sync] Move sync's ModelSafeWorker implementations to engine/.

PassiveModelWorker already lives in engine/; BrowserThreadModelWorker
and UIModelWorker should too. This unblocks moving SyncBackendRegistrar
to engine/ as well.

BUG= 631271 ,  663125 

Review-Url: https://codereview.chromium.org/2503423004
Cr-Commit-Position: refs/heads/master@{#433118}

[modify] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/BUILD.gn
[modify] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/driver/glue/sync_backend_registrar_unittest.cc
[rename] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/engine/browser_thread_model_worker.cc
[rename] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/engine/browser_thread_model_worker.h
[rename] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/engine/browser_thread_model_worker_unittest.cc
[rename] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/engine/ui_model_worker.cc
[rename] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/engine/ui_model_worker.h
[rename] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/components/sync/engine/ui_model_worker_unittest.cc
[modify] https://crrev.com/288c6917ae57645088e0b3346a150be9a2bf5c2c/ios/chrome/browser/sync/ios_chrome_sync_client.mm

Comment 18 by maxbogue@chromium.org, Feb 13 2017

Cc: maxbogue@chromium.org
Owner: s...@chromium.org
Assigning this to Sky; the only work that I was keeping this open to track is creating a driver_impl/ folder and moving as much stuff from driver/ to it as possible.

Also everything in driver/glue/ should go to engine/ somewhere, but that's probably more under the domain of 669967.

Comment 19 by s...@chromium.org, Jan 17 2018

Status: Fixed (was: Assigned)
All of the work that is going to be done has done. We can always improve things, but no more work is planning for the immediate future.
►

Sign in to add a comment