New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631270 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
mus

Blocked on:
issue 616673
issue 671205

Blocking:
issue 653126
issue 674757



Sign in to add a comment

Fix event dispatch to renderer in --use-mus-in-renderer

Project Member Reported by sadrul@chromium.org, Jul 25 2016

Issue description

With --use-mus-in-renderer flag, chrome browser installs itself as the event handler for the chrome renderer (https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_mus.cc?sq=package:chromium&dr=Ss&l=51). As a result, events targeted to the renderer goes to RenderWidgetHostViewMus (https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_mus.cc?sq=package:chromium&dr=Ss&l=306). These events are currently dropped. We need to dispatch these events through RenderWidgetHostImpl/InputRouterImpl etc. to the renderer.

RenderWidgetHostViewAura knows how to dispatch ui::Events to the renderer. We should refactor that code, so that RenderWidgetHostViewMus can use the same code to dispatch the ui::Events it receives from the window server to the renderer.
 
Blockedon: 616673
Labels: Proj-Mustash
Components: Internals>MUS
Blocking: 653126
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2

commit 2843ae3645cbbdf62b5ab7a16f89842ff40c86a2
Author: jonross <jonross@chromium.org>
Date: Fri Oct 21 16:48:23 2016

We would like to share the event handling logic of RenderWidgetHostViewAura with RenderWidgetHostViewMus. As a first step this change refactors the EventHandler code out of RenderWidgetHostViewAura into its own class

TEST=manually run browser, dry-run of CQ to verify all existing tests.
BUG= 631270 

Review-Url: https://chromiumcodereview.appspot.com/2317333002
Cr-Commit-Position: refs/heads/master@{#426815}

[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/BUILD.gn
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/DEPS
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_base.h
[add] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[add] https://crrev.com/2843ae3645cbbdf62b5ab7a16f89842ff40c86a2/content/browser/renderer_host/render_widget_host_view_event_handler.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cdf0429c899039b2b903888a680bce541c8cf4

commit d8cdf0429c899039b2b903888a680bce541c8cf4
Author: jonross <jonross@chromium.org>
Date: Tue Nov 29 23:07:25 2016

Fix mus-in-renderer scale factor crash

Currently --mus-in-renderer crashes the renderer process on startup. The
WindowTreeClient attempts to check the display scale factor, but the screen
is not being set in that process.

This change returns a default scale factor when there is no available screen.
This will become redundant once aura-mus is ready, as proper screens will
be available.

TEST=manually ran --mus-in-renderer renderer works and paints.
BUG= 631270 

Review-Url: https://codereview.chromium.org/2540773002
Cr-Commit-Position: refs/heads/master@{#435102}

[modify] https://crrev.com/d8cdf0429c899039b2b903888a680bce541c8cf4/services/ui/public/cpp/window_tree_client.cc

Blockedon: 671205

Comment 8 by sky@chromium.org, Dec 15 2016

Blocking: 674757
Status: WontFix (was: Assigned)
This bug is invalid after the switch to the aura client-lib in the chrome-browser.
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment