New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631266 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

CRD toolbar is translucent in Android N split screen mode

Project Member Reported by ajnolley@chromium.org, Jul 25 2016

Issue description

Version: any version of CRD
OS: Android N

What steps will reproduce the problem?
(1)Use Android CRD app to connect to any host and activate split screen mode
(2)Note that CRD toolbar is translucent, with desktop items visible beneath



 

Comment 1 by joedow@chromium.org, Jul 28 2016

Owner: joedow@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by joedow@chromium.org, Jul 28 2016

Components: Services>Chromoting
This may be OK, I'll need to see if this is problematic or not after I address the toolbar visibility issue (I think we fix one or the other).

Comment 3 by joedow@chromium.org, Aug 23 2016

Labels: M-55
Labels: -M-55 M-56

Comment 5 by joedow@chromium.org, Oct 25 2016

Status: Started (was: Assigned)
I'm going to use this as my main tracking bug for Android N toolbar handling.  All of the odd behaviors are related so I want to tack the change(s) needed to address it here.

Comment 6 by joedow@chromium.org, Oct 25 2016

Cc: joedow@chromium.org
 Issue 653747  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/847adc99338f55ab58704c17dbc2c9e2c54b8fcc

commit 847adc99338f55ab58704c17dbc2c9e2c54b8fcc
Author: joedow <joedow@chromium.org>
Date: Fri Nov 04 18:14:51 2016

Updating Toolbar Autohide behavior to account for multi-window mode.

This change updates the Desktop activity to be Multi-Window aware and to
disable the Autohide Toolbar behavior when in that mode.

When an activity is in Multi-window mode, the System UI is always
present (and cannot be dismissed).  If an activity tries to dismiss the
System UI, no effect will take place.  Thus we should not even set up
the autohide timer in this scenario.

With respect to multi-window mode, there is a method that can be called
to ascertain which mode the activity is in, however one catch is that
you cannot call it from OnCreate due to a race condition (OnResume is
ok).  Thus I have set up a helper function with a precondition (called
after OnResume()) which will return whether it is in Multi-window mode.

One last change is to leave the video stream running if the activity is
paused in Multi-window mode.  When two activities are in split-screen
mode, the currently selected activity is in the running state and the
other is in a paused state.  I think we should continune updating the
video surface if we are in split screen and paused as the user may be
waiting for an action to occur before switching back to our activity.
Thus I have updated the logic to only disable the video stream on pause
if the activity is not in Multi-window mode (it will still be stopped
when the activity is stopped).

BUG= 631266 

Review-Url: https://codereview.chromium.org/2475373002
Cr-Commit-Position: refs/heads/master@{#429953}

[modify] https://crrev.com/847adc99338f55ab58704c17dbc2c9e2c54b8fcc/remoting/android/java/src/org/chromium/chromoting/Desktop.java

Cc: -joedow@chromium.org
Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified Fixed in 56.0.2913.4. CRD toolbar remains visible. system UI remains visible. Animation continues if the other window is selected and interacted with. No regressions were found in testing. 

Sign in to add a comment