New issue
Advanced search Search tips

Issue 631264 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Implement Location Service consent.

Project Member Reported by khmel@chromium.org, Jul 25 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/905787aa98feb38d969bcf03b0214a9d1a5a4c43

commit 905787aa98feb38d969bcf03b0214a9d1a5a4c43
Author: khmel <khmel@chromium.org>
Date: Tue Jul 26 00:31:18 2016

arc: Use location service consent.

This adds option to use location service into OptIn flow and fix
similar backup and restore consent.

BUG= 631264 
TEST=Manually on device together with Android side CL. On fresh device
     go through OptIn flow and set use location service off. Start
     Play Store and install Google Maps app. On start, Google Maps
     asks permission to activate usage of Location service. Disable
     and re-enable Arc and go throug OptIn flow but set this feature
     on and repeat Google Maps installation. On start, Google maps
     app does not ask permission to modify usage Location service.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2179803002
Cr-Commit-Position: refs/heads/master@{#407650}

[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/chromeos/arc/arc_auth_service.h
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/chromeos/arc/arc_settings_service.cc
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/chromeos/arc/arc_support_host.h
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/common/pref_names.cc
[modify] https://crrev.com/905787aa98feb38d969bcf03b0214a9d1a5a4c43/chrome/common/pref_names.h

Comment 2 by khmel@chromium.org, Jul 26 2016

Status: Fixed (was: Started)

Comment 3 by khmel@chromium.org, Jul 26 2016

Labels: M-53
This implement Usage of Location Service consent in OptIn flow.

Please see inner bug for more details.

When do you plan to merge this to M53?

Comment 5 by khmel@chromium.org, Aug 2 2016

Labels: Merge-Request-53

Comment 6 by dimu@chromium.org, Aug 2 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/196bc1bb7bcd7e8086cf55cac2415618167a3682

commit 196bc1bb7bcd7e8086cf55cac2415618167a3682
Author: Xiyuan Xia <xiyuan@google.com>
Date: Wed Aug 03 16:43:39 2016

Merge "arc: Use location service consent."

> This adds option to use location service into OptIn flow and fix
> similar backup and restore consent.
>
> BUG= 631264 
> TEST=Manually on device together with Android side CL. On fresh device
>      go through OptIn flow and set use location service off. Start
>      Play Store and install Google Maps app. On start, Google Maps
>      asks permission to activate usage of Location service. Disable
>      and re-enable Arc and go throug OptIn flow but set this feature
>      on and repeat Google Maps installation. On start, Google maps
>      app does not ask permission to modify usage Location service.
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2179803002
> Cr-Commit-Position: refs/heads/master@{#407650}
> (cherry picked from commit 905787aa98feb38d969bcf03b0214a9d1a5a4c43)

Review URL: https://codereview.chromium.org/2212463002 .

Cr-Commit-Position: refs/branch-heads/2785@{#488}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/chromeos/arc/arc_auth_service.h
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/chromeos/arc/arc_settings_service.cc
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/chromeos/arc/arc_support_host.h
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/resources/chromeos/arc_support/background.js
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/resources/chromeos/arc_support/main.css
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/browser/resources/chromeos/arc_support/main.html
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/common/pref_names.cc
[modify] https://crrev.com/196bc1bb7bcd7e8086cf55cac2415618167a3682/chrome/common/pref_names.h

Status: Verified (was: Fixed)

Sign in to add a comment