New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631253 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Implement Chrome sync for Arc package meta data.

Project Member Reported by lgcheng@google.com, Jul 25 2016

Issue description

Implement Chrome sync service for Arc package meta data.

Buganizer link: http://b/28024050

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 26 2016

Labels: Hotlist-Google

Comment 2 by dimu@chromium.org, Jul 26 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16

commit 68bc3e7017f97a20f7deaf3ae5601f2f68c62e16
Author: lgcheng <lgcheng@google.com>
Date: Wed Aug 03 02:32:48 2016

arc: Initial implemetation of Chrome sync for Arc packages.
Sync protos is introduced in:
https://codereview.chromium.org/2092893002/.

BUG= 631253 
TEST=Dependent Patchset: https://codereview.chromium.org/2174753004/

Review-Url: https://codereview.chromium.org/2106663004
Cr-Commit-Position: refs/heads/master@{#409437}

[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[add] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[add] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_package_syncable_service.h
[add] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_package_syncable_service_factory.cc
[add] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/app_list/arc/arc_package_syncable_service_factory.h
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/68bc3e7017f97a20f7deaf3ae5601f2f68c62e16/chrome/chrome_browser_ui.gypi

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a

commit f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a
Author: lgcheng <lgcheng@google.com>
Date: Wed Aug 03 05:21:11 2016

arc:Integration test for Arc package Chrome sync.

This Patch depends on:
https://codereview.chromium.org/2106663004

BUG= 631253 
TEST=Pass added integration tests.

Review-Url: https://codereview.chromium.org/2174753004
Cr-Commit-Position: refs/heads/master@{#409461}

[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/chromeos/profiles/profile_helper.h
[add] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc
[add] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/sync/test/integration/sync_arc_package_helper.cc
[add] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/sync/test/integration/sync_arc_package_helper.h
[add] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h
[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/chrome_tests.gypi
[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/chrome/test/BUILD.gn
[modify] https://crrev.com/f0d5430a0e13a019f7fbdbe69fbb63c92d9e719a/components/arc/test/fake_app_instance.cc

Project Member

Comment 6 by sheriffbot@chromium.org, Aug 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 8 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ebbe53295b1500f5492184b90a4e2357584551e

commit 7ebbe53295b1500f5492184b90a4e2357584551e
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Mon Aug 08 20:34:04 2016

[Merge to M53] arc: Initial implemetation of Chrome sync for Arc packages.
Sync protos is introduced in:
https://codereview.chromium.org/2092893002/.

BUG= 631253 
TEST=Dependent Patchset
Review-Url: https://codereview.chromium.org/2106663004
Cr-Commit-Position: refs/heads/master@{#409437}
(cherry picked from commit 50880b669bd0a6a13bb9030f3d4cfdd74fec2ef0)

R=lhchavez@chromium.org, pavely@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/2205843004 .

Cr-Commit-Position: refs/branch-heads/2785@{#533}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/sync/profile_sync_service_factory_unittest.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_app_test.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_app_test.h
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
[add] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[add] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_package_syncable_service.h
[add] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_package_syncable_service_factory.cc
[add] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/app_list/arc/arc_package_syncable_service_factory.h
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/7ebbe53295b1500f5492184b90a4e2357584551e/components/arc/instance_holder.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f7eed6eefe157b9deb1dad8e2fe39e06305867b

commit 4f7eed6eefe157b9deb1dad8e2fe39e06305867b
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Mon Aug 08 20:40:51 2016

[Merge to M53] Integration test for Arc package Chrome sync.

This Patch depends on:
https://codereview.chromium.org/2205843004

BUG= 631253 
TEST=Pass added integration tests.
Review-Url: https://codereview.chromium.org/2174753004
Cr-Commit-Position: refs/heads/master@{#409461}
(cherry picked from commit 324b6cd92085c5dcce4a086aa613b643d886ff01)

R=lhchavez@chromium.org, pavely@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/2207603002 .

Cr-Commit-Position: refs/branch-heads/2785@{#534}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/chromeos/profiles/profile_helper.h
[add] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc
[add] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/sync/test/integration/sync_arc_package_helper.cc
[add] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/sync/test/integration/sync_arc_package_helper.h
[add] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/sync/test/integration/two_client_arc_package_sync_test.cc
[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.cc
[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/ui/app_list/arc/arc_app_list_prefs_factory.h
[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc
[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/chrome_tests.gypi
[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/chrome/test/BUILD.gn
[modify] https://crrev.com/4f7eed6eefe157b9deb1dad8e2fe39e06305867b/components/arc/test/fake_app_instance.cc

Comment 9 by lgcheng@google.com, Aug 16 2016

Status: Fixed (was: Started)
Labels: VerifyIn-54
Labels: VerifyIn-55

Comment 12 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 13 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 14 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 15 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 16 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 18 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment