New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631249 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 425627



Sign in to add a comment

Make space below Advanced toggle to see start of advanced sections

Project Member Reported by dschuyler@chromium.org, Jul 25 2016

Issue description

1) in chrome://md-settings scroll to the bottom.
2) click Advanced to expand the advanced settings.

Problem: it's not obvious that more settings are available (other than the scroll bar changing).

Fix: Add some overscroll (padding) under the Advanced toggle so that part of the advanced options will be seen.

 
Blocking: 425627
Here are some screen shots with 64px of overscroll at the bottom.
Screenshot from 2016-07-25 16:26:57.png
33.1 KB View Download
Screenshot from 2016-07-25 16:27:16.png
35.0 KB View Download
Here are some shots with 48px and 128px below the Advanced toggle.
Screenshot from 2016-07-25 16:27:54.png
35.2 KB View Download
Screenshot from 2016-07-25 16:28:32.png
43.3 KB View Download

Comment 4 by bettes@chromium.org, Jul 26 2016

Let's go with comment 2, please. Thanks Dave!
Labels: Hotlist-MD-Settings-Structure
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46ffd77c225d30b65092545efe2712589e611601

commit 46ffd77c225d30b65092545efe2712589e611601
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Aug 03 23:46:33 2016

[MD settings] shrink overscroll when scrolling up

This CL will shrink the overscroll height at the bottom of the page
while scrolling the content. It also adds a minimum height for the
overscroll to allow space for the advanced page content to be seen when
the Advanced Toggle is used.

BUG= 593989 ,  631249 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2206723002
Cr-Commit-Position: refs/heads/master@{#409669}

[modify] https://crrev.com/46ffd77c225d30b65092545efe2712589e611601/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/46ffd77c225d30b65092545efe2712589e611601/chrome/browser/resources/settings/settings_main/settings_main.js

Status: Fixed (was: Started)

Sign in to add a comment