New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631244 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Simplify LocationUtils

Project Member Reported by cco3@chromium.org, Jul 25 2016

Issue description

LocationUtils methods require a Context parameter when the only Context needed is the application context.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/492ecfd905ed7b508243c440d12380671d5ea1aa

commit 492ecfd905ed7b508243c440d12380671d5ea1aa
Author: Conley Owens <cco3@google.com>
Date: Tue Jul 26 17:35:40 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b708f491f4807afcac289b6704b59a4a69d53e28

commit b708f491f4807afcac289b6704b59a4a69d53e28
Author: cco3 <cco3@chromium.org>
Date: Mon Aug 01 23:57:33 2016

Remove Context param from LocationUtils methods

LocationUtils methods require a Context, when the only Context needed
is the Application Context.  This change uses ContextUtils to get the
Application Context and removes the Context parameters from the
relevant methods in LocationUtils.

BUG= 631244 

Review-Url: https://codereview.chromium.org/2183563002
Cr-Commit-Position: refs/heads/master@{#409093}

[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/preferences/LocationSettings.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/LocationCategory.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/LocationSettingsTestUtil.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/components/location/android/java/src/org/chromium/components/location/LocationUtils.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothAdapter.java
[modify] https://crrev.com/b708f491f4807afcac289b6704b59a4a69d53e28/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/5bf5c10ea609f8016a8db587374b0c7e36df8041

commit 5bf5c10ea609f8016a8db587374b0c7e36df8041
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Tue Aug 02 11:45:42 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/e706bd134c226a09fadd5a7b5bc618e57ecbdc3a

commit e706bd134c226a09fadd5a7b5bc618e57ecbdc3a
Author: Conley Owens <cco3@google.com>
Date: Tue Aug 02 16:35:43 2016

Comment 5 by cco3@chromium.org, Aug 2 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3e122b0407fcc39898a46a3ac7db9d16f5a0efd

commit c3e122b0407fcc39898a46a3ac7db9d16f5a0efd
Author: cco3 <cco3@chromium.org>
Date: Tue Aug 02 18:11:45 2016

Remove extra method from LocationUtils

LocationUtils has an implementation of
isSystemLocationSettingEnabled that unecessarily takes a Context
parameter.  This change removes that method.

BUG= 631244 

Review-Url: https://codereview.chromium.org/2204773002
Cr-Commit-Position: refs/heads/master@{#409242}

[modify] https://crrev.com/c3e122b0407fcc39898a46a3ac7db9d16f5a0efd/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
[modify] https://crrev.com/c3e122b0407fcc39898a46a3ac7db9d16f5a0efd/components/location/android/java/src/org/chromium/components/location/LocationUtils.java

Sign in to add a comment