New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631220 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

SyncChrome stage failing on M53 for x86-mario, x86-zgb and squawks

Project Member Reported by kevcheng@chromium.org, Jul 25 2016

Issue description

No payloads are generated for these boards due to SyncChrome failing consistently.

https://uberchromegw.corp.google.com/i/chromeos_release/builders/x86-mario-release%20release-R53-8530.B/builds/21/steps/SyncChrome/logs/stdio

https://uberchromegw.corp.google.com/i/chromeos_release/builders/x86-zgb-release%20release-R53-8530.B/builds/26/steps/SyncChrome/logs/stdio

https://uberchromegw.corp.google.com/i/chromeos_release/builders/squawks-release%20release-R53-8530.B/builds/26/steps/SyncChrome/logs/stdio

The shared traceback:

Traceback (most recent call last):
  File "/b/depot_tools/gclient.py", line 2359, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/depot_tools/gclient.py", line 2345, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/b/depot_tools/gclient.py", line 2160, in CMDrevert
    return client.RunOnDeps('revert', args)
  File "/b/depot_tools/gclient.py", line 1550, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "/b/depot_tools/gclient_utils.py", line 907, in flush
    self._run_one_task(self.queued.pop(i), args, kwargs)
  File "/b/depot_tools/gclient_utils.py", line 999, in _run_one_task
    task_item.run(*args, **kwargs)
  File "/b/depot_tools/gclient.py", line 850, in run
    file_list)
  File "/b/depot_tools/gclient_scm.py", line 166, in RunCommand
    return getattr(self, command)(options, args, file_list)
  File "/b/depot_tools/gclient_scm.py", line 764, in revert
    return self.update(options, [], file_list)
  File "/b/depot_tools/gclient_scm.py", line 598, in update
    merge=options.merge)
AttributeError: Values instance has no attribute 'merge'
21:22:12: WARNING: Chrome checkout appears corrupt. Clobbering.
21:22:22: INFO: RunCommand: /b/depot_tools/gclient config --spec "solutions = [{'custom_deps': {},
  'custom_vars': {},
  'deps_file': 'releases/53.0.2785.27/DEPS',
  'managed': True,
  'name': 'CHROME_DEPS',
  'url': 'https://chrome-internal.googlesource.com/chrome/tools/buildspec.git'}]
" in /b/cbuild/shared_internal/.cache/distfiles/target/chrome-src-internal
21:22:22: INFO: RunCommand: /b/depot_tools/gclient sync --verbose --nohooks --transitive --with_branch_heads --with_tags --reset --force --delete_unversioned_trees in /b/cbuild/shared_internal/.cache/distfiles/target/chrome-src-internal
Looking for .gclient starting from /b/cbuild/shared_internal/.cache/distfiles/target/chrome-src-internal

 
Cc: d...@chromium.org
+dnj for his insights as well.
Labels: -Pri-3 Pri-1
Cc: aga...@chromium.org
+agable 

Aaron is looking into it and initial findings is that the commit message is a merge commit which is a problem (?).

Comment 4 by aga...@chromium.org, Jul 25 2016

Here's the simplest but also worst possible solution: https://codereview.chromium.org/2184493002

All the better solutions seem much too hard and complicated to land in any reasonable timeline.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c903d73f3cf002e7004d0bd51d130c5bf48f3fbc

commit c903d73f3cf002e7004d0bd51d130c5bf48f3fbc
Author: agable <agable@chromium.org>
Date: Tue Jul 26 16:07:24 2016

Give 'gclient revert' a --merge option to match sync

This is a workaround for the fact that 'gclient revert' calls
'gclient update' with the same `options` object, despite not
actually having the same set of command line options.

R=iannucci@chromium.org, kevcheng@chromium.org
BUG= 631220 

Review-Url: https://codereview.chromium.org/2184493002

[modify] https://crrev.com/c903d73f3cf002e7004d0bd51d130c5bf48f3fbc/gclient.py

Comment 6 by aga...@chromium.org, Jul 26 2016

Cc: -aga...@chromium.org kevcheng@chromium.org
Owner: aga...@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/81a696760ab7c25f6606c54fc781b90b8af9fdd2

commit 81a696760ab7c25f6606c54fc781b90b8af9fdd2
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 16:16:23 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/c903d73f3cf002e7004d0bd51d130c5bf48f3fbc Give 'gclient revert' a --merge option to match sync (agable@chromium.org)

R=agable@chromium.org,kevcheng@chromium.org,iannucci@chromium.org
BUG= 631220 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2178853007

[modify] https://crrev.com/81a696760ab7c25f6606c54fc781b90b8af9fdd2/infra/config/recipes.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/c4304e02739bcd5e1b78952ccd4c93158e98bca2

commit c4304e02739bcd5e1b78952ccd4c93158e98bca2
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 16:36:41 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/81a696760ab7c25f6606c54fc781b90b8af9fdd2 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/c903d73f3cf002e7004d0bd51d130c5bf48f3fbc Give 'gclient revert' a --merge option to match sync (agable@chromium.org)

R=kevcheng@chromium.org,iannucci@chromium.org,recipe-roller@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org,agable@chromium.org
BUG= 631220 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2184763003

[modify] https://crrev.com/c4304e02739bcd5e1b78952ccd4c93158e98bca2/infra/config/recipes.cfg

Status: Verified (was: Fixed)
kicked off a build and successfully went past the SyncChrome stage: https://uberchromegw.corp.google.com/i/chromeos_release/builders/x86-mario-release%20release-R53-8530.B/builds/24

Sign in to add a comment