New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631213 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 605572



Sign in to add a comment

Improve logging for native crashes from instrumentation tests

Project Member Reported by jbudorick@chromium.org, Jul 25 2016

Issue description

See attached, from https://codereview.chromium.org/2162193002/

This may also apply to gtests.
 
terrible_crash_messaging.txt
3.3 MB View Download
Status: Available (was: Untriaged)
Summary: Improve logging for native crashes from instrumentation tests (was: Terrible logging for native crashes from instrumentation tests)
Scoping this bug to just instrumentation tests. We can look at gtests separately, if necessary.
Blocking: 605572
Owner: hzl@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/691ffafc730315027ce0887c39d2d6393e5b2f26

commit 691ffafc730315027ce0887c39d2d6393e5b2f26
Author: kjellander <kjellander@chromium.org>
Date: Wed Aug 10 06:12:16 2016

Revert of Added tombstones in instrumentation tests results. (patchset #11 id:200001 of https://codereview.chromium.org/2201833002/ )

Reason for revert:
This breaks the stack_tool_for_tombstones step for many bots in https://build.chromium.org/p/chromium.android, like this:
W    0.547s Main  No tombstones.
Traceback (most recent call last):
  File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 304, in <module>
    sys.exit(main())
  File "/b/c/b/Android_Webview_L__dbg_/src/build/android/tombstones.py", line 300, in main
W    0.547s Main  No tombstones to resolve.
    for line in resolved_tombstones:
TypeError: 'NoneType' object is not iterable

Please make sure to have proper tests in place before relanding.

Original issue's description:
> Added tombstones in instrumentation tests results.
>
> If an instrumentation test crashes, the cl will grab the tombstones and
> add the tombstones as a part of the result.
>
> BUG= 631213 
>
> Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8
> Cr-Commit-Position: refs/heads/master@{#410929}

TBR=mikecase@chromium.org,jbudorick@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 631213 

Review-Url: https://codereview.chromium.org/2231693002
Cr-Commit-Position: refs/heads/master@{#410977}

[modify] https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26/build/android/pylib/instrumentation/test_result.py
[modify] https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26/build/android/test_runner.py
[modify] https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26/build/android/test_runner.pydeps
[modify] https://crrev.com/691ffafc730315027ce0887c39d2d6393e5b2f26/build/android/tombstones.py

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ff9ee5eb08ccdff4d4da042a53e2346a352130

commit 02ff9ee5eb08ccdff4d4da042a53e2346a352130
Author: hzl <hzl@google.com>
Date: Mon Aug 15 23:22:57 2016

Added tombstones in instrumentation tests results.

If an instrumentation test crashes, tombstones were not captured.
In this cl, tombstones are captured and becomes part of the result.

This is a reland of a previous cl, http://crrev.com/2201833002#ps200001.
The reason for reverting the previous cl is that:
it breaks the stack_tool_for_tombstones step for many bots in
https://build.chromium.org/p/chromium.android.
In this reland, the edge case where there is no tombstone is fixed.

BUG= 631213 

Committed: https://crrev.com/d7dd97f2828447fb9af45ea119e703500b167cb8
Cr-Commit-Position: refs/heads/master@{#410929}

patch from issue 2201833002 at patchset 200001 (http://crrev.com/2201833002#ps200001)

Review-Url: https://codereview.chromium.org/2237553003
Cr-Commit-Position: refs/heads/master@{#412089}

[modify] https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130/build/android/pylib/instrumentation/test_result.py
[modify] https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130/build/android/test_runner.py
[modify] https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130/build/android/test_runner.pydeps
[modify] https://crrev.com/02ff9ee5eb08ccdff4d4da042a53e2346a352130/build/android/tombstones.py

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fd77f58bc7711f0b4e701b1d3562076c1756e49

commit 6fd77f58bc7711f0b4e701b1d3562076c1756e49
Author: hzl <hzl@google.com>
Date: Tue Aug 23 02:42:11 2016

Add tombstones as part of json-results-file for android instr tests.

When a testcase crashes, a tombstone will be created. However in the
json-results-file, the tombstone information was not included. In this
cl, tombstones becomes a part of json-results-file.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2251863003
Cr-Commit-Position: refs/heads/master@{#413646}

[modify] https://crrev.com/6fd77f58bc7711f0b4e701b1d3562076c1756e49/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/6fd77f58bc7711f0b4e701b1d3562076c1756e49/build/android/pylib/instrumentation/test_result.py
[modify] https://crrev.com/6fd77f58bc7711f0b4e701b1d3562076c1756e49/build/android/pylib/results/json_results.py

Comment 9 by boliu@chromium.org, Sep 2 2016

Things haven't improved much honestly. This cq run of mine introduced a crash on start up for chrome. Where can I get to the native stack, or even the crash error message from this?

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/134954
#9: That's why this bug is still open.

Logcat is here: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=1117095cba15de29dfabae9a1e0040247262987c

notably, there are a lot of these:

Device(03d27c79006adc13) 09-01 23:51:04.189  4378  4447 F chromium: [FATAL:browser_child_process_host_impl.cc(128)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::UI). Must be called on Chrome_UIThread; actually called on Chrome_ProcessLauncherThread.
can we surface that link somewhere more obvious? that would help a lot in the short term.

Actually how did you get to that link..? I still haven't found it
File an Infra>Client>Android bug.

In the meantime, look for "shard #X isolated out" > logcats
> File an Infra>Client>Android bug.

Wait, this is not the bug for that..? :p
For surfacing that link? No, it isn't.
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e2aeace0df09b84dd4f175815f5fc4683e6d7656

commit e2aeace0df09b84dd4f175815f5fc4683e6d7656
Author: Zhiling Huang <hzl@google.com>
Date: Wed Nov 23 00:53:14 2016

Added a logcat column in test table.

Added a new column in test table, which has a link that will redirect to
a page that contains the logcat of the corresponding test case.

BUG= 631213 

Change-Id: I77d63556af60ee38a78fd2391d2104ea6efde0d3
Reviewed-on: https://chromium-review.googlesource.com/413551
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhiling Huang <hzl@google.com>

[modify] https://crrev.com/e2aeace0df09b84dd4f175815f5fc4683e6d7656/scripts/slave/recipe_modules/chromium_android/resources/test_results_presentation.py

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db14e1adbd87e01676f5915881571552e384a8d3

commit db14e1adbd87e01676f5915881571552e384a8d3
Author: hzl <hzl@google.com>
Date: Tue Nov 29 18:46:30 2016

Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2451523002
Cr-Commit-Position: refs/heads/master@{#435041}

[add] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/pylib/android/__init__.py
[add] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/pylib/results/json_results.py
[modify] https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3/build/android/test_runner.pydeps

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3d142161b15869f6bea58ac43c5f52ce5834ac

commit 7f3d142161b15869f6bea58ac43c5f52ce5834ac
Author: jbudorick <jbudorick@chromium.org>
Date: Tue Nov 29 20:53:20 2016

Revert of Insert logcat as part of test result for android instrumentation tests. (patchset #12 id:220001 of https://codereview.chromium.org/2451523002/ )

Reason for revert:
breaking on chromium.android: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/6567

Original issue's description:
> Insert logcat as part of test result for android instrumentation tests.
>
> In this cl, we are trying to add the logcat of each instrumentation
> test into the corresponding test result object, so that when we are
> checking the result of each test case, we would be able to see the
> corresponding logcat for that test case at the same time.
>
> BUG= 631213 
>
> Committed: https://crrev.com/db14e1adbd87e01676f5915881571552e384a8d3
> Cr-Commit-Position: refs/heads/master@{#435041}

TBR=mikecase@chromium.org,hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 631213 

Review-Url: https://codereview.chromium.org/2539953002
Cr-Commit-Position: refs/heads/master@{#435078}

[delete] https://crrev.com/61343b095788170874ce18d6ffd86963cba14141/build/android/pylib/android/__init__.py
[delete] https://crrev.com/61343b095788170874ce18d6ffd86963cba14141/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac/build/android/pylib/results/json_results.py
[modify] https://crrev.com/7f3d142161b15869f6bea58ac43c5f52ce5834ac/build/android/test_runner.pydeps

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/c9e0d07c8f08b5b48df48091053a730a662de9bd

commit c9e0d07c8f08b5b48df48091053a730a662de9bd
Author: Zhiling Huang <hzl@google.com>
Date: Wed Nov 30 00:49:59 2016

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a1d024b42300e2b364f271d196fd8dc6e00b2e

commit e4a1d024b42300e2b364f271d196fd8dc6e00b2e
Author: hzl <hzl@google.com>
Date: Wed Nov 30 14:03:53 2016

Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2537813003
Cr-Commit-Position: refs/heads/master@{#435247}

[add] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/pylib/android/__init__.py
[add] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/pylib/results/json_results.py
[modify] https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e/build/android/test_runner.pydeps

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e754eabfec7290ec39ab1cb7eb9e127dfebe76fc

commit e754eabfec7290ec39ab1cb7eb9e127dfebe76fc
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Nov 30 18:48:46 2016

Revert of Insert logcat as part of test result for android instrumentation tests. (patchset #2 id:20001 of https://codereview.chromium.org/2537813003/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=669989

Original issue's description:
> Insert logcat as part of test result for android instrumentation tests.
>
> In this cl, we are trying to add the logcat of each instrumentation
> test into the corresponding test result object, so that when we are
> checking the result of each test case, we would be able to see the
> corresponding logcat for that test case at the same time.
>
> BUG= 631213 
>
> Committed: https://crrev.com/e4a1d024b42300e2b364f271d196fd8dc6e00b2e
> Cr-Commit-Position: refs/heads/master@{#435247}

TBR=hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 631213 

Review-Url: https://codereview.chromium.org/2541113002
Cr-Commit-Position: refs/heads/master@{#435356}

[delete] https://crrev.com/aa615f0788de433dc70c6e82f4911418f854be31/build/android/pylib/android/__init__.py
[delete] https://crrev.com/aa615f0788de433dc70c6e82f4911418f854be31/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/e754eabfec7290ec39ab1cb7eb9e127dfebe76fc/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/e754eabfec7290ec39ab1cb7eb9e127dfebe76fc/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/e754eabfec7290ec39ab1cb7eb9e127dfebe76fc/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/e754eabfec7290ec39ab1cb7eb9e127dfebe76fc/build/android/pylib/results/json_results.py
[modify] https://crrev.com/e754eabfec7290ec39ab1cb7eb9e127dfebe76fc/build/android/test_runner.pydeps

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9

commit 79e6121247da1485bda4ae4b0d4b4249eb4ff1a9
Author: hzl <hzl@google.com>
Date: Thu Dec 01 04:15:05 2016

(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

The reason of reland is to fix the issue where environmental variables are not set.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2545653002
Cr-Commit-Position: refs/heads/master@{#435550}

[add] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/pylib/android/__init__.py
[add] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/pylib/results/json_results.py
[modify] https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9/build/android/test_runner.pydeps

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ada01f1acd69c5d93f92a725c86033a33b6de58

commit 8ada01f1acd69c5d93f92a725c86033a33b6de58
Author: jbudorick <jbudorick@chromium.org>
Date: Thu Dec 01 15:02:33 2016

Revert of (Reland) Insert logcat as part of test result for android instrumentation tests. (patchset #3 id:40001 of https://codereview.chromium.org/2545653002/ )

Reason for revert:
Failing on large suites: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/5996/steps/chrome_public_test_apk/logs/stdio

Original issue's description:
> (Reland) Insert logcat as part of test result for android instrumentation tests.
>
> In this cl, we are trying to add the logcat of each instrumentation
> test into the corresponding test result object, so that when we are
> checking the result of each test case, we would be able to see the
> corresponding logcat for that test case at the same time.
>
> The reason of reland is to fix the issue where environmental variables are not set.
>
> BUG= 631213 
>
> Committed: https://crrev.com/79e6121247da1485bda4ae4b0d4b4249eb4ff1a9
> Cr-Commit-Position: refs/heads/master@{#435550}

TBR=hzl@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 631213 

Review-Url: https://codereview.chromium.org/2548503002
Cr-Commit-Position: refs/heads/master@{#435606}

[delete] https://crrev.com/5a20f80e4b38f0649aafdef906fa582d7658bef1/build/android/pylib/android/__init__.py
[delete] https://crrev.com/5a20f80e4b38f0649aafdef906fa582d7658bef1/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58/build/android/pylib/results/json_results.py
[modify] https://crrev.com/8ada01f1acd69c5d93f92a725c86033a33b6de58/build/android/test_runner.pydeps

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d

commit af7d1b8ebb52ace8f7443689abf4e79cd117ef9d
Author: hzl <hzl@google.com>
Date: Fri Dec 02 01:11:18 2016

(Reland) Insert logcat as part of test result for android instrumentation tests.

In this cl, we are trying to add the logcat of each instrumentation
test into the corresponding test result object, so that when we are
checking the result of each test case, we would be able to see the
corresponding logcat for that test case at the same time.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2542333002
Cr-Commit-Position: refs/heads/master@{#435802}

[add] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/pylib/android/__init__.py
[add] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/pylib/results/json_results.py
[modify] https://crrev.com/af7d1b8ebb52ace8f7443689abf4e79cd117ef9d/build/android/test_runner.pydeps

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dd8eaafd2b4b13b712428688d0a7d397102bb29

commit 6dd8eaafd2b4b13b712428688d0a7d397102bb29
Author: hzl <hzl@google.com>
Date: Wed Dec 21 20:18:30 2016

Store tombstones url, not the actual tombstones, inside test result.

Previously we store the actual, huge tombstones inside test result
object. Now we record tombstones through logdog and view the tombstones
by visiting a url. Thus in test result object, we don't need the actual
tombstones anymore. We can just store the lighter tombstones url.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2581553004
Cr-Commit-Position: refs/heads/master@{#440199}

[modify] https://crrev.com/6dd8eaafd2b4b13b712428688d0a7d397102bb29/build/android/pylib/base/base_test_result.py
[modify] https://crrev.com/6dd8eaafd2b4b13b712428688d0a7d397102bb29/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/6dd8eaafd2b4b13b712428688d0a7d397102bb29/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/6dd8eaafd2b4b13b712428688d0a7d397102bb29/build/android/pylib/results/json_results.py

Project Member

Comment 25 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dae287d8e707b2b9774b6d26bfd6240aa366c12c

commit dae287d8e707b2b9774b6d26bfd6240aa366c12c
Author: jbudorick <jbudorick@chromium.org>
Date: Wed Apr 05 16:37:21 2017

[Android] Fix tombstone streaming to logdog.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2799673002
Cr-Commit-Position: refs/heads/master@{#462109}

[modify] https://crrev.com/dae287d8e707b2b9774b6d26bfd6240aa366c12c/build/android/pylib/local/device/local_device_gtest_run.py

Project Member

Comment 26 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726fecd251f8e697b3be0f23525a906f230c8ea3

commit 726fecd251f8e697b3be0f23525a906f230c8ea3
Author: hzl <hzl@google.com>
Date: Fri Apr 21 20:37:27 2017

[Android] Fix tombstone streaming to logdog.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2834143002
Cr-Commit-Position: refs/heads/master@{#466435}

[modify] https://crrev.com/726fecd251f8e697b3be0f23525a906f230c8ea3/build/android/pylib/local/device/local_device_instrumentation_test_run.py

Project Member

Comment 27 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc66094f89df0ecca2a3378296304a9c7e66bbff

commit fc66094f89df0ecca2a3378296304a9c7e66bbff
Author: hzl <hzl@google.com>
Date: Thu May 18 00:50:48 2017

Enable store tombstones for swarming bots.

Enable tombstones for swarming bots. Previously if a test case is
crashed on swarming bots, no tombstones will be resolved, and even if
they are attempted to be resolved, they will fail because of the lack of
tool chains.

In this cl, we are enabling tombstones for swarming bots and we are also
adding tool chains to the dependency.

BUG= 631213 

Review-Url: https://codereview.chromium.org/2883633003
Cr-Commit-Position: refs/heads/master@{#472615}

[modify] https://crrev.com/fc66094f89df0ecca2a3378296304a9c7e66bbff/build/secondary/third_party/android_platform/development/scripts/BUILD.gn
[modify] https://crrev.com/fc66094f89df0ecca2a3378296304a9c7e66bbff/tools/mb/mb.py

Status: Fixed (was: Assigned)

Sign in to add a comment