tfarina: Looks like you created these tests long ago. Could you look into making them non-flaky? Gab suggests that using the override manager in base/test/test_reg_util_win.h may help. Thanks.

Observing these flaky failures today; failure output for the record:

[ RUN      ] RegistryTest.ValueTest
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(96): error: Value of: key.WriteValue(kDWORDValueName, kDWORDData)
  Actual: 1018 (ERROR_KEY_DELETED)
Expected: 0L
Which is: 0
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(51): error: Value of: key.DeleteKey(kRootKey)
  Actual: 2 (ERROR_FILE_NOT_FOUND)
Expected: 0L
Which is: 0
[  FAILED  ] RegistryTest.ValueTest (11 ms)
[1958/2397] RegistryTest.ValueTest (11 ms)

[ RUN      ] RegistryTest.BigValueIteratorTest
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(148): error: Value of: key.WriteValue(data.c_str(), data.c_str())
  Actual: 1018 (ERROR_KEY_DELETED)
Expected: 0L
Which is: 0
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(51): error: Value of: key.DeleteKey(kRootKey)
  Actual: 2 (ERROR_FILE_NOT_FOUND)
Expected: 0L
Which is: 0
[  FAILED  ] RegistryTest.BigValueIteratorTest (66 ms)
[1959/2397] RegistryTest.BigValueIteratorTest (66 ms)

[ RUN      ] RegistryTest.TruncatedCharTest
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(179): error: Value of: iterator.Name()
  Actual: L"name2"
Expected: kName
Which is: L"name"
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(181): error: Value of: iterator.ValueSize()
  Actual: 12
Expected: (sizeof(ArraySizeHelper(kData)))
Which is: 5
c:\src\git-chrome-internal\src\base\win\registry_unittest.cc(51): error: Value of: key.DeleteKey(kRootKey)
  Actual: 2 (ERROR_FILE_NOT_FOUND)
Expected: 0L
Which is: 0
[  FAILED  ] RegistryTest.TruncatedCharTest (36 ms)

Are we just getting flakes because RegistryTest instances are running in parallel and all trying to work under the same key? Do we just need to use temporary key names instead?

I think so yes.

tfarina: would you please send up a CL for review? thanks.

@grt: ok, I will try to look at this later today.

grt: sorry, I don't have a Windows system to build and test this. Passing this on.

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot