Issue 631204 link

Starred by 3 users

Issue metadata

Status:	Archived
Owner:	█ girard@chromium.org Last visit 22 days ago
Closed:	Jul 2016
Cc:	tbuck...@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
VerifyIn-54 VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Code Cleanup: Remove Keyboard.KeystrokeDeltas

Project Member Reported by girard@chromium.org, Jul 25 2016

Issue description

Keyboard.KeystrokeDeltas (code, xml) has no owner (stevet@ left) and seems of dubious value, can it be removed? 

It was originally added for  issue 292290  to track "ms between omnibox keystrokes"

Comment 1 by girard@chromium.org, Jul 25 2016

See also issue 619808 and issue 621669

Comment 2 by girard@chromium.org, Jul 28 2016

Patch is at https://codereview.chromium.org/2187303002#

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f22cebd743e5c6681a2bb05549021ff393da9a3

commit 0f22cebd743e5c6681a2bb05549021ff393da9a3
Author: girard <girard@chromium.org>
Date: Thu Jul 28 22:35:08 2016

Remove KeyboardUmaEventFilter

Metric is no longer used (either by code, or by anyone)

BUG= 631204 

Review-Url: https://codereview.chromium.org/2187303002
Cr-Commit-Position: refs/heads/master@{#408500}

[modify] https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3/ash/ash.gyp
[delete] https://crrev.com/daead0ee14bf28ce22e7603a685fe1c12ae31607/ash/keyboard_uma_event_filter.cc
[delete] https://crrev.com/daead0ee14bf28ce22e7603a685fe1c12ae31607/ash/keyboard_uma_event_filter.h
[modify] https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3/ash/shell.cc
[modify] https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3/ash/shell.h
[modify] https://crrev.com/0f22cebd743e5c6681a2bb05549021ff393da9a3/tools/metrics/histograms/histograms.xml