New issue
Advanced search Search tips

Issue 631188 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 630060
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"Failure reason" step is green

Project Member Reported by no...@chromium.org, Jul 25 2016

Issue description

Recipe engine produces "Failure reason" steps in case of an error.
The step is closed with @@@STEP_CLOSED@@@ which causes the step to be rendered green in milo, e.g. https://luci-milo.appspot.com/swarming/task/302ef59af64c9d10

this is confusing. It should be closed with STEP_FAILURE or STEP_EXCEPTION
 

Comment 1 by no...@chromium.org, Jul 25 2016

Labels: -Pri-1 Pri-2
Mergedinto: 630060
Status: Duplicate (was: Untriaged)
I agree that this is confusing. However, it we close the step with STEP_FAILURE, then buildbot (and maybe milo??) sees this step as a failure, and it shows up in all our sheriffing tooling. We made this change at some point, and it caused a bunch of duplicate and anonying steps to show up on sheriff-o-matic, and it spammed a bunch of stuff in chromium try flakes. 

I've duped this bug with a bug which discusses a solution for the problem; feel free to comment on the bug if you have any ideas, or want to make it higher priority.

Sign in to add a comment