Less flippant "Monitor not supported" notification |
||||
Issue descriptionSpun off from Issue 271481 : If an attached external monitor is not supported, we currently show the notification message "Dear Monitor, it's not working out between us. (No supported resolution found.)" This can be seen as too flippant when something's not working, so we should rewrite this string to be more thoughtful (and maybe even helpful)?
,
Nov 1 2016
,
Nov 20 2016
Here's how the notification currently looks, as of Patch #4 of the CL (https://codereview.chromium.org/2490323003/#ps60001). The "Send a feedback report" box is a hover-highlightable button.
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6ce8aec3fb0085ba29428df825cc6fee7f79975 commit c6ce8aec3fb0085ba29428df825cc6fee7f79975 Author: glevin <glevin@chromium.org> Date: Tue Dec 13 17:42:37 2016 Improve monitor compatibility error, move feedback link into button BUG= 631181 TEST=Plug in unsupported monitor, note that error notification string has changed to "This monitor isn't getting along with your Chromebook (the monitor is not supported)." Also, "Send a feedback report" should be in a lower button. Review-Url: https://codereview.chromium.org/2490323003 Cr-Commit-Position: refs/heads/master@{#438212} [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/ash_chromeos_strings.grdp [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/display/display_configuration_controller.cc [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/display/display_error_observer_chromeos.cc [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/display/display_error_observer_chromeos_unittest.cc [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/display/display_util.cc [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/display/display_util.h [modify] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/resources/vector_icons/notification_display_error.icon [add] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/resources/vector_icons/notification_feedback_button.1x.icon [add] https://crrev.com/c6ce8aec3fb0085ba29428df825cc6fee7f79975/ash/resources/vector_icons/notification_feedback_button.icon
,
Dec 14 2016
This CL also switched the monitor icon to a new MD version, and moved the "Send feedback" link into a separate button with icon. Screenshot of final version is attached. (Icon position and text have changed since last screenshot.)
,
Mar 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by glevin@chromium.org
, Jul 25 2016