Allo StreamTextureProxy to be initialized by a callback rather than a VideoFrameProvider |
|||
Issue descriptionStreamTextureProxy currently requires a VideoFrameProvider::Client* to be initialized. The interface should be changed to accept a base::Closure, so that "media/blink/stream_texture_wrapper.h" no longer needs to include "cc/layers/video_frame_provider.h", and so StreamTextureWrapper can be moved to "media/base/android". This might be easier to do after WMPA is removed ( crbug.com/580626 ), when the StreamTextureWrapper is the only consumer of StreamTextureProxy.
,
Jul 28 2016
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed commit f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed Author: tguilbert <tguilbert@chromium.org> Date: Tue Aug 02 00:19:39 2016 Update StreamTextureProxy to accept a base::Closure StreamTextureProxy (STP) is currently tightly coupled to the VideoFrameProvider::Client (VFP::C). This forces classes that use STP to be aware of the VFP::C, and forces them to include files from cc/layers. This change updates STP to accept a custom callback to be triggered when the STP's OnFrameAvailable() is signaled. It also moves StreamTextureWrapper from media/blink to media/base/android, now that it no longer needs to include cc/layers/video_frame_provider.h. TEST= Made sure we could still use WMPA (opened an HLS stream on an android device) BUG= 631178 Review-Url: https://codereview.chromium.org/2192823004 Cr-Commit-Position: refs/heads/master@{#409100} [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/content/renderer/media/android/stream_texture_factory.cc [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/content/renderer/media/android/stream_texture_factory.h [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/content/renderer/media/android/stream_texture_wrapper_impl.cc [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/content/renderer/media/android/stream_texture_wrapper_impl.h [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/content/renderer/media/android/webmediaplayer_android.cc [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/content/renderer/media/android/webmediaplayer_android.h [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/media/base/android/BUILD.gn [rename] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/media/base/android/stream_texture_wrapper.h [modify] https://crrev.com/f4d502c5ec011e3b5b3aea1669b1d6149d5b9aed/media/blink/BUILD.gn
,
Aug 2 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tguilbert@chromium.org
, Jul 25 2016