Reduce logging noise in i2c-cros-ec-tunnel |
||||||||||||||
Issue descriptionIf an I2C read from i2c-cros-ec-tunnel returns an error, the error is logged in the kernel log. cros-ec-i2c-tunnel ff200000.spi:ec@0:i2c-tunnel: Error parsing EC i2c message It is perfectly normal for i2c accesses to return an error, for example if the kernel or user space tries to access a chip which does not exist or is held in reset. An example is the "i2c-detect" command, which tries to access each chip on the bus. The error message should be dropped.
,
Aug 5 2016
https://patchwork.kernel.org/patch/9249063 (Oh I see you're uploading now.)
,
Aug 10 2016
Waiting for feedback from maintainer
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/71e479eb4a35b7745abcb0a43cee70e3970eff71 commit 71e479eb4a35b7745abcb0a43cee70e3970eff71 Author: Guenter Roeck <linux@roeck-us.net> Date: Tue Jul 26 22:34:01 2016 FROMLIST: i2c: i2c-cros-ec-tunnel: Reduce logging noise If an i2c access through i2c-cros-ec-tunnel returns an error, the following log message is seen on the console. cros-ec-i2c-tunnel ff200000.spi:ec@0:i2c-tunnel: Error parsing EC i2c message -121 This can happen a lot if, for example, the i2c-detect command is executed. Since it is perfectly normal for an i2c controller to report an error, drop the message. Also, report -ENXIO instead of -EREMOTEIO if the access error is due to NAK from the device, and return -EIO instead of -EREMOTEIO for other errors, as suggested in Documentation/i2c/fault-codes. BUG= chromium:631172 , chrome-os-partner:55954 TEST=Boot any system with i2c-cros-ec-tunnel and run i2cdetect Signed-off-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Douglas Anderson <dianders@chromium.org> (am from https://patchwork.kernel.org/patch/9249063/mbox/) Signed-off-by: Guenter Roeck <groeck@chromium.org> Change-Id: Ic456d523ca0da6c559cb148828001cd958b1a993 Reviewed-on: https://chromium-review.googlesource.com/376957 Reviewed-by: Katie Roberts-Hoffman <katierh@chromium.org> Commit-Queue: Wonjoon Lee <woojoo.lee@samsung.com> Tested-by: Wonjoon Lee <woojoo.lee@samsung.com> [modify] https://crrev.com/71e479eb4a35b7745abcb0a43cee70e3970eff71/drivers/i2c/busses/i2c-cros-ec-tunnel.c
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f2f7c3b0dc189d2427b81e91e2fe31d53d079e2f commit f2f7c3b0dc189d2427b81e91e2fe31d53d079e2f Author: Guenter Roeck <linux@roeck-us.net> Date: Tue Jul 26 22:34:01 2016 FROMLIST: i2c: i2c-cros-ec-tunnel: Reduce logging noise If an i2c access through i2c-cros-ec-tunnel returns an error, the following log message is seen on the console. cros-ec-i2c-tunnel ff200000.spi:ec@0:i2c-tunnel: Error parsing EC i2c message -121 This can happen a lot if, for example, the i2c-detect command is executed. Since it is perfectly normal for an i2c controller to report an error, drop the message. Also, report -ENXIO instead of -EREMOTEIO if the access error is due to NAK from the device, and return -EIO instead of -EREMOTEIO for other errors, as suggested in Documentation/i2c/fault-codes. BUG= chromium:631172 , chrome-os-partner:55954 TEST=Boot any system with i2c-cros-ec-tunnel and run i2cdetect Signed-off-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Douglas Anderson <dianders@chromium.org> (am from https://patchwork.kernel.org/patch/9249063/mbox/) Signed-off-by: Guenter Roeck <groeck@chromium.org> Change-Id: Ic456d523ca0da6c559cb148828001cd958b1a993 Reviewed-on: https://chromium-review.googlesource.com/366560 Commit-Ready: Douglas Anderson <dianders@chromium.org> Tested-by: Guenter Roeck <groeck@chromium.org> Tested-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> [modify] https://crrev.com/f2f7c3b0dc189d2427b81e91e2fe31d53d079e2f/drivers/i2c/busses/i2c-cros-ec-tunnel.c
,
Sep 1 2016
Calling this one fixed. Please feel free to reopen if needed. Also, w.r.t. Chromium, this is "Chrome" OS, not "Linux" :)
,
Sep 6 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by briannorris@chromium.org
, Aug 5 2016