New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631163 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 477283



Sign in to add a comment

DevTools: make "replace" menu usable

Project Member Reported by lushnikov@chromium.org, Jul 25 2016

Issue description

The "replace" menu is not usable ATM and looks ugly.

Lets do the following:
- kill the "replace" checkbox from the interface
- surface both "replace" and "search" in the context menu of the source frame
- stop using table while layouting "search" and "replace" interface 


 
Attached is a screenshot of replace menu in question.

FYI: I've attempted to remove this functionality altogether, but it seemed to be occasionally used (https://crrev.com/2179543005/)
replace-menu.png
61.8 KB View Download
Cc: dgozman@chromium.org
Description doesn't mention that we should have a separate replace UI (two lines, all nice and aligned) and command menu items for search and replace.
Blocking: 477283
Components: Platform>DevTools>Authoring
Components: Platform>DevTools

Comment 6 by l...@chromium.org, Nov 17 2016

Cc: l...@chromium.org
 Issue 666237  has been merged into this issue.

Comment 7 by l...@chromium.org, Dec 5 2016

Labels: Hotlist-Polish
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf01fc727b00540e6bbd5959fa8e63df2477a4a9

commit cf01fc727b00540e6bbd5959fa8e63df2477a4a9
Author: Erik Luo <luoe@chromium.org>
Date: Mon Dec 04 20:42:56 2017

DevTools: revamp replace UI in searchable view

- Remove redundant Find/Previous buttons
- Replace "Replace" checkbox with cool icon
- 'Replace all' button is disabled when 'Replace' is
  also disabled

Screnshot: https://imgur.com/a/gp0SZ

Bug:  631163 
Change-Id: I98f2ca5b8e504d13d85057a80fa5bb9cf60c6118
Reviewed-on: https://chromium-review.googlesource.com/769991
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521438}
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/LayoutTests/http/tests/devtools/editor/text-editor-search-replace.js
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/Images/mediumIcons.png
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/Images/mediumIcons_2x.png
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/Images/src/mediumIcons.svg
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/sources_test_runner/SearchTestRunner.js
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/ui/searchableView.css
[modify] https://crrev.com/cf01fc727b00540e6bbd5959fa8e63df2477a4a9/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 9 by l...@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
One thing mentioned in the description that was not changed is the context menu.  Concerns were raised that the Sources context menu is already packed, and the visual noise from 2 extra options would not be worth the convenience.

Sign in to add a comment