New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631162 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 635948



Sign in to add a comment

DevTools: finalize v8_inspector API

Project Member Reported by dgozman@chromium.org, Jul 25 2016

Issue description

- Remove unnecessary methods.
- Simplify client API.
- Move things from session to debugger if makes sense.
 
Cc: kozyatinskiy@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/accf8418943eb701084809d6626c0db22882b9c4

commit accf8418943eb701084809d6626c0db22882b9c4
Author: dgozman <dgozman@chromium.org>
Date: Mon Jul 25 21:54:59 2016

[DevTools] Cleanup v8_inspector API part 2.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2179683002
Cr-Commit-Position: refs/heads/master@{#407602}

[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
[modify] https://crrev.com/accf8418943eb701084809d6626c0db22882b9c4/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8ef3397193287d76844ea0d16ed4fda5682466b

commit e8ef3397193287d76844ea0d16ed4fda5682466b
Author: dgozman <dgozman@chromium.org>
Date: Fri Jul 29 21:06:43 2016

[DevTools] Cleanup v8_inspector console API.

BUG= 631162 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2194683003
Cr-Commit-Position: refs/heads/master@{#408743}

[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/ConsoleTypes.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[delete] https://crrev.com/07d2ad752c2749ca67adb8051bf5591f57e06046/third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c

commit 02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c
Author: dgozman <dgozman@chromium.org>
Date: Sat Jul 30 03:25:29 2016

[DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2189263004
Cr-Commit-Position: refs/heads/master@{#408856}

[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/web/InspectorOverlay.h
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12e4094f1942c015925e406c7ce86c9cdafea645

commit 12e4094f1942c015925e406c7ce86c9cdafea645
Author: dgozman <dgozman@chromium.org>
Date: Sat Jul 30 05:25:09 2016

[DevTools] Pass error object when reporting exceptions.

We used to just extract string from the error, which didn't allow to inspect the error object itself. Now we pass the thrown object as a RemoteObject.

This also unifies exceptions with promise rejections in V8Debugger.

BUG= 631162 , 632405 

Review-Url: https://codereview.chromium.org/2170263002
Cr-Commit-Position: refs/heads/master@{#408863}

[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/chrome/test/data/extensions/api_test/uncaught_exception_logging/content_script.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/chrome/test/data/extensions/api_test/uncaught_exception_logging/extension_page.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-exception-source-url-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-log-eval-syntax-error-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error.html
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-message-from-inline-with-url-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-stack-overflow-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error-expected.txt
[add] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/exception-objects-expected.txt
[add] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/exception-objects.html
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/console/function-name-in-console-message-stack-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-in-console-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/testing/NullExecutionContext.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/12e4094f1942c015925e406c7ce86c9cdafea645/third_party/WebKit/Source/web/WebSharedWorkerImpl.h

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8376204e18b825999bfa6b7ac3f6555590289c8e

commit 8376204e18b825999bfa6b7ac3f6555590289c8e
Author: dgozman <dgozman@chromium.org>
Date: Mon Aug 01 20:29:05 2016

[DevTools] Move canExecuteScript to V8DebuggerClient.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2194063002
Cr-Commit-Position: refs/heads/master@{#409044}

[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/8376204e18b825999bfa6b7ac3f6555590289c8e/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17e5c2cbbc6afc9f0c325851a3b449396321082

commit c17e5c2cbbc6afc9f0c325851a3b449396321082
Author: dgozman <dgozman@chromium.org>
Date: Tue Aug 02 03:19:33 2016

[DevTools] Rename V8Debugger to V8Inspector.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2199943004
Cr-Commit-Position: refs/heads/master@{#409131}

[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h
[rename] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
[rename] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8Regex.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
[add] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp
[add] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
[delete] https://crrev.com/4986457108be0a622ba1e17d34ce2c2108ece830/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
[delete] https://crrev.com/4986457108be0a622ba1e17d34ce2c2108ece830/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.cpp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
[rename] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
[modify] https://crrev.com/c17e5c2cbbc6afc9f0c325851a3b449396321082/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dd254d2130c3a913b89cc37e51b56bdd68f094d

commit 3dd254d2130c3a913b89cc37e51b56bdd68f094d
Author: dgozman <dgozman@chromium.org>
Date: Wed Aug 03 02:08:18 2016

[DevTools] Cleanup mute exceptions, usecounter and deprecations in v8_inspector API.

We now mute exceptions in v8 inspector, and mute deprecations/usecounter in core.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2200273002
Cr-Commit-Position: refs/heads/master@{#409430}

[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.h
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
[modify] https://crrev.com/3dd254d2130c3a913b89cc37e51b56bdd68f094d/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a1ea86ea8018032b3b472b6699d36b5f67b54a

commit 35a1ea86ea8018032b3b472b6699d36b5f67b54a
Author: dgozman <dgozman@chromium.org>
Date: Wed Aug 03 19:12:55 2016

[DevTools] Remove V8InspectorSessionClient.

BUG= 631162 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2209603003
Cr-Commit-Position: refs/heads/master@{#409586}

[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/blink_platform.gypi
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
[delete] https://crrev.com/d9b7b61c7f82c16b8a27bb3e9fa054817554e63e/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/35a1ea86ea8018032b3b472b6699d36b5f67b54a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a8571b602f826acc09f0e6220c04c39fb12be69

commit 1a8571b602f826acc09f0e6220c04c39fb12be69
Author: dgozman <dgozman@chromium.org>
Date: Fri Aug 05 03:27:47 2016

[DevTools] Introduce unserializableValue in RemoteObject.

It carries primitive values which cannot be JSON-stringified.
Added support for it in more places on frontend side.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2214193002
Cr-Commit-Position: refs/heads/master@{#409981}

[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async.html
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
[modify] https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be29687013b17e0a1280414e4152f567091ab3bc

commit be29687013b17e0a1280414e4152f567091ab3bc
Author: dgozman <dgozman@chromium.org>
Date: Sat Aug 06 01:02:55 2016

[DevTools] Eliminate frameId and isContentScript from js protocol.

Replaced with auxData supplied by embedder.

BUG= 631162 

Review-Url: https://codereview.chromium.org/2215153002
Cr-Commit-Position: refs/heads/master@{#410239}

[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/chrome/test/chromedriver/chrome/frame_tracker.cc
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/chrome/test/chromedriver/chrome/frame_tracker_unittest.cc
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/chrome/test/chromedriver/chrome/navigation_tracker.cc
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/public/SimpleInspector.cpp
[modify] https://crrev.com/be29687013b17e0a1280414e4152f567091ab3bc/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h

Blocking: 635948

Sign in to add a comment