New issue
Advanced search Search tips

Issue 631128 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove ui_unscaled_resources.rc from chrome.exe and chrome_child.dll

Project Member Reported by brucedaw...@chromium.org, Jul 25 2016

Issue description

As mentioned in this comment:

https://bugs.chromium.org/p/chromium/issues/detail?id=624274#c22

chrome.exe and chrome_child.dll have an extra 50 KB of .rsrc data which can be removed once we have committed to the gn switch. This comment from ui\resources\BUILD.gn explains why can be done once GYP is gone.

# TODO(GYP_GONE) when GYP is gone, this line should be deleted, and the grit
# file updated to no longer list this as an output. We use resource bundles
# rather than .rc files, but the GYP build still expects this file to
# exist.
"ui_unscaled_resources.rc",

 
Components: Build
Owner: brucedaw...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 Deleted

Note the relevant change in crrev.com/2353463003 that removed the comment listed above

Sign in to add a comment