Ash makes use of CursorManager and CursorClient in a number of places. We'll need to provide an implementation of this for ash. See AshNativeCursorManager for specific ash parts.
Issue 618321 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eca38d4605fa46a7822ca5522db352415d97eed4 commit eca38d4605fa46a7822ca5522db352415d97eed4 Author: sky <sky@chromium.org> Date: Fri Mar 03 05:21:56 2017 chromeos: moves more ash tests to run on mash And pointers to bugs for those that aren't moved to common. BUG= 631103 , 633782 , 634994 , 648733 , 695887 , 696752 ,696754, 698016 , 698024 ,698032,698033, 698043 , 698049 ,698060,698085, 698092 ,698093, 698129 TEST=test only changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2732573002 Cr-Commit-Position: refs/heads/master@{#454514} [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/BUILD.gn [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/focus_cycler_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/overview/overview_button_tray_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/toast/toast_manager_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/tooltips/tooltip_controller_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_layout_manager_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_resizer_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/workspace/workspace_window_resizer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea37af717f1569dd93282e09b6fb49ff22b771f8 commit ea37af717f1569dd93282e09b6fb49ff22b771f8 Author: sky <sky@chromium.org> Date: Tue Mar 07 22:59:41 2017 Last sets of tests that can move to common_unittests This way they run in both mash_unittests and ash_unittests. Interesting things of note: . Had to remove DCHECKs for GetRootWindowForDisplayId() as some tests call with invalid. . Had to rename class in mus named WindowManagerTest as it conflicts with test with same name in ash. BUG= 622486 , 631103 , 637853 , 648733 ,695556, 696028 ,698091, 698129 , 698878 , 698887 ,698888,698892,698894, 698895 , 698914 ,699172,699175, 693114 TEST=test changes R=msw@chromium.org Review-Url: https://codereview.chromium.org/2739703003 Cr-Commit-Position: refs/heads/master@{#455272} [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/BUILD.gn [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/bridge/wm_shell_mus.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/mus/window_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/test/ash_test_base.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_manager_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_modality_controller_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_state_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/window_util_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_event_handler_unittest.cc [modify] https://crrev.com/ea37af717f1569dd93282e09b6fb49ff22b771f8/ash/wm/workspace/workspace_window_resizer_unittest.cc
Elliot is going to tackle cursor issues, so forwarding this one his way too.
Elliot, is the done?
This is really a duplicate, the last pieces of work was the IsMouseEventsEnabled() stuff I talked to you about yesterday.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1cf0d1499cbf6d584b09e9a0e926a6f0ee12756 commit c1cf0d1499cbf6d584b09e9a0e926a6f0ee12756 Author: Peng Huang <penghuang@chromium.org> Date: Sat Dec 09 01:10:01 2017 exo: use cursor manager in mus Bug: 631103 Change-Id: Ic765184940847ff42aa8a237da2c04220e37e09e Reviewed-on: https://chromium-review.googlesource.com/818115 Reviewed-by: Elliot Glaysher <erg@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#522946} [modify] https://crrev.com/c1cf0d1499cbf6d584b09e9a0e926a6f0ee12756/components/exo/wm_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/318d13c0410d8785315df7d3315bb8daedf63ef0 commit 318d13c0410d8785315df7d3315bb8daedf63ef0 Author: James Cook <jamescook@chromium.org> Date: Tue May 29 20:32:20 2018 chromeos: Fix exo cursor crash with mash Mash (out-of-process ash) doesn't have a CursorClient yet. We'll have one in a few weeks as we switch to ws2 (window server as a library built into ash), so just early exit on null. Bug: 847557 , 631103 Test: chrome --enable-features=Mash can login on device Change-Id: I3190785c218b455652151acad213fef94e85beec Reviewed-on: https://chromium-review.googlesource.com/1077074 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#562571} [modify] https://crrev.com/318d13c0410d8785315df7d3315bb8daedf63ef0/components/exo/pointer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7 commit 90b7fef81e13e1abcf8c129d9d6d57da5729b1e7 Author: James Cook <jamescook@chromium.org> Date: Wed Jul 25 23:18:49 2018 chromeos: Clean up MASH_DEPRECATED in AccessibilityHighlightController Now that we always have a CursorManager we don't need a virtual IsCursorVisible method and we can simplify the unit test. Bug: 631103 , 840391 Test: ash_unittests Change-Id: I1af8a8f0d88df2da03147deb779cf41a13763dde Reviewed-on: https://chromium-review.googlesource.com/1150806 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578119} [modify] https://crrev.com/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7/ash/accessibility/accessibility_highlight_controller.h [modify] https://crrev.com/90b7fef81e13e1abcf8c129d9d6d57da5729b1e7/ash/accessibility/accessibility_highlight_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2920dfe1c88deaf619a76c3189da7b331ca5957 commit f2920dfe1c88deaf619a76c3189da7b331ca5957 Author: James Cook <jamescook@chromium.org> Date: Tue Sep 04 19:55:01 2018 chromeos: Eliminate ash::Config::MASH_DEPRECATED We haven't run ash in this mode for months, since the switch to ws2 / window-service-as-a-library. * CursorManager exists in ws2, so always use it * Docked magnifier works in SingleProcessMash, and will need to be fixed separately for multi-process * Eliminate unused DragWindowResizerMash. Window dragging across displays works for both single-process and multi-process mash * Always use EventTargetingPolicy::TARGET_AND_DESCENDENTS in exo. Manually verified that clicks go to the right place in both single-process and multi-process mash. * Remove many unused includes I had to disable one ash_unittest for NonClientFrameController. TBR=lhchavez@chromium.org Bug: 631103 , 637853 , 646565 , 705592 , 756163 , 839521 Test: ash_unittests Change-Id: Iab64339029a33921274089ca4cb57a8f037f6f88 Reviewed-on: https://chromium-review.googlesource.com/1200483 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#588626} [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/BUILD.gn [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accessibility/accessibility_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/dbus/ash_dbus_services.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/display_prefs.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/mirror_window_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/mirror_window_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/frame/header_view.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/highlighter/highlighter_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/ime/ime_focus_handler_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/keyboard/virtual_keyboard_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/keyboard/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/laser/laser_pointer_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/login_test_base.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/metrics/login_metrics_recorder_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/public/cpp/BUILD.gn [delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/public/cpp/config.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/root_window_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/app_list_button_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_context_menu_model_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/flag_warning/flag_warning_tray.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/message_center/notification_tray_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/network/wifi_toggle_notification_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/night_light/night_light_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/night_light/tray_night_light_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/palette_tray.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/palette_tray_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/tools/screenshot_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/power/peripheral_battery_notifier_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/power/power_button_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/session/logout_button_tray_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/status_area_widget.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/tray/system_tray.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/tray_caps_lock.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/unified/unified_system_tray_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/test/ash_test_base.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/test/ash_test_base.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/tooltips/tooltip_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/touch/touch_observer_hud_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wayland/wayland_server_controller.cc [delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/wm/drag_window_resizer_mash.cc [delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/wm/drag_window_resizer_mash.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/non_client_frame_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/window_util.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/arc/rotation_lock/arc_rotation_lock_bridge.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/exo/shell_surface_base.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/exo/wayland/clients/test/wayland_client_test.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/testing/buildbot/filters/chromeos.single_process_mash.fyi.ash_unittests.filter
Comment 1 by sky@chromium.org
, Jul 25 2016