New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 631080 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

platform_FilePerms missing expectations for ARC containers

Project Member Reported by aaboagye@chromium.org, Jul 25 2016

Issue description

There have been a few canary failures recently in the platform_FilePerms test. It seems that some expectations regarding ARC containers are just missing from the test?

I've seen this on:
cyan
elm
lulu
oak
samus
veyron_minnie

Here's a snippet from the error log for samus release:

07/25 06:15:49.774 INFO |      base_sysinfo:0380| ChromeOS BOARD = samus_2.7GHz_8GB
07/25 06:15:49.774 DEBUG|        base_utils:0185| Running 'logger "autotest starting iteration /usr/local/autotest/results/default/platform_FilePerms/sysinfo/iteration.1 on samus_2.7GHz_8GB"'
07/25 06:15:49.781 ERROR|platform_FilePerms:0287| No expectations entry for "/opt/google/containers/arc-removable-media/mountpoints/container-root"
07/25 06:15:49.783 ERROR|platform_FilePerms:0287| No expectations entry for "/opt/google/containers/arc-obb-mounter/mountpoints/container-root"
07/25 06:15:49.786 ERROR|platform_FilePerms:0287| No expectations entry for "/opt/google/containers/arc-downloads-filesystem/mountpoints/container-root"
07/25 06:15:49.788 ERROR|platform_FilePerms:0287| No expectations entry for "/opt/google/containers/android-sdcard/mountpoints/container-root"

Here are the links to the failed jobs:
https://uberchromegw.corp.google.com/i/chromeos/builders/cyan-release/builds/243
https://uberchromegw.corp.google.com/i/chromeos/builders/elm-release/builds/242
https://uberchromegw.corp.google.com/i/chromeos/builders/lulu-release/builds/241
https://uberchromegw.corp.google.com/i/chromeos/builders/oak-release/builds/261
https://uberchromegw.corp.google.com/i/chromeos/builders/samus-release/builds/3411
https://uberchromegw.corp.google.com/i/chromeos/builders/veyron_minnie-release/builds/244

norvez@, I've assigned this to you as you were the last one to touch the test. :) Please reassign if you know someone who should be a better owner.
 
Cc: uekawa@chromium.org dgreid@chromium.org
CC-ing ARC++ fs document authors to help find the owner for this. 

Comment 2 by norvez@chromium.org, Jul 25 2016

Cc: yusukes@chromium.org
This CL https://chrome-internal-review.googlesource.com/#/c/269225/ looks like the likely culprit. Maybe I've missed it but it doesn't look like it unmounts the mount points listed in the error message.
Ah yes, https://chrome-internal-review.googlesource.com/#/c/269225/18/android-ureadahead.conf (which runs when the login screen is shown) now mounts fs images on these directories. Please assign it to me if needed. I'll update the test then.


Comment 4 by norvez@chromium.org, Jul 25 2016

Owner: yusukes@chromium.org
Status: Started (was: Assigned)

Comment 6 by norvez@chromium.org, Jul 25 2016

Cc: norvez@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2b786646f4e3382ac7476fc76e033528f902daa9

commit 2b786646f4e3382ac7476fc76e033528f902daa9
Author: Yusuke Sato <yusukes@google.com>
Date: Mon Jul 25 16:49:46 2016

platform_FilePerms: add more android container mount info

Previously, no images were mounted on these directries until
ARC is actually started. With CL:*269225 which was submitted
recently, squashfs images are mounted with noexec right after
Chrome OS boot without waiting for the start-arc-instance
Upstart signal.

BUG= chromium:631080 
BUG=b:25598471
TEST=platform_FilePerms on cyan-cheets

Change-Id: Ia92f2925b59839a1f3d66b50ed0ee4d4d59601b7
Reviewed-on: https://chromium-review.googlesource.com/362877
Commit-Ready: Yusuke Sato <yusukes@chromium.org>
Tested-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/2b786646f4e3382ac7476fc76e033528f902daa9/client/site_tests/platform_FilePerms/platform_FilePerms.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 10 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a20c1719f8ab6cc3f10a821a2ab1eb2804fee710

commit a20c1719f8ab6cc3f10a821a2ab1eb2804fee710
Author: Yusuke Sato <yusukes@google.com>
Date: Mon Jul 25 16:49:46 2016

platform_FilePerms: add more android container mount info

Previously, no images were mounted on these directries until
ARC is actually started. With CL:*269225 which was submitted
recently, squashfs images are mounted with noexec right after
Chrome OS boot without waiting for the start-arc-instance
Upstart signal.

BUG= chromium:631080 
BUG=b:25598471
TEST=platform_FilePerms on cyan-cheets

Change-Id: Ia92f2925b59839a1f3d66b50ed0ee4d4d59601b7
Reviewed-on: https://chromium-review.googlesource.com/362877
Commit-Ready: Yusuke Sato <yusukes@chromium.org>
Tested-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
(cherry picked from commit 2b786646f4e3382ac7476fc76e033528f902daa9)
Reviewed-on: https://chromium-review.googlesource.com/367840
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>

[modify] https://crrev.com/a20c1719f8ab6cc3f10a821a2ab1eb2804fee710/client/site_tests/platform_FilePerms/platform_FilePerms.py

Sign in to add a comment