New issue
Advanced search Search tips

Issue 631075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Make URL bar ESCAPE key processing same as Desktop Chrome

Project Member Reported by ajit...@samsung.com, Jul 25 2016

Issue description

Version: Chrome 51.0.2704.81
OS: Android 6.0.1
Device: Samsung Galaxy Note 4

What steps will reproduce the problem?
(1) Load www.google.co.in
(2) Tap on URL field (Observe IME launched)
(3) Type some characters on URL bar (Observe suggestion box appears)
(4) Press Escape Key from an external Keyboard (Observe, IME and suggestion window gets dismissed)

What is the expected output?
URL bar content should select fully, along with IME disappearance.

What do you see instead?
URL bar is loosing focus. No content selection happening in URL bar.

In Desktop chrome, upon receiving ESCAPE key, it closes the suggestion window and selects the URL bar content.
 

Comment 1 by ajit...@samsung.com, Jul 26 2016

@Ted - Could you please share your thoughts on this behavioural change request to match desktop chrome behavior ?
How are you getting an IME w/ a physical keyboard?

Having ESCAPE reset the url to the initial editing state seems reasonable though.

ToolbarManager already has a couple APIs that should do this:
revertLocationBarChanges followed by setUrlBarFocus(true).  That "should" do what desktop does.  Granted, there first needs to be checks that the omnibox does indeed currently have focus, but this seems ok to me.

Comment 3 by ajit...@samsung.com, Jul 26 2016

Even though physical KB is connected, when we "touch" on Url bar, IME comes. But in this scenario, IME invoking has less significance. What I wanted to point is about ESCAPE key behavior on Url bar.

Thank you for pointing about those APIs for making the required behavior. I will make a patch and proceed with the review.
Owner: ajit...@samsung.com
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a5629f03b20a4a94a9653b11284f29534ebf49d

commit 8a5629f03b20a4a94a9653b11284f29534ebf49d
Author: ajith.v <ajith.v@chromium.org>
Date: Sat Sep 03 10:09:42 2016

Making Android Url bar behavior to ESCAPE key same as in Desktop Chrome

In response to ESCAPE key desktop chrome is selecting all the contents
of Url bar. Making same behavior in Android Chrome as well.

BUG= 631075 

Review-Url: https://codereview.chromium.org/2211433002
Cr-Commit-Position: refs/heads/master@{#416452}

[modify] https://crrev.com/8a5629f03b20a4a94a9653b11284f29534ebf49d/chrome/android/java/src/org/chromium/chrome/browser/KeyboardShortcuts.java
[modify] https://crrev.com/8a5629f03b20a4a94a9653b11284f29534ebf49d/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Status: Fixed (was: Started)

Sign in to add a comment