New issue
Advanced search Search tips

Issue 631074 link

Starred by 2 users
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AudioBufferSource unknown constant of 4096

Project Member Reported by rtoy@chromium.org, Jul 25 2016 
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp?rcl=0&l=176 checks that some values are less than 4096.

Document what this 4096 means. It just suddenly appears in the code without comments so it's not clear why this limit exists or if it is even correct.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2fc3f0348fa4b75175bb1892895dbbe621df417

commit d2fc3f0348fa4b75175bb1892895dbbe621df417
Author: rtoy <rtoy@chromium.org>
Date: Thu Aug 11 23:29:45 2016

Replace 4096 with rendering quantum size

The code for AudioBufferSourceHandler::renderFromBuffer had a magic,
undocumented literal value of 4096.  Replace this with
AudioUtilities::kRenderQuantumFrames, because it's clear that the
|numberOfFrames| can't be larger than the quantum size (from the call
tree).  The destination bus should also have a maximum length of this
size.

BUG= 631074 
TEST=none

Review-Url: https://codereview.chromium.org/2223293002
Cr-Commit-Position: refs/heads/master@{#411437}

[modify] https://crrev.com/d2fc3f0348fa4b75175bb1892895dbbe621df417/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Comment 2 by rtoy@chromium.org, Aug 12 2016

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment