New issue
Advanced search Search tips

Issue 631047 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 650245

Blocking:
issue 401103
issue 627560



Sign in to add a comment

Rework Swarming UI to use Polymer, OAuth2 and the apis

Project Member Reported by kjlubick@google.com, Jul 25 2016

Issue description

This is a tracking bug for the effort to rewrite the Swarming UI

https://groups.google.com/a/google.com/forum/#!topic/luci-eng/KoyrTbgNZ-I

 

Comment 1 by kjlubick@google.com, Jul 25 2016

Cc: vadimsh@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81

commit 375d93fc4e83a64bf6b37a30a9d6fc35c5726e81
Author: kjlubick <kjlubick@google.com>
Date: Mon Jul 25 18:03:01 2016

Add stub pages and oauth-blessed request to /newui

I borrowed auth-signin.html from luci-go and modified it to work better with iron-ajax.
https://github.com/luci/luci-go/blob/master/web/inc/auth/auth-signin.html

This is the first step of the new ui (oauth 2).  The next step will be incorporating the (mostly written) bot-list to also use it.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2174903002

[modify] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/app.yaml
[modify] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/Makefile
[modify] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/README.md
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/botlist.html
[modify] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/bower.json
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/build/botlist-build.html
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/build/index-build.html
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/imp/common/auth-signin.html
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/imp/index/swarming-index.html
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/index.html
[add] https://crrev.com/375d93fc4e83a64bf6b37a30a9d6fc35c5726e81/appengine/swarming/elements/package.json

Project Member

Comment 3 by sheriffbot@chromium.org, Jul 26 2016

Labels: Hotlist-Google
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/bc79132b9686e2553be97baef8a74bba547d5354

commit bc79132b9686e2553be97baef8a74bba547d5354
Author: kjlubick <kjlubick@google.com>
Date: Tue Jul 26 19:32:57 2016

Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

This also moves the elements/stats to elements/imp/stats, which was overlooked in the last CL.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2177353002

[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/PRESUBMIT.py
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/app.yaml
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/.bowerrc
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/.gitignore
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/Makefile
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/README.md
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/botlist-index.html
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/bower.json
[delete] https://crrev.com/a13377743bbee160bdb8d3953ffe0e7343728346/appengine/swarming/elements/build/botlist-build.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/build/elements.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/build/js/webcomponents-lite.min.js
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/elements.html
[delete] https://crrev.com/a13377743bbee160bdb8d3953ffe0e7343728346/appengine/swarming/elements/imp/index/swarming-index.html
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/index.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/common/auth-signin.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/common/swarming-app.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/index/swarming-index-demo.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/index/swarming-index.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/load-charts-api.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/overview-demo.json
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/partial-line-chart.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/stats-overview-demo.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/stats-overview.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/bc79132b9686e2553be97baef8a74bba547d5354

commit bc79132b9686e2553be97baef8a74bba547d5354
Author: kjlubick <kjlubick@google.com>
Date: Tue Jul 26 19:32:57 2016

Add top level app element

This adds in a common toolbar, a common auth path and a busy icon
http://screen/Yf8JFft5tSy

There are several misc cleanups to make the toolbar look nice.

This also moves the elements/stats to elements/imp/stats, which was overlooked in the last CL.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2177353002

[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/PRESUBMIT.py
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/app.yaml
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/.bowerrc
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/.gitignore
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/Makefile
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/README.md
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/botlist-index.html
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/bower.json
[delete] https://crrev.com/a13377743bbee160bdb8d3953ffe0e7343728346/appengine/swarming/elements/build/botlist-build.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/build/elements.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/build/js/webcomponents-lite.min.js
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/elements.html
[delete] https://crrev.com/a13377743bbee160bdb8d3953ffe0e7343728346/appengine/swarming/elements/imp/index/swarming-index.html
[modify] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/index.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/common/auth-signin.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/common/swarming-app.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/index/swarming-index-demo.html
[add] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/index/swarming-index.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/load-charts-api.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/overview-demo.json
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/partial-line-chart.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/stats-overview-demo.html
[rename] https://crrev.com/bc79132b9686e2553be97baef8a74bba547d5354/appengine/swarming/elements/res/imp/stats/stats-overview.html

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/7c258a419a17da74f64ce5bf27b1f67c3ea107e5

commit 7c258a419a17da74f64ce5bf27b1f67c3ea107e5
Author: kjlubick <kjlubick@google.com>
Date: Mon Aug 01 14:07:31 2016

Add new botlist for swarming

This botlist is a dynamic table.  The user can choose which columns they want to see and what to sort by, in addition to making it easier to discover what can be sorted by.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2182693002

[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/.gitignore
[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/Makefile
[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/botlist-index.html
[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/build/elements.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/build/js/common.js
[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/elements.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/botlist/bot-list.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/common/sort-toggle.html
[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/imp/index/swarming-index.html
[add] https://crrev.com/7c258a419a17da74f64ce5bf27b1f67c3ea107e5/appengine/swarming/elements/res/js/common.js

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/e448e8ec16dfdb9c7e7639791a89b492707e6b44

commit e448e8ec16dfdb9c7e7639791a89b492707e6b44
Author: kjlubick <kjlubick@google.com>
Date: Wed Aug 03 14:35:14 2016

Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list
looks more mangled than it actually is.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2204483002

[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/Makefile
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/build/js/common.js
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/package.json
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[add] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-summary.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/common/auth-signin.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/common/sort-toggle.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/common/swarming-app.html

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/e448e8ec16dfdb9c7e7639791a89b492707e6b44

commit e448e8ec16dfdb9c7e7639791a89b492707e6b44
Author: kjlubick <kjlubick@google.com>
Date: Wed Aug 03 14:35:14 2016

Add UI to new botlist to show summary

This also makes it a bit more obvious that one needs to log in.

The diff got a bit confused on what did and did not change, so bot-list
looks more mangled than it actually is.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2204483002

[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/Makefile
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/build/js/common.js
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/package.json
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[add] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list-summary.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/common/auth-signin.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/common/sort-toggle.html
[modify] https://crrev.com/e448e8ec16dfdb9c7e7639791a89b492707e6b44/appengine/swarming/elements/res/imp/common/swarming-app.html

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/bf775c6fcaaa324474208dfcaaac75b2a226789f

commit bf775c6fcaaa324474208dfcaaac75b2a226789f
Author: kjlubick <kjlubick@google.com>
Date: Tue Aug 09 18:48:20 2016

Update new botlist to use dimensions endpoint

- Use new dimensions endpoint to get full fleet dimensions.  Before, you would only be able to filter based on the things already in the list, which is a problem if the thing you want doesn't show up in the first [BOT_LIST_LIMIT] commits.
- Dimensions are passed from the client-side filter to the server-side filter.  The items we have will be filtered out while waiting for the server to give us more. The spinner will be active while any of the ajax requests are active.
- The "devices" dimension was split (server side) into device_type, device_os, and android_devices.  The last one is the number of connected, ready devices.
- Added new method _attribute, which will look for an attribute in the "dimensions" and fallback to "state".  This allows a more consistent "API" than hodge-podge _devices/_state all over the place.
- Quarantined bot message actually show up (pulled from state).
- Dead bot message augmented with human friendly "last seen" message.
- Disk space column shown up, which is pulled exclusively from state, not a dimension.  It is displayed in a human friendly manner.
- Remove "auto download" of demo json from Makefile
- Sinon was updated to bring in a bug fix.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2211163003

[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/Makefile
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/build/js/common.js
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/package.json
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/index/swarming-index-demo.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/js/common.js

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/bf775c6fcaaa324474208dfcaaac75b2a226789f

commit bf775c6fcaaa324474208dfcaaac75b2a226789f
Author: kjlubick <kjlubick@google.com>
Date: Tue Aug 09 18:48:20 2016

Update new botlist to use dimensions endpoint

- Use new dimensions endpoint to get full fleet dimensions.  Before, you would only be able to filter based on the things already in the list, which is a problem if the thing you want doesn't show up in the first [BOT_LIST_LIMIT] commits.
- Dimensions are passed from the client-side filter to the server-side filter.  The items we have will be filtered out while waiting for the server to give us more. The spinner will be active while any of the ajax requests are active.
- The "devices" dimension was split (server side) into device_type, device_os, and android_devices.  The last one is the number of connected, ready devices.
- Added new method _attribute, which will look for an attribute in the "dimensions" and fallback to "state".  This allows a more consistent "API" than hodge-podge _devices/_state all over the place.
- Quarantined bot message actually show up (pulled from state).
- Dead bot message augmented with human friendly "last seen" message.
- Disk space column shown up, which is pulled exclusively from state, not a dimension.  It is displayed in a human friendly manner.
- Remove "auto download" of demo json from Makefile
- Sinon was updated to bring in a bug fix.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2211163003

[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/Makefile
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/build/js/common.js
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/package.json
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/imp/index/swarming-index-demo.html
[modify] https://crrev.com/bf775c6fcaaa324474208dfcaaac75b2a226789f/appengine/swarming/elements/res/js/common.js

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/e02bb087183bbf2323a0229eda4266b51d5d74d6

commit e02bb087183bbf2323a0229eda4266b51d5d74d6
Author: kjlubick <kjlubick@google.com>
Date: Thu Aug 11 20:16:53 2016

Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned
into a template with one param - client_id

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2242543002

[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/app.yaml
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/elements/res/imp/index/swarming-index.html
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/handlers_frontend.py
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/proto/config.proto
[modify] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/proto/config_pb2.py
[rename] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/templates/public_botlist_index.html
[rename] https://crrev.com/e02bb087183bbf2323a0229eda4266b51d5d74d6/appengine/swarming/templates/public_swarming_index.html

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/f722bb51a5c0bae9689d78a7549c15d2596a1015

commit f722bb51a5c0bae9689d78a7549c15d2596a1015
Author: Kevin Lubick <kjlubick@google.com>
Date: Thu Aug 11 20:24:30 2016

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99

commit 68038ad2f7c03ab543a7d8bf33a7d5a02a676c99
Author: kjlubick <kjlubick@google.com>
Date: Fri Aug 12 18:18:55 2016

Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many Aliases were added.

The Limit box will correct itself if you type outside the range of 1-1000

Additionally, a new npm package "skia-common-js" was added, to avoid
duplication of code.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2227803002

[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/Makefile
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/build/elements.html
[delete] https://crrev.com/6a5120210cd8214bcbaec031333e3148520d57df/appengine/swarming/elements/build/js/common.js
[add] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/build/js/js.js
[delete] https://crrev.com/6a5120210cd8214bcbaec031333e3148520d57df/appengine/swarming/elements/build/js/webcomponents-lite.min.js
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/package.json
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/botlist/bot-list-summary.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/botlist/bot-list.html
[add] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/imp/common/url-param.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/elements/res/js/common.js
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/handlers_endpoints.py
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/templates/public_botlist_index.html
[modify] https://crrev.com/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99/appengine/swarming/templates/public_swarming_index.html

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/c4697f323182aec1d2f817556ca2797d89283269

commit c4697f323182aec1d2f817556ca2797d89283269
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Aug 16 13:42:49 2016

Project Member

Comment 22 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/0be43acb22a4041ff898aad8d77c7ebcf04c358a

commit 0be43acb22a4041ff898aad8d77c7ebcf04c358a
Author: kjlubick <kjlubick@google.com>
Date: Fri Aug 19 17:49:36 2016

Make TaskList use Dynamic List

Stub out other components like filters

This is all very similar to Bot List, except there are no devices "sub table".

BUG= 631047 

Review-Url: https://codereview.chromium.org/2249143002

[modify] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/Makefile
[modify] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/elements.html
[modify] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/res/imp/common/swarming-app.html
[add] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/res/imp/tasklist/task-filters.html
[add] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[add] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/res/imp/tasklist/task-list-demo.html
[add] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/elements/res/imp/tasklist/task-list.html
[add] https://crrev.com/0be43acb22a4041ff898aad8d77c7ebcf04c358a/appengine/swarming/templates/public_tasklist_index.html

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/6c730d430ec1bb8e0a147adea5a3fd1b0194461b

commit 6c730d430ec1bb8e0a147adea5a3fd1b0194461b
Author: kjlubick <kjlubick@google.com>
Date: Wed Aug 24 15:10:40 2016

Extract shared filters and aliasing code

There are no visual differences*

In a future CL, tasklist will begin using these new behaviors.

alias.js includes shared behavior for applying and
unapplying Android and GPU aliases.

query-column-filter-behavior includes shared behavior for filtering the
columns and data used in bot-filters (and soon in task-filters).

*I fixed quarantine messages in some cases and made app.yaml not
upload bower_components and node_componenets - which keeps the
size of the GAE app 12MB instead of 60+MB.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2269643002

[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/app.yaml
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/Makefile
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/build/js/js.js
[add] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/DESIGN.md
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[add] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/bot-list-shared-behavior.html
[delete] https://crrev.com/e838432ac54ec2b81a0909c6bfef1ad470f13542/appengine/swarming/elements/res/imp/botlist/bot-list-shared.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/bot-list-summary.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/botlist/bot-list.html
[add] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/common/common-behavior.html
[rename] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/common/dynamic-table-behavior.html
[add] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/common/query-column-filter-behavior.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/tasklist/task-list-demo.html
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/imp/tasklist/task-list.html
[add] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/js/alias.js
[modify] https://crrev.com/6c730d430ec1bb8e0a147adea5a3fd1b0194461b/appengine/swarming/elements/res/js/common.js

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/deb944d9ff75f7c9c6d66072601cdb2c2dbed971

commit deb944d9ff75f7c9c6d66072601cdb2c2dbed971
Author: kjlubick <kjlubick@google.com>
Date: Thu Aug 25 18:00:43 2016

Add filter to task-list

The two big things in this CL are adding in the filtering mechanism (very similar to filtering bot-list) and migrating task-list-data to use sk.request.

In the task list, you can dynamically choose your columns and quickly see the state of tasks, and cancel pending tasks.

Assembling the tags (in task-list-data) is a bit trickier than the dimensions was for the botlist because there are many more tasks than bots, so the cron job can only run once per hour for the last hour's worth of data.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2266133002

[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/Makefile
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/common/common-behavior.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/common/dynamic-table-behavior.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/tasklist/task-list-demo.html
[modify] https://crrev.com/deb944d9ff75f7c9c6d66072601cdb2c2dbed971/appengine/swarming/elements/res/imp/tasklist/task-list.html

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 26 2016

Project Member

Comment 31 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/5d944ff359ed0139db738fd13c07a006a10a135b

commit 5d944ff359ed0139db738fd13c07a006a10a135b
Author: kjlubick <kjlubick@google.com>
Date: Fri Sep 02 14:20:42 2016

Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually.
Future CLs will implement actual functionality.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2283133002

[modify] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/Makefile
[modify] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/elements.html
[modify] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/res/imp/botlist/bot-list.html
[add] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[add] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[add] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/elements/res/imp/botpage/bot-page.html
[add] https://crrev.com/5d944ff359ed0139db738fd13c07a006a10a135b/appengine/swarming/templates/public_bot_index.html

Project Member

Comment 32 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/0f81b3641969489e5475701bc488f85d08cf29b3

commit 0f81b3641969489e5475701bc488f85d08cf29b3
Author: kjlubick <kjlubick@google.com>
Date: Fri Sep 02 17:08:49 2016

Introduce new bot-page UI

The bot page is relatively simple (compared to the dynamic tables and
query-able filters used by bot-list and task-list)

It shows the bot's dimensions and other pertinent data.  There are buttons
for doing some bot maintenance (e.g. deleting dead bots), but those don't
quite work yet - next CL should add it.

In the demo code, you can view test-bot-001, 002 and 003 to see a normal
bot, a quarantined bot and a dead bot respectively.

The state is currently just a pretty printed version of the state object
that comes with the bot.  Perhaps in the future, important data from there
(like devices) can be pulled out and shown more easily.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2291323002

[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[add] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/botpage/bot-page-shared-behavior.html
[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/common/common-behavior.html
[modify] https://crrev.com/0f81b3641969489e5475701bc488f85d08cf29b3/appengine/swarming/elements/res/imp/common/swarming-app.html

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/d145f64ccb1486ec38d4665b87284fe38b62bcfd

commit d145f64ccb1486ec38d4665b87284fe38b62bcfd
Author: kjlubick <kjlubick@google.com>
Date: Wed Sep 07 12:40:19 2016

Refactor post requests, implement bot cancel/terminate

There is a prompt before the delete/cancel goes through.

Tasks that fail are highlighted red, tasks with BOT_DIED are grey, and the refresh button also works.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2302973002

[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/build/js/js.js
[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/package.json
[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/res/imp/botpage/bot-page.html
[add] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/res/imp/common/error-toast.html
[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/d145f64ccb1486ec38d4665b87284fe38b62bcfd/appengine/swarming/elements/res/js/common.js

Blocking: 401103
Project Member

Comment 38 by bugdroid1@chromium.org, Sep 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/84f27f987cc82440fd47edb33e379f6505f6938a

commit 84f27f987cc82440fd47edb33e379f6505f6938a
Author: kjlubick <kjlubick@google.com>
Date: Mon Sep 19 18:26:22 2016

Refactor prior to adding task-page

There should be no real visual changes here. This is minor bug fixes and
refactoring to aid in the addition of task-page.

This fixes the name of "limit"->"_limit" in the two filters.  The latter
was declared but the former was used.

_taskLink and _botLink are consolidated into the common behavior to avoid
duplication (and fixing the links in multiple places)

Many styles that will be used by task-page are pulled out of bot-page and into
single-page-style.

_timeDiff* are pulled into common behavior (they will be used in task-page)

_humanDuration is created in common behavior (to consolidate and allow for use
in the templates of task-page)

buttons now look more clickable (pointer cursor)

task-list sorts times better when they don't have one

task-list uses human.localeTime like the rest of the app

The pages titles have been changed to be more useful when more tabs are open.
Instead of "Swarming Bot List", it is now "Bot List - Swarming", which means
if you have 20 tabs open, you see "Bot Li" instead of "Swarmin", which makes
it easier to find the right tab.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2338383002

[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/build/js/js.js
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/botpage/bot-page-shared-behavior.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/common/common-behavior.html
[add] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/common/single-page-style.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/elements/res/js/common.js
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/templates/public_bot_index.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/templates/public_botlist_index.html
[modify] https://crrev.com/84f27f987cc82440fd47edb33e379f6505f6938a/appengine/swarming/templates/public_tasklist_index.html

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/cd808e1138f16101899a9f6409eda3a647a41381

commit cd808e1138f16101899a9f6409eda3a647a41381
Author: kjlubick <kjlubick@google.com>
Date: Tue Sep 20 13:39:50 2016

Let auth credentials autorefresh and fix new tab

The auth signin doesn't happen if the page
is opened in a new tab.  This is likely because the user
is already logged in, so we just reuse the credentials.

Additionally, this prevents the credentials from expiring.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2344883002

[modify] https://crrev.com/cd808e1138f16101899a9f6409eda3a647a41381/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/cd808e1138f16101899a9f6409eda3a647a41381/appengine/swarming/elements/res/imp/common/auth-signin.html

Project Member

Comment 42 by bugdroid1@chromium.org, Sep 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7

commit 5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7
Author: kjlubick <kjlubick@google.com>
Date: Tue Sep 20 20:27:37 2016

Add task-page

None of the buttons work yet, will add in future CL

BUG= 631047 

Review-Url: https://codereview.chromium.org/2337363004

[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/common/common-behavior.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/common/single-page-style.html
[add] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/common/task-behavior.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/taskpage/task-page-data.html
[modify] https://crrev.com/5e7156b6ab1254530c4e1fc0b3a470697fa9e4f7/appengine/swarming/elements/res/imp/taskpage/task-page.html

Project Member

Comment 43 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/aac687d9ab71b04582a39e8ec3230c4579ec93e2

commit aac687d9ab71b04582a39e8ec3230c4579ec93e2
Author: kjlubick <kjlubick@google.com>
Date: Wed Sep 21 18:10:03 2016

Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.

The Requested Dimensions now has a link to the botlist with
all those dimensions, so one can see which bots could pick up a
given task.

The times on task-page now have their full timestamps as mouseovers.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2350853004

[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/Makefile
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/build/js/js.js
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/common/auth-signin.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/common/common-behavior.html
[add] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/common/interval-timer.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/taskpage/task-page-data.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/taskpage/task-page-demo.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/imp/taskpage/task-page.html
[modify] https://crrev.com/aac687d9ab71b04582a39e8ec3230c4579ec93e2/appengine/swarming/elements/res/js/common.js

Project Member

Comment 44 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/6fa3df9d25c864979160c3bed632fdc8f8d49621

commit 6fa3df9d25c864979160c3bed632fdc8f8d49621
Author: kjlubick <kjlubick@google.com>
Date: Wed Sep 21 20:09:23 2016

Medium sized improvements to bot-list and task-list

Adds a bunch of columns to bot-list (battery* and *temperature)

Makes lists a bit more responsive by lowering the default query
amount

Shorten the query params to be single letters (e.g. filters -> f)

Some Polymer elements were updated because I purged and regenerated bower_components (e.g. Polymer 1.6.0 -> 1.6.1)

BUG= 631047 

Review-Url: https://codereview.chromium.org/2359993002

[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/build/js/js.js
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/botlist/bot-list-shared-behavior.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/botlist/bot-list-summary.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/common/common-behavior.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/common/query-column-filter-behavior.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/6fa3df9d25c864979160c3bed632fdc8f8d49621/appengine/swarming/elements/res/js/alias.js

Project Member

Comment 49 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23

commit 8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23
Author: kjlubick <kjlubick@google.com>
Date: Thu Sep 22 19:06:11 2016

Use non-proxied links

This avoids random 404 errors and seems, dare I be too
optimistic, a bit faster.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2366663003

[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/taskpage/task-page-data.html
[modify] https://crrev.com/8aea7e03094ae7ed0f75f3dfcc93f8548cfd9a23/appengine/swarming/elements/res/imp/taskpage/task-page.html

Project Member

Comment 50 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/6de7f7cac69339a8a8c56a1f52cf04bf388ee448

commit 6de7f7cac69339a8a8c56a1f52cf04bf388ee448
Author: kjlubick <kjlubick@google.com>
Date: Fri Sep 23 11:38:19 2016

Use an empty list for tags that there are too many

This way the client-side UI knows the columns it should display, even
if there are too many values to keep track of.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2360383002

[modify] https://crrev.com/6de7f7cac69339a8a8c56a1f52cf04bf388ee448/appengine/swarming/handlers_backend.py

Project Member

Comment 51 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/6de7f7cac69339a8a8c56a1f52cf04bf388ee448

commit 6de7f7cac69339a8a8c56a1f52cf04bf388ee448
Author: kjlubick <kjlubick@google.com>
Date: Fri Sep 23 11:38:19 2016

Use an empty list for tags that there are too many

This way the client-side UI knows the columns it should display, even
if there are too many values to keep track of.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2360383002

[modify] https://crrev.com/6de7f7cac69339a8a8c56a1f52cf04bf388ee448/appengine/swarming/handlers_backend.py

Blockedon: 650245
Project Member

Comment 55 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/74b4d7e30bb7e046653b76cee5d97850a39c8928

commit 74b4d7e30bb7e046653b76cee5d97850a39c8928
Author: kjlubick <kjlubick@google.com>
Date: Tue Sep 27 16:45:52 2016

Update Stats element to use new directory layout

Also fix the overview element to show data in browser local time
instead of UTC.

Due to the fact that the stats api doesn't use OAuth, I'm going
to hold off on any more stats work until the rest of the new UI
is out the door.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2367413003

[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/Makefile
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/res/imp/index/swarming-index-demo.html
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/res/imp/index/swarming-index.html
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/res/imp/stats/load-charts-api.html
[delete] https://crrev.com/3b1ba7b778122f5958342d6fce222eca85a6e958/appengine/swarming/elements/res/imp/stats/overview-demo.json
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/res/imp/stats/partial-line-chart.html
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/res/imp/stats/stats-overview-demo.html
[modify] https://crrev.com/74b4d7e30bb7e046653b76cee5d97850a39c8928/appengine/swarming/elements/res/imp/stats/stats-overview.html

Project Member

Comment 56 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/ccab439ed6c9fd19044e6b00945219c991d935e8

commit ccab439ed6c9fd19044e6b00945219c991d935e8
Author: kjlubick <kjlubick@google.com>
Date: Wed Sep 28 19:39:15 2016

Add pageable data widget

This allows the user to request more data if they need it.
This has been integrated into bot-page and can be added
to bot-list and task-list as well.

So far this seems to speed up the bot-page a bit because
the initial query for data is smaller.  It seems that the
previous logic of paging for the last 200 tasks was the most
expensive part of the whole page.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2372323002

[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/common-behavior.html
[add] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/pageable-data-demo.html
[add] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/pageable-data.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/swarming-app.html

Project Member

Comment 57 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/ccab439ed6c9fd19044e6b00945219c991d935e8

commit ccab439ed6c9fd19044e6b00945219c991d935e8
Author: kjlubick <kjlubick@google.com>
Date: Wed Sep 28 19:39:15 2016

Add pageable data widget

This allows the user to request more data if they need it.
This has been integrated into bot-page and can be added
to bot-list and task-list as well.

So far this seems to speed up the bot-page a bit because
the initial query for data is smaller.  It seems that the
previous logic of paging for the last 200 tasks was the most
expensive part of the whole page.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2372323002

[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/common-behavior.html
[add] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/pageable-data-demo.html
[add] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/pageable-data.html
[modify] https://crrev.com/ccab439ed6c9fd19044e6b00945219c991d935e8/appengine/swarming/elements/res/imp/common/swarming-app.html

Project Member

Comment 59 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/5808042b94ab28b513bc3e1e7cab0a1c7b74881f

commit 5808042b94ab28b513bc3e1e7cab0a1c7b74881f
Author: kjlubick <kjlubick@google.com>
Date: Mon Oct 03 20:19:35 2016

Add bot-page summary with utilization stats

You can ignore most of the bot-page changes - they are
mostly whitespace changes.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2381853003

[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/.gitignore
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/Makefile
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/build/js/js.js
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/package.json
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[add] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page-summary.html
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page.html

Project Member

Comment 60 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/5808042b94ab28b513bc3e1e7cab0a1c7b74881f

commit 5808042b94ab28b513bc3e1e7cab0a1c7b74881f
Author: kjlubick <kjlubick@google.com>
Date: Mon Oct 03 20:19:35 2016

Add bot-page summary with utilization stats

You can ignore most of the bot-page changes - they are
mostly whitespace changes.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2381853003

[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/.gitignore
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/Makefile
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/build/js/js.js
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/package.json
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[add] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page-summary.html
[modify] https://crrev.com/5808042b94ab28b513bc3e1e7cab0a1c7b74881f/appengine/swarming/elements/res/imp/botpage/bot-page.html

Project Member

Comment 62 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/d40718cea5e0337cb4bc4fd242e2690accd56ab7

commit d40718cea5e0337cb4bc4fd242e2690accd56ab7
Author: kjlubick <kjlubick@google.com>
Date: Tue Oct 04 13:59:47 2016

Several small changes to new UI pages

Add noopener to all target="_blank" locations.

Add link to skia source for sk_revision

Add cloud console link to bot-page and bot-list

Make task-page reload everything and only if not pending/running

BUG= 652266 
BUG= 631047 

Review-Url: https://codereview.chromium.org/2391583002

[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/botlist/bot-list-shared-behavior.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/common/common-behavior.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/d40718cea5e0337cb4bc4fd242e2690accd56ab7/appengine/swarming/elements/res/imp/taskpage/task-page.html

Comment 63 by s...@google.com, Oct 11 2016

Blocking: 627560
Project Member

Comment 64 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/045063d086d171bf39d24fe258a7c04a570e0e6f

commit 045063d086d171bf39d24fe258a7c04a570e0e6f
Author: kjlubick <kjlubick@google.com>
Date: Thu Oct 13 12:50:20 2016

Add links to MP and resolve minor fixes

A big change here is how external linking happens.
A prefix gets passed in through the server details api
and is applied. milo_prefix and sk_revision_prefix
have been added along with the one for Machine Provider.

Machine provider stuff shows up on bot-list as well as bot-page.

Fixed layout on bot-page with long ids

Fixed disk_space being off by 6 orders of magnitude

Fixed case where bot state could be "null"

BUG= 631047 

Review-Url: https://codereview.chromium.org/2404883002

[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/doc/Magic-Values.md
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/Makefile
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botlist/bot-list-data.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botlist/bot-list-demo.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botlist/bot-list-shared-behavior.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botlist/bot-list.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botpage/bot-page-data.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botpage/bot-page-demo.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/botpage/bot-page.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/common/single-page-style.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/common/swarming-app.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/index/swarming-index.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/tasklist/task-list-data.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/tasklist/task-list.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/taskpage/task-page-demo.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/res/imp/taskpage/task-page.html
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/handlers_endpoints.py
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/handlers_endpoints_test.py
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/proto/bots_pb2.py
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/proto/config.proto
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/proto/config_pb2.py
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/swarming_rpcs.py
[modify] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/templates/public_task_index.html

Project Member

Comment 65 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/d48d94687f6961e6b69379987af5a480153b5071

commit d48d94687f6961e6b69379987af5a480153b5071
Author: kjlubick <kjlubick@google.com>
Date: Thu Oct 13 13:09:53 2016

Move elements/ to ui/

Update the app.yaml to point to the correct files.

Also updated any Polymer/Bower/NPM dependencies for the build.

BUG= 631047 

Review-Url: https://codereview.chromium.org/2408743002

[modify] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/app.yaml
[delete] https://crrev.com/045063d086d171bf39d24fe258a7c04a570e0e6f/appengine/swarming/elements/build/elements.html
[modify] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/templates/root.html
[modify] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/templates/stats.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/.bowerrc
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/.gitignore
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/Makefile
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/README.md
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/bower.json
[add] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/build/elements.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/build/js/js.js
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/elements.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/package.json
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/.gitignore
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/README.md
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/bower.json
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-app-build.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-app-build.js
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-app.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-chart-base.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-dimension-filter.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-overview-build.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-overview-build.js
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-overview.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-request-chart.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-table-chart.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-time-chart.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/polymer05/stats-work-chart.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/DESIGN.md
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/bot-list-data.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/bot-list-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/bot-list-summary.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botlist/bot-list.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botpage/bot-page-data.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botpage/bot-page-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botpage/bot-page-shared-behavior.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botpage/bot-page-summary.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/botpage/bot-page.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/auth-signin.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/common-behavior.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/error-toast.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/interval-timer.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/pageable-data-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/pageable-data.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/single-page-style.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/sort-toggle.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/swarming-app.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/task-behavior.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/common/url-param.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/index/swarming-index-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/index/swarming-index.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/stats/load-charts-api.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/stats/partial-line-chart.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/stats/stats-overview-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/stats/stats-overview.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/tasklist/task-list-data.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/tasklist/task-list-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/tasklist/task-list.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/taskpage/task-page-data.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/taskpage/task-page-demo.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/imp/taskpage/task-page.html
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/js/alias.js
[rename] https://crrev.com/d48d94687f6961e6b69379987af5a480153b5071/appengine/swarming/ui/res/js/common.js

Status: Fixed (was: Started)
This is now deployed to prod.  Open new bugs with issues.

::confetti::
Project Member

Comment 69 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config.git/+/db421e47f755bc54cebddbf5a4c65f453cfe1bdd

commit db421e47f755bc54cebddbf5a4c65f453cfe1bdd
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Oct 14 11:47:51 2016

Sign in to add a comment