webkit_unit_tests AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount is flaky |
|||||
Issue description"webkit_unit_tests (with patch)" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKQsSBUZsYWtlIh53ZWJraXRfdW5pdF90ZXN0cyAod2l0aCBwYXRjaCkM. This flaky test/step was previously tracked in issue 627927 .
,
Jul 25 2016
CC the author of the test, who I'm not sure is still active on chrome. Assigning to the reviewer of the test, who I think still works on this kind of area.
,
Jul 25 2016
I'll take a look at this one.
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bc11b2ac870eb60d74f0f56337703ff6d4f1c80 commit 0bc11b2ac870eb60d74f0f56337703ff6d4f1c80 Author: suzyh <suzyh@chromium.org> Date: Tue Jul 26 01:27:11 2016 Remove death test in CompositorAnimationsTest AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount contains an EXPECT_DEATH test which checks that CompositorAnimations::convertTimingForCompositor hits an assertion failure if passed a Timing object with a value of -1 for iterationCount. This test is probably included because -1 is a valid value for the equivalent field in the output CompositorTiming object. However, EXPECT_DEATH is flaky and dangerous in a multi-threaded context. Since we're not gaining much by having this test, this patch removes it. BUG= 631021 Review-Url: https://codereview.chromium.org/2180973003 Cr-Commit-Position: refs/heads/master@{#407674} [modify] https://crrev.com/0bc11b2ac870eb60d74f0f56337703ff6d4f1c80/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
,
Jul 26 2016
,
Aug 4 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mark@chromium.org
, Jul 25 2016Status: Available (was: Untriaged)
Summary: webkit_unit_tests AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount is flaky (was: "webkit_unit_tests (with patch)" is flaky)