New issue
Advanced search Search tips

Issue 631013 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Add Payment Request metrics for aborts.

Project Member Reported by se...@chromium.org, Jul 25 2016

Issue description

Add metrics to log the cause of an abort.

DismissedByUser
AbortedByMerchant
InvalidDataFromRenderer
MojoConnectionError
MojoRendererClosing
InstrumentDetailsError
NoMatchingPaymentMethod
NoSupportedPaymentMethod

 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 25 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/901a7d18d952ced7ed3ac901dca4860580f5a4c9

commit 901a7d18d952ced7ed3ac901dca4860580f5a4c9
Author: sebsg <sebsg@chromium.org>
Date: Fri Aug 05 15:54:36 2016

[Payments] Add metrics for Payment Request aborts.

BUG= 631013 

Review-Url: https://codereview.chromium.org/2199813003
Cr-Commit-Position: refs/heads/master@{#410069}

[modify] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/android/java_sources.gni
[modify] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[add] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/test/data/android/payments/metrics.js
[add] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/chrome/test/data/android/payments/payment_request_metrics_test.html
[modify] https://crrev.com/901a7d18d952ced7ed3ac901dca4860580f5a4c9/tools/metrics/histograms/histograms.xml

Labels: -M-54 Merge-Request-53 M-53

Comment 4 by dimu@chromium.org, Aug 8 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f892cd6969610c471b26c60054ac943fb94490a

commit 1f892cd6969610c471b26c60054ac943fb94490a
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Aug 08 15:19:24 2016

[Merge M-53] [Payments] Add metrics for Payment Request aborts.

BUG= 631013 

Review-Url: https://codereview.chromium.org/2199813003
Cr-Commit-Position: refs/heads/master@{#410069}
(cherry picked from commit 901a7d18d952ced7ed3ac901dca4860580f5a4c9)

Review URL: https://codereview.chromium.org/2228493003 .

Cr-Commit-Position: refs/branch-heads/2785@{#524}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/android/java_sources.gni
[modify] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[add] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/test/data/android/payments/metrics.js
[add] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/chrome/test/data/android/payments/payment_request_metrics_test.html
[modify] https://crrev.com/1f892cd6969610c471b26c60054ac943fb94490a/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment