serviceworker-echo-referrer-from-default-document.html is flaky on Windows and Linux |
||||||||
Issue descriptionWebKit Win7 (dbg): 6/20 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/ WebKit Win10: 4/20 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
,
Jul 25 2016
,
Jul 25 2016
Removing from sheriff queue because a non-sheriff (yhirano@) has taken ownership and this doesn't need to stay on the sheriffs' radar.
,
Jul 25 2016
Now it's flaky on Linux also (two failures in a wrong, no obvious cause). https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21317 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21318
,
Jul 25 2016
Adding full test case name for better searching: http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html
,
Jul 25 2016
^in a wrong^in a row
,
Jul 25 2016
and again twmo more Linux flakes: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/15245 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/15252 I will disable there.
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1528936cab3bfbd56db87f04750c231968efef08 commit 1528936cab3bfbd56db87f04750c231968efef08 Author: mpearson <mpearson@chromium.org> Date: Tue Jul 26 00:22:12 2016 Disable Flaky serviceworker-echo-referrer-from-default-document.html Test NOTRY=1 TBR=yhirano@chromium.org BUG= 630996 Review-Url: https://codereview.chromium.org/2174423003 Cr-Commit-Position: refs/heads/master@{#407648} [modify] https://crrev.com/1528936cab3bfbd56db87f04750c231968efef08/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 26 2016
I can reproduce the failure. The flakiness comes from serviceworker registration. When the serviceworker is already registered, the test passes. When I reverted 36f52aca24a7fdf60ff33ada980e663e550b622b locally, the test failure is gone. yukishiino@, can you take a look?
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/981ce039703c0350086568b8c922bee8b8ca2761 commit 981ce039703c0350086568b8c922bee8b8ca2761 Author: yukishiino <yukishiino@chromium.org> Date: Thu Jul 28 12:14:34 2016 binding: Disallows to run a function if its context is detached. There are two contexts when about to run a ScheduledAction. |this|'s context and the context of the function to be run. If the latter context no longer has a valid V8PerContextData, |self| returns null. function() { self.testRunner; } // self will be null This issue has been there for a long time, but https://crrev.com/2049493005 made it easy to happen. This CL disallows to run a function if the function's context is detached. This is not the right fix, but close to the behavior before https://crrev.com/2049493005 . The right fix is that, per spec, |self| always returns the global proxy object that never be null. I.e. we need to support detached windows. BUG= 630996 Review-Url: https://codereview.chromium.org/2191543002 Cr-Commit-Position: refs/heads/master@{#408376} [modify] https://crrev.com/981ce039703c0350086568b8c922bee8b8ca2761/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
,
Jul 28 2016
yhirano@, could you take care of the rest? I think we need to enable the test.
,
Jul 28 2016
,
Jul 28 2016
Thank you. I will do.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0c153825786146160beb3fa7b5742ea12e3c04c commit b0c153825786146160beb3fa7b5742ea12e3c04c Author: yhirano <yhirano@chromium.org> Date: Fri Jul 29 09:19:21 2016 Rewrite Fetch API referrer layout tests with service worker BUG= 630996 Review-Url: https://codereview.chromium.org/2192743002 Cr-Commit-Position: refs/heads/master@{#408607} [modify] https://crrev.com/b0c153825786146160beb3fa7b5742ea12e3c04c/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/b0c153825786146160beb3fa7b5742ea12e3c04c/third_party/WebKit/LayoutTests/http/tests/fetch/referrer/resources/empty-referrer-origin.html [add] https://crrev.com/b0c153825786146160beb3fa7b5742ea12e3c04c/third_party/WebKit/LayoutTests/http/tests/fetch/referrer/resources/empty.html [delete] https://crrev.com/a42e8b81874bea9d61f5b8c99574f058263652a9/third_party/WebKit/LayoutTests/http/tests/fetch/referrer/resources/serviceworker-echo-referrer-from-default-document.html [delete] https://crrev.com/a42e8b81874bea9d61f5b8c99574f058263652a9/third_party/WebKit/LayoutTests/http/tests/fetch/referrer/resources/serviceworker-from-origin-only-document.html [modify] https://crrev.com/b0c153825786146160beb3fa7b5742ea12e3c04c/third_party/WebKit/LayoutTests/http/tests/fetch/referrer/serviceworker-echo-referrer-from-default-document.html [modify] https://crrev.com/b0c153825786146160beb3fa7b5742ea12e3c04c/third_party/WebKit/LayoutTests/http/tests/fetch/referrer/serviceworker-from-origin-only-document.html [modify] https://crrev.com/b0c153825786146160beb3fa7b5742ea12e3c04c/third_party/WebKit/LayoutTests/http/tests/fetch/resources/fetch-test-helpers.js
,
Aug 1 2016
,
Aug 4 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by msramek@chromium.org
, Jul 25 2016Status: Assigned (was: Available)