Chrome TOS dialog on Android breaks telemetry benchmarks |
||
Issue descriptionSteps to reproduce: 1. Build chrome_public_apk (I tested with at r407434). 2. Run benchmark: ./tools/perf/run_benchmark v8.browsing_mobile --browser=android-chromium --story-filter=facebook Expected: the benchmark runs successfully Actual: Chrome shows a popup window "By continuing, you agree to Chrome's Terms of Service and Privacy Notice" and the benchmark fails with "EvaluateException: TypeError: Cannot read property 'pageScaleFactor' of undefined" Note that telemetry passes --no-first-run command line flag t chrome. So it look like the the TOS dialog does not respect that flag. CL that introduced TOS dialog: https://codereview.chromium.org/2062083002 gogerald@, ewald@, is there command line switch to disable TOS dialog?
,
Jul 25 2016
Looks like the TOS popup depends on local state. I tried two Nexus 4 devices. One of them shows the popup on every run. The other never shows the popup.
,
Jul 25 2016
Lightweight FRE (TOS) is for view intents, there may have no tests use view intent and expect FRE disabled. Fix in this CL https://codereview.chromium.org/2177943002/. Verified with --disable-fre
,
Jul 26 2016
Thanks for the fix!
,
Jul 27 2016
I patched in the CL mentioned and set the appropriate flag but the pop up still shows up. Command line: tools/perf/run_benchmark v8.browsing_mobile --browser=exact --browser-executable=out/Release-android/apks/ChromePublic.apk --extra-browser-args="--disable-fre"
,
Jul 27 2016
That's weird, I've verified. Could you check whether this switch has been passed to Chrome, https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java?rcl=0&l=32
,
Jul 28 2016
To be honest, I factory reset the device because I needed to take some measurements. I cannot reproduce it anymore.
,
Jul 28 2016
OK, '--disable-fre' should be able to disable both full and scoped FRE with that patch, will submit it, let me know if you can reproduce it again.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53fe02c66f753e2863267ef1d40dff81d1746773 commit 53fe02c66f753e2863267ef1d40dff81d1746773 Author: gogerald <gogerald@chromium.org> Date: Thu Jul 28 14:09:13 2016 Do not show Lightweight FRE if it is disabled BUG= 630991 Review-Url: https://codereview.chromium.org/2177943002 Cr-Commit-Position: refs/heads/master@{#408387} [modify] https://crrev.com/53fe02c66f753e2863267ef1d40dff81d1746773/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java [modify] https://crrev.com/53fe02c66f753e2863267ef1d40dff81d1746773/chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java
,
Jul 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by nedngu...@google.com
, Jul 25 2016