New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630982 link

Starred by 6 users
Status: Fixed
Owner:
michae...@chromium.org
Closed: Nov 2016
Cc:
mahmadi@chromium.org
rouslan@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
dbeam@chromium.org
tbuck...@chromium.org
█ msrchandra@chromium.org
bettes@chromium.org
michae...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 639523
issue 641400
issue 641859


Sign in to add a comment

Language settings need visual updates

Reported by jshan...@etouch.net, Jul 25 2016 
Chrome version:54.0.2805.0 (Official Build)1243666b4f5c7c48312233e1f6e6fda46191b184-refs/heads/master@{#407311} 32/64-bit.
OS: Windows(7,8,10)

Steps:
1. Launch Chrome and navigate to chrome://settings/advanced
2. Click on 'Manage languages' under language section and check 'Hindi'(or Japnese, Italian,Malyalam) checkbox under All languages.
3. Click on back navigation button and observe font 'Hindi' under Languages.

Actual: Unnecessary blue font color is seen for selected language even though default language is English.

Expected: No such blue font color should be seen for selected language when default language is English.

This is regression issue broken in M-54, below is bisect info.

Good build: 53.0.2777.0
Bad build: 53.0.2778.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/ec749b1eeaa49a45973e651e870ed16531c8b0d9..1fa2a1476f5bb37a192979135e5a7a4c7595dbcb?pretty=fuller&n=100

Suspecting: r401763 ?

Please help to re-assign if your change is not the cause for this issue.

Note:1. This is Windows specific issue not seen on Mac and Linux OS.
     2. Above issue is not seen for all languages.
Actual_video.mp4
737 KB View Download

Comment 1 by dbeam@chromium.org, Jul 25 2016

Cc: dbeam@chromium.org michae...@chromium.org tbuck...@chromium.org
Labels: -M-54
Owner: bettes@chromium.org
the language is blue if Chrome's UI can be shown in that language (it also has a hand cursor).

bettes@/tbuckley@: how can we better convey how to switch Chrome's UI language?

Comment 2 by tbuck...@chromium.org, Jul 29 2016

Labels: Proj-MaterialDesign-WebUI Hotlist-MD-Settings-Languages
None of the options should be blue. For such languages, could we have secondary text saying something like "Chrome cannot be displayed in this language" on a line below?

@bettes, what do you think?

Comment 3 by bettes@chromium.org, Aug 19 2016

Owner: michae...@chromium.org
New Mocks updated. Michael, let me know if you have any questions or concerns.

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Language-1.png%3Fz=width&c=show

Comment 4 by michae...@chromium.org, Aug 19 2016

Labels: -OS-Windows -Type-Bug-Regression OS-All Type-Bug
Status: Started (was: Assigned)
Summary: Language settings need visual updates (was: Regression: Weird behavior for fonts under languages is seen in chrome://md-settings.)
Repurposing bug for design updates.

Comment 5 by michae...@chromium.org, Aug 20 2016

Blockedon: 639523

Comment 6 by tbuck...@chromium.org, Aug 22 2016

Cc: bettes@chromium.org mahmadi@chromium.org
 Issue 636227  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a670d48822912050a3c06bf1f3afb1a01c1e0a3

commit 9a670d48822912050a3c06bf1f3afb1a01c1e0a3
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Aug 25 02:06:37 2016

Replace Manage Languages with dialog and dropdown item

Remove the sub-page. Add a simple dialog to select new languages. Add an
option to the language list to remove a language.

A search box will be added to the dialog next.

BUG= 630982 
TEST=SettingsLanguagesPageBrowserTest
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2265253002
Cr-Commit-Position: refs/heads/master@{#414246}

[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/app/settings_strings.grdp
[add] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[add] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/languages_page/languages_page.js
[delete] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/chrome/browser/resources/settings/languages_page/manage_languages_page.html
[delete] https://crrev.com/449e2fc928a4a579182f6f49f4defbfcec2b1c4c/chrome/browser/resources/settings/languages_page/manage_languages_page.js
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/9a670d48822912050a3c06bf1f3afb1a01c1e0a3/chrome/test/data/webui/settings/languages_page_browsertest.js

Comment 8 by michae...@chromium.org, Aug 26 2016

Blockedon: 641400
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea

commit b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea
Author: michaelpg <michaelpg@chromium.org>
Date: Sat Aug 27 10:39:01 2016

Use one instance of language settings detail menu for all languages

Wrap the language settings overflow menu in a <cr-shared-menu>. The contents
of the language detail page will be moved into this menu, so it would be
better not to stamp it once for each item in the list of enabled languages.

BUG= 630982 
TEST=SettingsLanguagesPageBrowserTest
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277633003
Cr-Commit-Position: refs/heads/master@{#414891}

[modify] https://crrev.com/b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/b44ce49d6fa9df4aa44b14c7d5df3416ff1392ea/chrome/test/data/webui/settings/languages_page_browsertest.js

Comment 10 by michae...@chromium.org, Aug 29 2016

Blockedon: 641859

Comment 11 by michae...@chromium.org, Sep 20 2016 

screenshot of https://codereview.chromium.org/2351963003 (Detail page removed, dropdown items added)
language_detail_menu.png
89.0 KB View Download
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3b245a46107e57dd0ef8ace954adf648a900ab4

commit c3b245a46107e57dd0ef8ace954adf648a900ab4
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Sep 22 03:20:56 2016

MD Settings: Replace language detail page with dropdown menu items

Remove the language detail subpage, since it doesn't have much content and
sometimes has none at all. This moves "Display Chrome in this language" and
"Translate pages in this language" to checkboxes in the language's overflow
menu. The Restart button is moved into the language item, shown when the
language will be applied on the next restart.

As per mocks. Screenshot:  https://crbug.com/630982#c11 

BUG= 630982 
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2351963003
Cr-Commit-Position: refs/heads/master@{#420249}

[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/app/settings_chromium_strings.grdp
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/app/settings_google_chrome_strings.grdp
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/app/settings_strings.grdp
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[delete] https://crrev.com/2064859d41bd8d4700807a7f13df6712101586a4/chrome/browser/resources/settings/languages_page/language_detail_page.html
[delete] https://crrev.com/2064859d41bd8d4700807a7f13df6712101586a4/chrome/browser/resources/settings/languages_page/language_detail_page.js
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/c3b245a46107e57dd0ef8ace954adf648a900ab4/chrome/test/data/webui/settings/languages_page_browsertest.js

Comment 13 by michae...@chromium.org, Sep 22 2016 

screenshots for before/after of https://codereview.chromium.org/2359353002/
old.png
101 KB View Download
polish.png
101 KB View Download

Comment 14 by michae...@chromium.org, Sep 23 2016 

updated with the menu separator and consistent heights when checkboxes are present
menu_simple.png
67.3 KB View Download
menu_complex.png
83.9 KB View Download

Comment 15 by dbeam@chromium.org, Sep 27 2016

Cc: rouslan@chromium.org
 Issue 626348  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11da429912fdbd07dfda4ebafec78fcc2163c58

commit e11da429912fdbd07dfda4ebafec78fcc2163c58
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Sep 29 00:36:40 2016

MD Settings: Polish for Languages main page

Updates to the mocks:
* Fix cr-shared-menu width to 320px
* "Move to the top" shortcut for moving languages all the way up
* Expanded style for cr-shared-menu with separator
* Change selected input method visual state to say "Enabled"
* Change spellcheck toggle buttons to checkboxes

Also:
* Close cr-shared-menu after changing a checkbox item
* Render Add Languages dialog's iron-list properly

screenshots:  https://crbug.com/630982#c13 

BUG= 630982 
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2359353002
Cr-Commit-Position: refs/heads/master@{#421695}

[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/browser/resources/settings/languages_page/languages.js
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/browser/resources/settings/languages_page/languages_types.js
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/test/data/webui/settings/languages_page_browsertest.js
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/chrome/test/data/webui/settings/languages_tests.js
[modify] https://crrev.com/e11da429912fdbd07dfda4ebafec78fcc2163c58/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html

Comment 17 by michae...@chromium.org, Nov 24 2016 

Edit Dictionary tweaks are in review. Remaining focus issues are being handled separately (also in review).
ed_before.png
25.8 KB View Download
ed_after.png
25.4 KB View Download
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f168619327c17934598e8add95bf5c3f17045519

commit f168619327c17934598e8add95bf5c3f17045519
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Nov 29 01:57:14 2016

Language settings: tweak Custom Spelling page

Couple minor visual tweaks to the Add Word row; see screenshots at
 https://crbug.com/630982 #17.

BUG= 630982 
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2525003006
Cr-Commit-Position: refs/heads/master@{#434827}

[modify] https://crrev.com/f168619327c17934598e8add95bf5c3f17045519/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html

Comment 19 by michae...@chromium.org, Nov 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment