New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630971 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Headers in "Network" in Developer Tools are not autoexpanded as earlier

Reported by superpoi...@gmail.com, Jul 25 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36

Steps to reproduce the problem:
1. Visit a site with developer tools open
2. Go to Network and chose any file to see the headers

What is the expected behavior?
Headers were auto expanded earlier. Now it's different and inconvenient. 

What went wrong?
Headers need to be expanded everytime such as for Response headers, request headers, general and so on. 

Did this work before? Yes Previous version

Chrome version: 54.0.2805.0  Channel: canary
OS Version: 6.2 (Windows 8)
Flash Version: Shockwave Flash 22.0 r0
 
Untitled picture.png
458 KB View Download
Labels: -Type-Bug -Pri-2 Pri-1 Type-Bug-Regression
Owner: allada@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by allada@chromium.org, Jul 25 2016

Status: Started (was: Assigned)

Comment 3 by allada@chromium.org, Jul 25 2016

Cc: l...@chromium.org
Found offending patch: https://codereview.chromium.org/2147343002
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11d703f3d3c135b2feb9b12509cf1ce60cc1f18c

commit 11d703f3d3c135b2feb9b12509cf1ce60cc1f18c
Author: luoe <luoe@chromium.org>
Date: Tue Jul 26 15:16:02 2016

Revert of DevTools: cleanup treeoutline expand logic (patchset #1 id:1 of https://codereview.chromium.org/2147343002/ )

Reason for revert:
[Devtools] Broke header tabs in network tab

BUG= 630971 
Original issue's description:
> DevTools: cleanup treeoutline expand logic
>
> TreeElement.expand() should not need to check that the element has children and
> TreeOutline.insertChild() should not automatically expand a child when it is
> inserted. ObjectPropertiesSection.js depended on this logic to automatically
> expand the Entries property. This CL updates it so that the Entries property is
> added before expanded.
>
> BUG=
>
> Committed: https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7
> Cr-Commit-Position: refs/heads/master@{#407061}

TBR=lushnikov@chromium.org,luoe@chromium.org

Review-Url: https://codereview.chromium.org/2182783002
Cr-Commit-Position: refs/heads/master@{#407801}

[modify] https://crrev.com/11d703f3d3c135b2feb9b12509cf1ce60cc1f18c/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js
[modify] https://crrev.com/11d703f3d3c135b2feb9b12509cf1ce60cc1f18c/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Comment 5 by allada@chromium.org, Jul 29 2016

Status: Fixed (was: Started)

Sign in to add a comment