New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630970 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 634343
issue 642463

Blocking:
issue 589726


Show other hotlists

Hotlists containing this issue:
Fixing-touch


Sign in to add a comment

Re-enable search:portal:google on Windows

Project Member Reported by petrcermak@chromium.org, Jul 25 2016

Issue description

This is the failure:

[ RUN      ] search:portal:google
Traceback (most recent call last):
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 319, in RunStory
    self._current_page.Run(self)
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\page\__init__.py", line 99, in Run
    self.RunPageInteractions(action_runner)
  File "e:\b\swarm_slave\w\irixyohv\tools\perf\core\path_util.pyc\..\..\page_sets\system_health\system_health_story.py", line 79, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "e:\b\swarm_slave\w\irixyohv\tools\perf\page_sets\system_health\searching_stories.py", line 44, in _DidLoadDocument
    action_runner.TapElement(selector=self._RESULT_SELECTOR)
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 222, in TapElement
    selector=selector, text=text, element_function=element_function))
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 45, in _RunAction
    action.RunAction(self._tab)
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\actions\tap.py", line 70, in RunAction
    tab.WaitForJavaScriptExpression('window.__tapActionDone', 60)
  File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 136, in WaitForJavaScriptExpression
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.
Console output:

[  FAILED  ] search:portal:google (92473 ms)

The key stack frame here is:

tab.WaitForJavaScriptExpression('window.__tapActionDone', 60)

I think that there are two possible explanations:

1) The Chrome code for simulating a tap times out.
2) As a result of tapping on the result link, Chrome navigates to the target URL *before* Telemetry inspects the value of |window.__tapActionDone|.

The latter seems more likely to me and should be relatively easy to fix: Change the condition to `window.__tapActionDone || window.__tapAction === undefined`.
Components: Tests>Telemetry
Labels: Pri-2 Type-Bug
Telemetry fix pending: https://codereview.chromium.org/2178903002/
Components: UI>Input>Touch Internals>Input
Judging by https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/3859/steps/Telemetry%20Tests%20with%20Stable%20Browser/logs/stdio (patch: https://codereview.chromium.org/2178903002/), it looks like there's a problem in Chrome on Windows (rather than in telemetry).
I haven't been able to reproduce this locally (even though I used the same command on the same platform). Furthermore, I'm now blocked on https://github.com/catapult-project/catapult/issues/2537. I'll look into this further next week.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/523a3b57e0bd4c0937cdcc3f0a833edc51177b0b

commit 523a3b57e0bd4c0937cdcc3f0a833edc51177b0b
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Aug 04 18:50:08 2016

Roll src/third_party/catapult/ d7bc1bf8c..5fa573992 (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d7bc1bf8cb0b..5fa5739922d3

$ git log d7bc1bf8c..5fa573992 --date=short --no-merges --format='%ad %ae %s'

BUG= 630970 ,634343

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2211103002
Cr-Commit-Position: refs/heads/master@{#409850}

[modify] https://crrev.com/523a3b57e0bd4c0937cdcc3f0a833edc51177b0b/DEPS

Blockedon: 634343
Blockedon: 642463
Cc: nedngu...@google.com petrcermak@chromium.org
Owner: hjd@chromium.org
Summary: Re-enable search:portal:google on Windows (was: search:portal:google failing smoke tests on Win7)
Cc: -petrcermak@chromium.org
Status: Archived (was: Assigned)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment