Re-enable search:portal:google on Windows |
|||||||||
Issue descriptionPatch that added the story: https://codereview.chromium.org/2148843002/ Failing build: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/50880 Patch that reverted the story: https://codereview.chromium.org/2173943003/
,
Jul 25 2016
Telemetry fix pending: https://codereview.chromium.org/2178903002/
,
Jul 25 2016
Judging by https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/3859/steps/Telemetry%20Tests%20with%20Stable%20Browser/logs/stdio (patch: https://codereview.chromium.org/2178903002/), it looks like there's a problem in Chrome on Windows (rather than in telemetry).
,
Jul 25 2016
I haven't been able to reproduce this locally (even though I used the same command on the same platform). Furthermore, I'm now blocked on https://github.com/catapult-project/catapult/issues/2537. I'll look into this further next week.
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/523a3b57e0bd4c0937cdcc3f0a833edc51177b0b commit 523a3b57e0bd4c0937cdcc3f0a833edc51177b0b Author: catapult-deps-roller <catapult-deps-roller@chromium.org> Date: Thu Aug 04 18:50:08 2016 Roll src/third_party/catapult/ d7bc1bf8c..5fa573992 (2 commits). https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d7bc1bf8cb0b..5fa5739922d3 $ git log d7bc1bf8c..5fa573992 --date=short --no-merges --format='%ad %ae %s' BUG= 630970 ,634343 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2211103002 Cr-Commit-Position: refs/heads/master@{#409850} [modify] https://crrev.com/523a3b57e0bd4c0937cdcc3f0a833edc51177b0b/DEPS
,
Aug 5 2016
,
Aug 30 2016
,
Oct 3 2016
,
Oct 3 2016
,
Nov 3 2016
,
Sep 18
Archiving old bugs that have only received trivial updates for some time. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by petrcermak@chromium.org
, Jul 25 2016This is the failure: [ RUN ] search:portal:google Traceback (most recent call last): File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\story_runner.py", line 85, in _RunStoryAndProcessErrorIfNeeded state.RunStory(results) File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\page\shared_page_state.py", line 319, in RunStory self._current_page.Run(self) File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\page\__init__.py", line 99, in Run self.RunPageInteractions(action_runner) File "e:\b\swarm_slave\w\irixyohv\tools\perf\core\path_util.pyc\..\..\page_sets\system_health\system_health_story.py", line 79, in RunPageInteractions self._DidLoadDocument(action_runner) File "e:\b\swarm_slave\w\irixyohv\tools\perf\page_sets\system_health\searching_stories.py", line 44, in _DidLoadDocument action_runner.TapElement(selector=self._RESULT_SELECTOR) File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 222, in TapElement selector=selector, text=text, element_function=element_function)) File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\actions\action_runner.py", line 45, in _RunAction action.RunAction(self._tab) File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\actions\tap.py", line 70, in RunAction tab.WaitForJavaScriptExpression('window.__tapActionDone', 60) File "e:\b\swarm_slave\w\irixyohv\third_party\catapult\telemetry\telemetry\internal\browser\web_contents.py", line 136, in WaitForJavaScriptExpression e.message + '\n' + debug_message) TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue. Console output: [ FAILED ] search:portal:google (92473 ms) The key stack frame here is: tab.WaitForJavaScriptExpression('window.__tapActionDone', 60) I think that there are two possible explanations: 1) The Chrome code for simulating a tap times out. 2) As a result of tapping on the result link, Chrome navigates to the target URL *before* Telemetry inspects the value of |window.__tapActionDone|. The latter seems more likely to me and should be relatively easy to fix: Change the condition to `window.__tapActionDone || window.__tapAction === undefined`.