New issue
Advanced search Search tips

Issue 630967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

svg/parser/whitespace-length-invalid-2.html is flaky on Linux (dbg)

Project Member Reported by msramek@chromium.org, Jul 25 2016

Issue description

WebkKit Linux (dbg):

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29

As of now, this test has failed in 9 out of 20 last builds.

 
Cc: f...@opera.com
The first occurrence seems to be

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8512

I don't see an obvious culprit between recently landed CLs landed during this build and a few builds before. I'll update the expectations for this test and assign to fs@opera.com who seems to be most active in this area.

Summary: svg/parser/whitespace-length-invalid-2.html is flaky on Linux (dbg) (was: svg/parser/whitespace-length-invalid-2.html is flaky on Linux)
Specifically disabling on Linux (dbg), since other Linux WebKit bots don't show this flake.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f540d6bc78f31f20b45efee05fd2797877ffa9ec

commit f540d6bc78f31f20b45efee05fd2797877ffa9ec
Author: msramek <msramek@chromium.org>
Date: Mon Jul 25 11:33:59 2016

Disable the flaky test svg/parser/whitespace-length-invalid-2.html

TBR=fs@opera.com
BUG= 630967 

Review-Url: https://codereview.chromium.org/2181633002
Cr-Commit-Position: refs/heads/master@{#407448}

[modify] https://crrev.com/f540d6bc78f31f20b45efee05fd2797877ffa9ec/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by f...@opera.com, Jul 25 2016

Components: Blink>SVG
Could be anything related to the data collected into ConsoleMessage I guess. In build 8511 (where the test times out, but passes in the re-run) I see this V8 commit that might be relevant: https://chromium.googlesource.com/v8/v8/+/3138862703079c60dcc2406dca1011fcacb4e264

Should probably just split this test a few times though...
FYI, svg/parser/whitespace-length-invalid-1.html now appears flaky.  It failed twice in the last 3 hours.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8559
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8561

I wonder if disabling the "-2" test simply caused the flaky situation to "move" to the -1 test?



Cc: -f...@opera.com
Owner: f...@opera.com
Status: Assigned (was: Available)
Labels: -Sheriff-Chromium
Removing from sheriff queue because the primary flake has been disabled.

Comment 8 by f...@opera.com, Jul 25 2016

Looking at

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=%0Asvg%2Fparser%2Fwhitespace-length-invalid-1.html

the "flake pattern" are essentially the same between -1 and -2 - it's just that -1 appears to have had more "luck" in passing in the re-run (light blue boxes) until recently.
Can you please disable the "-1" test then too?  thanks.

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fae046c80ecd8ee9c2d6dbc48916a67991291d0

commit 7fae046c80ecd8ee9c2d6dbc48916a67991291d0
Author: fs <fs@opera.com>
Date: Mon Jul 25 21:23:51 2016

Disable svg/parser/whitespace-length-invalid-1.html

TBR=mpearson@chromium.org
BUG= 630967 

Review-Url: https://codereview.chromium.org/2178993003
Cr-Commit-Position: refs/heads/master@{#407580}

[modify] https://crrev.com/7fae046c80ecd8ee9c2d6dbc48916a67991291d0/third_party/WebKit/LayoutTests/TestExpectations

I just saw a flake for svg/parser/whitespace-angle.html on Linux.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8568

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux__dbg_/8568/layout-test-results/results.html

According the dashboard, it looks pretty flaky, similar to the other tests.

I will disable it.
Still going through CQ: https://codereview.chromium.org/2183753002/

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/321563551f86614ba9ad38a39f0796e16d35cfdf

commit 321563551f86614ba9ad38a39f0796e16d35cfdf
Author: mpearson <mpearson@chromium.org>
Date: Tue Jul 26 06:36:41 2016

Disable webkit test svg/parser/whitespace-angle.html on Linux

NOTRY=1
TBR=fs@opera.com

BUG= 630967 

Review-Url: https://codereview.chromium.org/2183753002
Cr-Commit-Position: refs/heads/master@{#407725}

[modify] https://crrev.com/321563551f86614ba9ad38a39f0796e16d35cfdf/third_party/WebKit/LayoutTests/TestExpectations

Labels: hotlist-infra-opportunity
Cc: f...@opera.com
Owner: schenney@chromium.org
In the interests of efficient checking, we should also consider converting all of these parser tests to unit tests.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf

commit 64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf
Author: schenney <schenney@chromium.org>
Date: Thu Oct 27 13:16:03 2016

Break svg/parser tests into pieces to avoid timeouts

Test svg/parser/whitespace-angle.html has been broken into 2
around valid values. Note this means we run one set of tests twice,
once in each piece for invalid.forEach(validunits.forEach(...

Tests svg/parser/whitespace-length-invalid-1.html and
svg/parser/whitespace-length-invalid-2.html have been re-arranged
into 4 pieces around the set of invalid values.

R=fs@opera.com
BUG= 630967 

Review-Url: https://codereview.chromium.org/2452153002
Cr-Commit-Position: refs/heads/master@{#428010}

[modify] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1-expected.txt
[copy] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1.html
[copy] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2-expected.txt
[rename] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2.html
[modify] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1-expected.txt
[modify] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1.html
[modify] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt
[modify] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2.html
[add] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3-expected.txt
[add] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3.html
[add] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4-expected.txt
[add] https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4.html

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8967dab9f17779773188ca81f8d8454866f061ea

commit 8967dab9f17779773188ca81f8d8454866f061ea
Author: schenney <schenney@chromium.org>
Date: Fri Oct 28 17:57:11 2016

Break svg/parser/whitespace tests apart some more.

Some tests are still timing out on debug. Break them down
some more in an attempt to get them passing. Next step will
be to mark slow.

TBR=xidachen@chromium.org
BUG= 630967 

Review-Url: https://codereview.chromium.org/2454413002
Cr-Commit-Position: refs/heads/master@{#428419}

[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/resources/whitespace-helper.js
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1.html
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2.html
[add] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-invalid-expected.txt
[add] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-invalid.html
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1.html
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2.html
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3.html
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4.html
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-number-expected.txt
[modify] https://crrev.com/8967dab9f17779773188ca81f8d8454866f061ea/third_party/WebKit/LayoutTests/svg/parser/whitespace-number.html

Status: Fixed (was: Assigned)

Sign in to add a comment