New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630959 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird highlight of Apps icon is seen on Bookmark bar.

Reported by dmascare...@etouch.net, Jul 25 2016

Issue description

Chrome Version:54.0.2806.0 (Official Build) 4e19044900929958a03fc2d5c07cb2cc5aab47ff-refs/heads/master@{#407375}(64 bit)
OS:Mac(10.11.4,10.10.5)

What steps will reproduce the problem?
1. Launch chrome, open NTP and Hover the mouse on Apps icon, then long click on it.
2. Observe highlight.

Actual: Weird highlight of Apps icon is seen (i.e. hover highlight is 1 pixel more then the click highlight and dark grey highlight is seen)
Expected: Highlight should be proper.

This is regression issue,broken in ‘M 54’ and below is narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/f0829bf6d80a9109b399580fe48d8c3e1c66eeed..57954f33c1620558ce3403ffdb49ba10b4a8d35d?pretty=fuller&n=100

Suspecting: r407032 ?

Good build:54.0.2805.0
Bad build:54.0.2804.0

Note:1. Above issue is not reproducible on Windows and Linux OS.
     2. Above issue is not reproducible on Mac Retina(10.11.4)

 
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 2 by ajha@chromium.org, Jul 29 2016

Friendly ping to get an update on this from spqchan@.

Thank you!
Status: Started (was: Assigned)
Investigating
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/131f85cadf19ef25e9eafc14e39230cee35e7305

commit 131f85cadf19ef25e9eafc14e39230cee35e7305
Author: spqchan <spqchan@chromium.org>
Date: Thu Aug 04 02:36:09 2016

[Material][Mac] Fixed App Bookmark Item highlight

BUG= 630959 

Review-Url: https://codereview.chromium.org/2193383002
Cr-Commit-Position: refs/heads/master@{#409708}

[modify] https://crrev.com/131f85cadf19ef25e9eafc14e39230cee35e7305/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Cc: ranjitkan@chromium.org
Labels: TE-Verified-54.0.2823.0 TE-Verified-M54
Rechecked this on chrome version 54.0.2823.0 on MAC 10.11.6. Fix is working as intended. Highlight is displayed proper for a long click.

Adding TE-Verified labels.
Labels: -ReleaseBlock-Stable
Status: Fixed (was: Started)

Sign in to add a comment