Regression: [History] Unnecessary 'Remove selected items' overlay appears on pressing the 'Delete' key.
Reported by
dchau...@etouch.net,
Jul 25 2016
|
||||
Issue descriptionChrome Version: 54.0.2805.0 (Official Build)1243666b4f5c7c48312233e1f6e6fda46191b184-refs/heads/master@{#407311} 32/64-bit. OS: Windows(7,8,10), Linux (Ubuntu 14.04 LTS),Mac(10.10.5,10.11.4). Precondition: Create some history in browser. What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://history page. 2. Select the any URL by clicking on checkbox. 3. Now press 'Delete' key from keyboard and observe. Unnecessary 'Remove selected items' overlay appears on pressing the 'Delete' key. Selected URL should get removed on pressing the 'Delete' key from keyboard. This is a regression issue, broken in M-54 series, below is bisect info. Good build: 54.0.2802.0 Bad build: 54.0.2803.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/e7c83bff969b4114b280a0bfb146f7618a76ede1..74ed884d4d42cb7152dc75fae33351e8e34220cd?pretty=fuller&n=50 Suspecting: r406715 Kindly review the attached screen-cast for reference.
,
Jul 26 2016
I made it to show the overlay before actually process deleting because I think it should behave the same as you click on the 'DELETE' button in the toolbar. Also it would be useful to confirm with user when deleting multiple history items. What do you think? @tsergeant
,
Jul 26 2016
This is the behavior we intended, so I'm happy for you to mark this as WontFix. I think it might be handy to have a way to delete items without the prompt, but we can wait for user feedback to see whether that's necessary.
,
Jul 27 2016
Mark this as WontFix, but feel free to reopen it if there are many user complaints:-) |
||||
►
Sign in to add a comment |
||||
Comment 1 by msrchandra@chromium.org
, Jul 25 2016