Issue metadata
Sign in to add a comment
|
Phone number detection in the web is failing. |
||||||||||||||||||||
Issue descriptionVersion: Chrome 54/53 OS: Android 6.0.1 Device: Samsung Galaxy Note 4 What steps will reproduce the problem? (1) Launch Chrome browser (2) Load: "koreaherald.com" (3) Navigate to bottom of the page by scrolling. (3) Tap on phone number at 02-727-0074, subscribe@heraldcorp.com area in the page. (4) Contextual search is getting invoked as if like a text selection happened (We should see phone app to launch with this phone number for enabling phone call, because the pattern is a phone number pattern) What is the expected output? We should see phone app to launch with this phone number for enabling phone call What do you see instead? Contextual search is getting invoked as if like a text selection happened instead of identifying it as a phone number. Note: It appears like a regression, it works well in Chrome 44.X
,
Jul 26 2016
I'm not sure that the expectation is right: should tapping on anything that resembles a phone number initiate a call?
,
Jul 26 2016
When the pattern is identified as a phone number, then we are launching dialer App. It was working earlier in Chrome 44
,
Jul 26 2016
Hi Ted, you're listed as OWNER of phone_number_detector, could you confirm whether this should work? Thanks
,
Jul 27 2016
What I could see, is it's failing from libphonenumber lib code. PhoneNumberMatcher is not able to recognise, it as a phone number now.
,
Jul 27 2016
I honestly have no idea. That is one place that I absolutely should not be an OWNER of. Min, I know that you touched this at "some" point, but I wonder if you have any idea here? I'm not sure if we have any people that are really familiar with the various detectors here.
,
Jul 28 2016
i tried (800) 727-0114, and it works fine. Could due to a change in libphonumber, or an issue of country code, how is the device configured? If the device is with a US carrier, the number will not be recognized
,
Jul 28 2016
@qinmin - I will check and tell you about the country code which is getting passed.
,
Jul 28 2016
Also, country code has to be passed from device or from the site ? For example, even though device's local configuration is from US, but the website, user is visiting is say a Korean site, then the numbers appears in the site may be in Korean phone number pattern. So we need to pass KR country code even though device country code is US.
,
Aug 1 2016
the contry code is from the device, which is obtained from carrier. If a device is physically located in US, and is visiting a korean site, recognizing a KR phone number doesn't make too much sense as it will require the device to dial an international number, which will incur roaming cost. When setting the network-country-iso to "KR" through command line, clicking on 02-727-0074 will launch the dialer app. So everything works as expected. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ajit...@samsung.com
, Jul 26 2016