New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630931 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
gone, assign your bugs elsewhere :)
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----

Blocking:
issue 630930



Sign in to add a comment

jarsigner file timestamps are nondeterministic

Project Member Reported by stip@chromium.org, Jul 25 2016

Issue description

In https://chromium.googlesource.com/chromium/src/+/e77d565e1b9a8d3a2822b54bbaee1d81f5a67198/build/android/gyp/finalize_apk.py, jarsigner is called after the deterministic apk is created. Nondeterminism is added to the apk with jarsigner's files' modification times.
 
Cc: -jbudorick@chromium.org
Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)
Solution for now will be going back in to the APK after signing & modifying the files jarsigner adds.
Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7b32ac6019e85f6485d46860eb43bdbaf72a76f

commit c7b32ac6019e85f6485d46860eb43bdbaf72a76f
Author: agrieve <agrieve@chromium.org>
Date: Thu Jul 28 17:35:40 2016

Revert of [Android] Sanitize APK signing file timestamps. (patchset #3 id:40001 of https://codereview.chromium.org/2176023002/ )

Reason for revert:
Breaking builds:
https://bugs.chromium.org/p/chromium/issues/detail?id=632400

Original issue's description:
> [Android] Sanitize APK signing file timestamps.
>
> BUG= 630931 
>
> Committed: https://crrev.com/61e1a7ac087039d43e694c08584724252f9785ce
> Cr-Commit-Position: refs/heads/master@{#408389}

TBR=stip@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 630931 

Review-Url: https://codereview.chromium.org/2191673004
Cr-Commit-Position: refs/heads/master@{#408425}

[modify] https://crrev.com/c7b32ac6019e85f6485d46860eb43bdbaf72a76f/build/android/gyp/finalize_apk.py
[modify] https://crrev.com/c7b32ac6019e85f6485d46860eb43bdbaf72a76f/build/android/gyp/util/build_utils.py

Status: Started (was: Fixed)
Cc: jbudorick@chromium.org
Owner: stip@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a0b3727c071668ad72461c9d77e10dc579e407

commit b2a0b3727c071668ad72461c9d77e10dc579e407
Author: stip <stip@chromium.org>
Date: Tue Aug 02 05:34:44 2016

[Android] [Reland] Sanitize APK signing file timestamps.

This is a reland of http://crrev.com/2176023002#ps40001, with the added import of resource_sizes to patch python's zipfile. This allows older versions of python to process zip64 files.

BUG= 630931 , 632400

Review-Url: https://codereview.chromium.org/2193063002
Cr-Commit-Position: refs/heads/master@{#409142}

[modify] https://crrev.com/b2a0b3727c071668ad72461c9d77e10dc579e407/build/android/gyp/finalize_apk.py
[modify] https://crrev.com/b2a0b3727c071668ad72461c9d77e10dc579e407/build/android/gyp/util/build_utils.py

Comment 8 by stip@chromium.org, Aug 4 2016

Status: Fixed (was: Started)

Sign in to add a comment