New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 630919 link

Starred by 2 users
Status: Fixed
Owner:
█ shunhsingou@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
█ amylin@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Refactor AudioFunTest & modified into a portable version

Project Member Reported by amylin@google.com, Jul 25 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce the problem:
N/A

What is the expected behavior?

What went wrong?
N/A

Did this work before? N/A 

Chrome version: 51.0.2704.106  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 22.0 r0

Comment 1 by shunhsingou@chromium.org, Jul 25 2016

Cc: amylin@google.com
Components: Factory
Labels: -OS-Linux
Owner: shunhsingou@chromium.org
Status: Started (was: Unconfirmed)
Please also provide the design doc link here. Thanks!
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 25 2016

Labels: Hotlist-Google

Comment 4 by hungte@chromium.org, Aug 11 2016 

Any CLs in progress?

Comment 5 by shunhsingou@chromium.org, Aug 11 2016 

CL is under discussion and review https://chromium-review.googlesource.com/#/c/362917/.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b1a36f9fdb6503bc8fb9be1615973a8d581dd813

commit b1a36f9fdb6503bc8fb9be1615973a8d581dd813
Author: Amy Lin <amylin@google.com>
Date: Fri Sep 09 02:49:22 2016

Refactor audiotest

1. Add audiofuntest_v2, which is a portable version of audio functional test.
2. Remove source files that are no longer in use.
3. Separate source and header files.

CQ-DEPEND=CL:381047,CL:362917

BUG= chromium:630919 
TEST=emerge-peppy audiotest

Change-Id: I8a6c94c04d930fbe7cc34d682de49920d1e460a8
Reviewed-on: https://chromium-review.googlesource.com/383311
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/b1a36f9fdb6503bc8fb9be1615973a8d581dd813/chromeos-base/audiotest/audiotest-9999.ebuild
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b1a36f9fdb6503bc8fb9be1615973a8d581dd813

commit b1a36f9fdb6503bc8fb9be1615973a8d581dd813
Author: Amy Lin <amylin@google.com>
Date: Fri Sep 09 02:49:22 2016

Refactor audiotest

1. Add audiofuntest_v2, which is a portable version of audio functional test.
2. Remove source files that are no longer in use.
3. Separate source and header files.

CQ-DEPEND=CL:381047,CL:362917

BUG= chromium:630919 
TEST=emerge-peppy audiotest

Change-Id: I8a6c94c04d930fbe7cc34d682de49920d1e460a8
Reviewed-on: https://chromium-review.googlesource.com/383311
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/b1a36f9fdb6503bc8fb9be1615973a8d581dd813/chromeos-base/audiotest/audiotest-9999.ebuild
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b1a36f9fdb6503bc8fb9be1615973a8d581dd813

commit b1a36f9fdb6503bc8fb9be1615973a8d581dd813
Author: Amy Lin <amylin@google.com>
Date: Fri Sep 09 02:49:22 2016

Refactor audiotest

1. Add audiofuntest_v2, which is a portable version of audio functional test.
2. Remove source files that are no longer in use.
3. Separate source and header files.

CQ-DEPEND=CL:381047,CL:362917

BUG= chromium:630919 
TEST=emerge-peppy audiotest

Change-Id: I8a6c94c04d930fbe7cc34d682de49920d1e460a8
Reviewed-on: https://chromium-review.googlesource.com/383311
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/b1a36f9fdb6503bc8fb9be1615973a8d581dd813/chromeos-base/audiotest/audiotest-9999.ebuild
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/8c768a711610e5197abf5ec275b84cf30ca60ee2

commit 8c768a711610e5197abf5ec275b84cf30ca60ee2
Author: Amy Lin <amylin@google.com>
Date: Mon Aug 01 07:44:16 2016

Portable Audiofuntest

This is a portable and refactored version of audiofuntest.
The audio input / output is now implemented by using pipe with other
recorder and player program.
So that we can remove the dependency of ALSA library.

CQ-DEPEND=CL:383311

BUG= chromium:630919 
TEST=1. Run 'audiofuntest args...' on <Board Name>
     2. Run 'audiofuntest args...' on a Android device.

Change-Id: I2efa0f43f199db3b28ab1dea734dcafbd75d9ac7
Reviewed-on: https://chromium-review.googlesource.com/362917
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/include/evaluator.h
[modify] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/common.h
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/connector.cc
[modify] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/Makefile
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/audiofuntest_v2.cc
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/include/frame_generator.h
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/Android.mk
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/include/connector.h
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/param_config.cc
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/include/param_config.h
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/include/util.h
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/evaluator.cc
[add] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/frame_generator.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/65db5b778b0dc72778c86e0e8ce47ab353a1bf74

commit 65db5b778b0dc72778c86e0e8ce47ab353a1bf74
Author: Amy Lin <amylin@google.com>
Date: Tue Sep 06 08:49:29 2016

Reconstruct audiotest project

Move source file into src/ and header file into include/
Also removed audiofuntest, test_tones and looptest.
Rename audiofuntest_v2 to audiofuntest.

CQ-DEPEND=CL:383311

BUG= chromium:630919 
TEST=None

Change-Id: Icd9e1e744bae49ee35ccbd22e9d9f1fa2cbbe6f8
Reviewed-on: https://chromium-review.googlesource.com/381047
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[add] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/include/module.mk
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/test_tones.cc
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/frame_generator.cc
[modify] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/Makefile
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/tone_generators.cc
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/cras_api_test.c
[add] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/module.mk
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/libaudiodev.c
[modify] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/Android.mk
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/audiofuntest.cc
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/evaluator.cc
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/include/common.h
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/alsa_api_test.c
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/audiofuntest.cc
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/alsa_client.cc
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/alsa_client.h
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/connector.cc
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/include/libaudiodev.h
[delete] https://crrev.com/8c768a711610e5197abf5ec275b84cf30ca60ee2/looptest.c
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/loopback_latency.c
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/include/tone_generators.h
[rename] https://crrev.com/65db5b778b0dc72778c86e0e8ce47ab353a1bf74/src/param_config.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 15 2016

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/39d156833e326abcc517b969dbe426acc1b9f4bb

commit 39d156833e326abcc517b969dbe426acc1b9f4bb
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Nov 14 06:23:50 2016

audiofuntest: fix PIPE buffer issue

The PIPE buffer between audiofuntest and the player program causes a
unpredictable delay for the looping. To avoid such issue, we set the PIPE
buffer to the smallest size.

BUG= chromium:630919 
TEST=manually

Change-Id: I907fa22369c586138b5b800e346a0abf486db5df
Reviewed-on: https://chromium-review.googlesource.com/411682
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/39d156833e326abcc517b969dbe426acc1b9f4bb/src/connector.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/bfb48de8b462b6e79d875210d85f793bdf51bd22

commit bfb48de8b462b6e79d875210d85f793bdf51bd22
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Nov 14 06:26:04 2016

audiofuntest: change the output format for backward compatibility

There are some unnecessary changes of the output format in previous
refactoring. To keep better backward compatibility for the users, e.g.
factory audio_loop test, revert those changes.

BUG= chromium:630919 
TEST=manually

Change-Id: I4b242936ca83ba0b96421712d7f63375fd0f6944
Reviewed-on: https://chromium-review.googlesource.com/411683
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/bfb48de8b462b6e79d875210d85f793bdf51bd22/src/audiofuntest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/46cc6a36ebb903de2e5f31f8e6f5d0a3d7cc4d23

commit 46cc6a36ebb903de2e5f31f8e6f5d0a3d7cc4d23
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Nov 14 06:20:05 2016

audio_loop: fix audiofuntest

audiofuntest is redesigned for portability by using PIPE instead of
hardcoded ALSA interface. The input / output format of audiofuntest had
been slightly changed after this refactoring. This CL fixes audio_loop
for the refactoring.

CQ-DEPEND=CL:411683

BUG= chromium:630919 
TEST=manually

Change-Id: Id86b996d49d08615b1146766c06f79f2876d5e48
Reviewed-on: https://chromium-review.googlesource.com/411681
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/46cc6a36ebb903de2e5f31f8e6f5d0a3d7cc4d23/py/test/pytests/audio_loop/audio_loop.py
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/9456196acc0bd79e6f9b922567c18553681eb313

commit 9456196acc0bd79e6f9b922567c18553681eb313
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Nov 14 06:20:05 2016

audio_loop: fix audiofuntest

audiofuntest is redesigned for portability by using PIPE instead of
hardcoded ALSA interface. The input / output format of audiofuntest had
been slightly changed after this refactoring. This CL fixes audio_loop
for the refactoring.

CQ-DEPEND=CL:410984

BUG= chromium:630919 
TEST=manually

Change-Id: Id86b996d49d08615b1146766c06f79f2876d5e48
Reviewed-on: https://chromium-review.googlesource.com/411060
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/9456196acc0bd79e6f9b922567c18553681eb313/py/test/pytests/audio_loop/audio_loop.py
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/7503f27cf9c0bc26926a52eb1534b5e4b76fe08c

commit 7503f27cf9c0bc26926a52eb1534b5e4b76fe08c
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Nov 14 06:23:50 2016

audiofuntest: fix PIPE buffer issue

The PIPE buffer between audiofuntest and the player program causes a
unpredictable delay for the looping. To avoid such issue, we set the PIPE
buffer to the smallest size.

BUG= chromium:630919 
TEST=manually

Change-Id: I907fa22369c586138b5b800e346a0abf486db5df
Reviewed-on: https://chromium-review.googlesource.com/410983
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/7503f27cf9c0bc26926a52eb1534b5e4b76fe08c/src/connector.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/733306b21d01c4f76a9ed2281ff1220c7ded63b2

commit 733306b21d01c4f76a9ed2281ff1220c7ded63b2
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Nov 14 06:26:04 2016

audiofuntest: change the output format for backward compatibility

There are some unnecessary changes of the output format in previous
refactoring. To keep better backward compatibility for the users, e.g.
factory audio_loop test, revert those changes.

BUG= chromium:630919 
TEST=manually

Change-Id: I4b242936ca83ba0b96421712d7f63375fd0f6944
Reviewed-on: https://chromium-review.googlesource.com/410984
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/733306b21d01c4f76a9ed2281ff1220c7ded63b2/src/audiofuntest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/edb7158a441a69d40a1176f5e12c5ce2d398a7e7

commit edb7158a441a69d40a1176f5e12c5ce2d398a7e7
Author: Earl Ou <shunhsingou@google.com>
Date: Tue Nov 29 07:59:57 2016

Add back looptest and tone_tests

Previous CL:381047 removes looptest and tone_tests. However, those
binaries may still required by some factory tests. Copy those files back so
people can still use them in the future.

BUG= chromium:630919 
TEST=emerge-elm audiotest

Change-Id: I05bd8262dccb76b80ff4323a3e86f308a75c799b
Reviewed-on: https://chromium-review.googlesource.com/414863
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[add] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/test_tones.cc
[add] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/tone_generators.cc
[modify] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/module.mk
[add] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/libaudiodev.c
[add] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/include/alsa_client.h
[modify] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/Makefile
[add] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/looptest.c
[add] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/alsa_client.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/7ae955b16c3553921c1acd73fa47025be8e4a6cd

commit 7ae955b16c3553921c1acd73fa47025be8e4a6cd
Author: Earl Ou <shunhsingou@google.com>
Date: Wed Nov 30 08:41:22 2016

audiofuntest: remove ParamConfig and reuse AudioFunTestConfig

Tools in audiotest directory always parse their own config in their own
main cc file. Also, there is no reason to write a config file
instead of using command args. Remove this unrequired class to simplify
this repo.

Also remove unrequired parameters in the program.

This CL also fixes the following coding style issue, and check with
cpplint.py:
1. Unify pointer declaration. Use 'type *name' instead of 'type* name'
   for consistency. Same logic applies for '&'.
2. Sort import.
3. Remove unnecessary namespace declaration.
4. Remove "using" statement in header.
5. Unify the format of #ifndef guard.
6. use c style print function instead of c++ style cout/cerr for consistency.

BUG= chromium:630919 
TEST=manually tested on elm, cpplint.py include/*.h src/*.cc

Change-Id: I0f17ed66a9e256c655ed024ee82524b8dc834b82
Reviewed-on: https://chromium-review.googlesource.com/415284
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/test_tones.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/frame_generator.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/evaluator.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/cras_api_test.c
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/alsa_client.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/module.mk
[delete] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/include/param_config.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/common.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/frame_generator.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/looptest.c
[add] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/common.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/audiofuntest.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/evaluator.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/tone_generators.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/connector.cc
[add] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/CPPLINT.cfg
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/libaudiodev.c
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/libaudiodev.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/alsa_client.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/util.h
[delete] https://crrev.com/edb7158a441a69d40a1176f5e12c5ce2d398a7e7/src/param_config.cc
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/src/loopback_latency.c
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/tone_generators.h
[modify] https://crrev.com/7ae955b16c3553921c1acd73fa47025be8e4a6cd/include/connector.h
Project Member

Comment 19 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/06c1ad61d95e86b3e5bf88ba1813b7418548ec05

commit 06c1ad61d95e86b3e5bf88ba1813b7418548ec05
Author: Earl Ou <shunhsingou@google.com>
Date: Thu Dec 01 09:21:50 2016

Rename frame_generator to generator_player

We already have tone_generators.h that defines several type of wave
generators. The name frame_generator is confusing. What it actually does
is generating a wave, and writes the wave to the player client. To avoid
confusion, rename it into generator_player.

This CL also remove the redundant code in frame_generator, and using raw
bytes instead of 'frames' as the interface of player for better
efficiency and consistency with tone_generators.

Some of the duplicated code in common.h / utils.h is also removed.
SampleFormat is moved out as a separated file.

BUG= chromium:630919 
TEST=manually tested on elm.

Change-Id: I1679a49978092ca79b449b3cf31c64f7cc53de91
Reviewed-on: https://chromium-review.googlesource.com/415692
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/evaluator.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/test_tones.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/audiofuntest.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/module.mk
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/binary_client.h
[delete] https://crrev.com/5afc8d385fb928b12ed960c0507c3fdcd69f1575/src/frame_generator.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/alsa_client.h
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/common.h
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/evaluator.h
[add] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/sample_format.h
[delete] https://crrev.com/5afc8d385fb928b12ed960c0507c3fdcd69f1575/include/frame_generator.h
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/tone_generators.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/Android.mk
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/tone_generators.h
[add] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/sample_format.cc
[add] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/generator_player.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/binary_client.cc
[modify] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/src/alsa_client.cc
[delete] https://crrev.com/5afc8d385fb928b12ed960c0507c3fdcd69f1575/include/util.h
[add] https://crrev.com/06c1ad61d95e86b3e5bf88ba1813b7418548ec05/include/generator_player.h

Comment 21 by shunhsingou@chromium.org, Dec 21 2016

Status: Fixed (was: Started)
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/9e0a25e4e5fda04d5a7935de07311438ced53cfc

commit 9e0a25e4e5fda04d5a7935de07311438ced53cfc
Author: Earl Ou <shunhsingou@google.com>
Date: Wed Dec 14 06:39:50 2016

audio_loop: update audiofuntest parameters

In CL:415284 we removed the config file for audiofuntest to keep things
clean. Update the pytest cooresponding to the change.

BUG= chromium:630919 
TEST=manually

Change-Id: Ia2281737072efbe6f52fb1c79db5d0c391c8043d
Reviewed-on: https://chromium-review.googlesource.com/419886
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

[modify] https://crrev.com/9e0a25e4e5fda04d5a7935de07311438ced53cfc/py/test/pytests/audio_loop/audio_loop.py
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/0f4e27ca484a382e5a633684512602a6353e5c0b

commit 0f4e27ca484a382e5a633684512602a6353e5c0b
Author: Earl Ou <shunhsingou@google.com>
Date: Tue Nov 29 07:59:57 2016

Add back looptest and tone_tests

Previous CL:381047 removes looptest and tone_tests. However, those
binaries may still required by some factory tests. Copy those files back so
people can still use them in the future.

BUG= chromium:630919 
TEST=emerge-elm audiotest

Change-Id: I05bd8262dccb76b80ff4323a3e86f308a75c799b
Reviewed-on: https://chromium-review.googlesource.com/414863
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
(cherry picked from commit edb7158a441a69d40a1176f5e12c5ce2d398a7e7)
Reviewed-on: https://chromium-review.googlesource.com/424488
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[add] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/test_tones.cc
[add] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/tone_generators.cc
[modify] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/module.mk
[add] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/libaudiodev.c
[add] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/include/alsa_client.h
[modify] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/Makefile
[add] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/looptest.c
[add] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/alsa_client.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/d446f98e2f2deba162a89f64d8eb48897608b740

commit d446f98e2f2deba162a89f64d8eb48897608b740
Author: Earl Ou <shunhsingou@google.com>
Date: Wed Nov 30 08:41:22 2016

audiofuntest: remove ParamConfig and reuse AudioFunTestConfig

Tools in audiotest directory always parse their own config in their own
main cc file. Also, there is no reason to write a config file
instead of using command args. Remove this unrequired class to simplify
this repo.

Also remove unrequired parameters in the program.

This CL also fixes the following coding style issue, and check with
cpplint.py:
1. Unify pointer declaration. Use 'type *name' instead of 'type* name'
   for consistency. Same logic applies for '&'.
2. Sort import.
3. Remove unnecessary namespace declaration.
4. Remove "using" statement in header.
5. Unify the format of #ifndef guard.
6. use c style print function instead of c++ style cout/cerr for consistency.

BUG= chromium:630919 
TEST=manually tested on elm, cpplint.py include/*.h src/*.cc

Change-Id: I0f17ed66a9e256c655ed024ee82524b8dc834b82
Reviewed-on: https://chromium-review.googlesource.com/415284
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
(cherry picked from commit 7ae955b16c3553921c1acd73fa47025be8e4a6cd)
Reviewed-on: https://chromium-review.googlesource.com/424489
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/test_tones.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/frame_generator.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/evaluator.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/cras_api_test.c
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/alsa_client.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/module.mk
[delete] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/include/param_config.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/common.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/frame_generator.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/looptest.c
[add] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/common.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/audiofuntest.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/evaluator.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/tone_generators.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/connector.cc
[add] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/CPPLINT.cfg
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/libaudiodev.c
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/libaudiodev.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/alsa_client.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/util.h
[delete] https://crrev.com/0f4e27ca484a382e5a633684512602a6353e5c0b/src/param_config.cc
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/src/loopback_latency.c
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/tone_generators.h
[modify] https://crrev.com/d446f98e2f2deba162a89f64d8eb48897608b740/include/connector.h
Project Member

Comment 25 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/421c03c3aeed977cc67ce2fa4e10f283a3d5311b

commit 421c03c3aeed977cc67ce2fa4e10f283a3d5311b
Author: Earl Ou <shunhsingou@google.com>
Date: Thu Dec 01 09:21:50 2016

Rename frame_generator to generator_player

We already have tone_generators.h that defines several type of wave
generators. The name frame_generator is confusing. What it actually does
is generating a wave, and writes the wave to the player client. To avoid
confusion, rename it into generator_player.

This CL also remove the redundant code in frame_generator, and using raw
bytes instead of 'frames' as the interface of player for better
efficiency and consistency with tone_generators.

Some of the duplicated code in common.h / utils.h is also removed.
SampleFormat is moved out as a separated file.

BUG= chromium:630919 
TEST=manually tested on elm.

Change-Id: I1679a49978092ca79b449b3cf31c64f7cc53de91
Reviewed-on: https://chromium-review.googlesource.com/415692
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>
(cherry picked from commit 06c1ad61d95e86b3e5bf88ba1813b7418548ec05)
Reviewed-on: https://chromium-review.googlesource.com/424491
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/evaluator.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/test_tones.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/audiofuntest.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/module.mk
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/binary_client.h
[delete] https://crrev.com/987f61310cfb44500b9a38b14dd363292c635650/src/frame_generator.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/alsa_client.h
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/common.h
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/evaluator.h
[add] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/sample_format.h
[delete] https://crrev.com/987f61310cfb44500b9a38b14dd363292c635650/include/frame_generator.h
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/tone_generators.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/Android.mk
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/tone_generators.h
[add] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/sample_format.cc
[add] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/generator_player.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/binary_client.cc
[modify] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/src/alsa_client.cc
[delete] https://crrev.com/987f61310cfb44500b9a38b14dd363292c635650/include/util.h
[add] https://crrev.com/421c03c3aeed977cc67ce2fa4e10f283a3d5311b/include/generator_player.h
Project Member

Comment 26 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/audiotest/+/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119

commit 844c1ed49a9b95a255a1b7dd3933b9ea5c68c119
Author: Earl Ou <shunhsingou@google.com>
Date: Wed Dec 14 07:34:51 2016

audiofuntest: use smart pointer when appropriate

BUG= chromium:630919 
TEST=manually on elm

Change-Id: Ic8f08d2b040cd2d12fd77fbf3ddf334158e2a24d
Reviewed-on: https://chromium-review.googlesource.com/419884
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
(cherry picked from commit 863d88d578a1f9a6936ff0defe91a31a04e8b1d9)
Reviewed-on: https://chromium-review.googlesource.com/425012
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>

[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/src/evaluator.cc
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/src/common.cc
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/include/alsa_client.h
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/include/evaluator.h
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/src/generator_player.cc
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/src/binary_client.cc
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/src/alsa_client.cc
[modify] https://crrev.com/844c1ed49a9b95a255a1b7dd3933b9ea5c68c119/include/generator_player.h
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 5 2017

Labels: merge-merged-factory-gru-9017.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/cd2e9cc62b4305ef7e27b6c19ef589f3cc2cd83e

commit cd2e9cc62b4305ef7e27b6c19ef589f3cc2cd83e
Author: Earl Ou <shunhsingou@google.com>
Date: Mon Jun 05 01:36:25 2017

CHERRY-PICK: audio_loop: update audiofuntest parameters

In CL:415284 we removed the config file for audiofuntest to keep things
clean. Update the pytest cooresponding to the change.

BUG= chromium:630919 
TEST=manually

Original Change-Id: Ia2281737072efbe6f52fb1c79db5d0c391c8043d
Original Reviewed-on: https://chromium-review.googlesource.com/419886
Commit-Ready: Shun-Hsing Ou <shunhsingou@chromium.org>
Tested-by: Shun-Hsing Ou <shunhsingou@chromium.org>
Reviewed-by: Shun-Hsing Ou <shunhsingou@chromium.org>

Change-Id: I2346493cc382d74b8787256f99f32a10dc3dd98f
Reviewed-on: https://chromium-review.googlesource.com/522487
Reviewed-by: Philip Chen <philipchen@chromium.org>
Commit-Queue: Loop Wu <Loop_Wu@asus.com>
Tested-by: Loop Wu <Loop_Wu@asus.com>

[modify] https://crrev.com/cd2e9cc62b4305ef7e27b6c19ef589f3cc2cd83e/py/test/pytests/audio_loop/audio_loop.py
►

Sign in to add a comment