New issue
Advanced search Search tips

Issue 630915 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 257235



Sign in to add a comment

Update AnimationEffect timing algorithms and names to match spec

Project Member Reported by alancutter@chromium.org, Jul 25 2016

Issue description

AnimationEffect::updateInheritedTime() and TimingCalculations.h have gotten out of sync with the language and naming used in the spec, we should resync to make staying up to date with spec changes easier.

https://w3c.github.io/web-animations/#core-animation-effect-calculations
 

Comment 1 by suzyh@chromium.org, Oct 5 2016

Labels: -Update-Quarterly Update-Monthly
Owner: ericwilligers@chromium.org
Status: Assigned (was: Available)

Comment 2 by suzyh@chromium.org, Oct 10 2016

Blocking: 257235
No progress.
No progress
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1103662b0e359249e7d9da1723bdea6b05a51fa4

commit 1103662b0e359249e7d9da1723bdea6b05a51fa4
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Aug 02 22:46:48 2018

Remove blink::Timing::playback_rate_

Outside of test code, this was only ever set to 1.

Bug: 630915
Change-Id: Ifd0e41e19f54287e9ba6faab44e336529b3d426d
Reviewed-on: https://chromium-review.googlesource.com/1159163
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580360}
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/animation_effect.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/animation_effect.h
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/animation_effect_test.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/animation_test.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/compositor_animations.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/compositor_animations_test.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/css/css_animations.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/keyframe_effect.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/keyframe_effect_test.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/timing.h
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/timing_calculations.h
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/timing_calculations_test.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/core/animation/timing_input_test.cc
[modify] https://crrev.com/1103662b0e359249e7d9da1723bdea6b05a51fa4/third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc

Sign in to add a comment