The old mojo-based Mus gpu code path lives in services/ui/gles2. This adds unnecessary complexity throughout Chrome and Mus at this point. We should delete this code.
Is this blocked on issue 623157 ?
Yes, added
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4628518ceaafa1f53bc0903dcf5fff3c61635ac commit d4628518ceaafa1f53bc0903dcf5fff3c61635ac Author: sadrul <sadrul@chromium.org> Date: Wed Jul 27 19:05:08 2016 services/ui: Remove deprecated gpu code Summary of changes: . Move RasterThreadHelper into the client lib, since it's used by mus clients (views). . Remove the --use-mojo-gpu-command-buffer-in-mus flag, which means chrome gpu command buffer is now used on Windows for mus. . Delete the rest of the code in services/ui/gles2, and OzoneGpuMemoryBuffer from services/ui/surfaces. BUG= 623157 , 630893 Review-Url: https://codereview.chromium.org/2176303002 Cr-Commit-Position: refs/heads/master@{#408207} [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/compositor/mus_browser_compositor_output_surface.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/BUILD.gn [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/gpu_service.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/gpu_service.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/switches.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/common/switches.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/BUILD.gn [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/DEPS [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/OWNERS [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver_manager.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_driver_manager.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_impl.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_impl.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_local.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_local.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_local_client.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_task_runner.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/command_buffer_task_runner.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gl_surface_adapter.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gl_surface_adapter.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_impl.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_impl.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_memory_tracker.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_memory_tracker.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_state.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/gpu_state.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/ozone_gpu_memory_buffer.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/gles2/ozone_gpu_memory_buffer.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/BUILD.gn [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/lib/gles2_context.cc [rename] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/lib/raster_thread_helper.cc [rename] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/public/cpp/raster_thread_helper.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/service.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/service.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/BUILD.gn [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/direct_output_surface_ozone.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/direct_output_surface_ozone.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/display_compositor.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/display_compositor.h [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc [delete] https://crrev.com/0ac5c5e6651b3e4c6217aaf629c1442bb9baf733/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/surfaces_context_provider.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/surfaces/surfaces_context_provider.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/BUILD.gn [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/frame_generator.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/frame_generator.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/platform_display.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/platform_display_init_params.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/platform_display_init_params.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/services/ui/ws/window_tree_host_factory.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/BUILD.gn [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/native_widget_mus.h [modify] https://crrev.com/d4628518ceaafa1f53bc0903dcf5fff3c61635ac/ui/views/mus/surface_context_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225 commit 5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225 Author: penghuang <penghuang@chromium.org> Date: Wed Jul 27 20:41:46 2016 services/ui: Remove unused connector argument BUG= 630893 Review-Url: https://codereview.chromium.org/2187103002 Cr-Commit-Position: refs/heads/master@{#408230} [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ash/mus/bridge/wm_root_window_controller_mus.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ash/touch_hud/mus/touch_hud_application.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/content/renderer/mus/render_widget_mus_connection.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/mash/login/login.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/mash/screenlock/screenlock.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/navigation/view_impl.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/demo/mus_demo.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/public/cpp/bitmap_uploader.h [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/public/cpp/context_provider.h [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/public/cpp/gles2_context.h [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/public/cpp/lib/bitmap_uploader.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/public/cpp/lib/context_provider.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/services/ui/public/cpp/lib/gles2_context.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/native_widget_mus.h [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/surface_binding.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/surface_binding.h [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/surface_context_factory.cc [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/surface_context_factory.h [modify] https://crrev.com/5db9f0d6b83c2f3fbe2550c6840a8ac7f533d225/ui/views/mus/window_manager_connection.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f99035fbb67293836944993268f0357ad3d65a4d commit f99035fbb67293836944993268f0357ad3d65a4d Author: sadrul <sadrul@chromium.org> Date: Fri Jul 29 16:08:59 2016 services/ui: Revert CLs that broke Windows. The new GPU code path does not seem to work correctly on Windows yet (everything is black). So restore the deprecated path. Revert "services/ui: Remove deprecated gpu code" crrev.com/408207 Revert "services/ui: Remove unused connector argument" crrev.com/408230 BUG= 623157 , 630893 TBR=ben@, piman@, penghuang@ Review-Url: https://codereview.chromium.org/2194893002 Cr-Commit-Position: refs/heads/master@{#408648} [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/mus/bridge/wm_root_window_controller_mus.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ash/touch_hud/mus/touch_hud_application.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/compositor/mus_browser_compositor_output_surface.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/content/renderer/mus/render_widget_mus_connection.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/mash/login/login.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/mash/screenlock/screenlock.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/navigation/view_impl.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/BUILD.gn [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/gpu_service.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/gpu_service.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/switches.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/common/switches.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/demo/mus_demo.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/BUILD.gn [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/DEPS [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/OWNERS [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver_manager.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_driver_manager.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_impl.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_impl.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_local_client.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_task_runner.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/command_buffer_task_runner.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gl_surface_adapter.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gl_surface_adapter.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_impl.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_impl.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_memory_tracker.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_memory_tracker.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_state.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/gpu_state.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/ozone_gpu_memory_buffer.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/ozone_gpu_memory_buffer.h [rename] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/raster_thread_helper.cc [rename] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/gles2/raster_thread_helper.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/BUILD.gn [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/bitmap_uploader.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/context_provider.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/gles2_context.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/bitmap_uploader.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/context_provider.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/public/cpp/lib/gles2_context.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/service.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/service.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/BUILD.gn [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/direct_output_surface_ozone.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/direct_output_surface_ozone.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/display_compositor.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/display_compositor.h [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc [add] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/surfaces_context_provider.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/surfaces/surfaces_context_provider.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/BUILD.gn [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display_init_params.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/platform_display_init_params.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/services/ui/ws/window_tree_host_factory.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/BUILD.gn [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/native_widget_mus.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_binding.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_binding.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_context_factory.cc [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/surface_context_factory.h [modify] https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d/ui/views/mus/window_manager_connection.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534 commit e53bd8b6b93acc586ac72c445a5c4f1ff7f32534 Author: sadrul <sadrul@chromium.org> Date: Fri Jul 29 19:16:15 2016 Revert of services/ui: Revert CLs that broke Windows. (patchset #2 id:20001 of https://codereview.chromium.org/2194893002/ ) Reason for revert: crrev.com/408695 fixes the issue. So we can reland these CLs. Original issue's description: > services/ui: Revert CLs that broke Windows. > > The new GPU code path does not seem to work correctly on Windows yet > (everything is black). So restore the deprecated path. > > Revert "services/ui: Remove deprecated gpu code" crrev.com/408207 > Revert "services/ui: Remove unused connector argument" crrev.com/408230 > > BUG= 623157 , 630893 > TBR=ben@, piman@, penghuang@ > > Committed: https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d > Cr-Commit-Position: refs/heads/master@{#408648} TBR=ben@chromium.org,piman@chromium.org,penghuang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 623157 , 630893 Review-Url: https://codereview.chromium.org/2196503003 Cr-Commit-Position: refs/heads/master@{#408710} [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ash/mus/bridge/wm_root_window_controller_mus.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ash/mus/non_client_frame_controller.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ash/touch_hud/mus/touch_hud_application.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/chrome/browser/ui/views/frame/browser_frame_mus.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/compositor/gpu_process_transport_factory.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/compositor/mus_browser_compositor_output_surface.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/content/renderer/mus/render_widget_mus_connection.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/mash/login/login.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/mash/screenlock/screenlock.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/navigation/view_impl.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/BUILD.gn [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/gpu_service.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/gpu_service.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/switches.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/common/switches.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/demo/mus_demo.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/BUILD.gn [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/DEPS [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/OWNERS [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver_manager.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_driver_manager.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_impl.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_impl.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_local.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_local.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_local_client.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_task_runner.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/command_buffer_task_runner.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gl_surface_adapter.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gl_surface_adapter.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_impl.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_impl.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_memory_tracker.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_memory_tracker.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_state.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/gpu_state.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/ozone_gpu_memory_buffer.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/gles2/ozone_gpu_memory_buffer.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/BUILD.gn [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/bitmap_uploader.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/context_provider.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/gles2_context.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/bitmap_uploader.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/context_provider.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/gles2_context.cc [rename] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/lib/raster_thread_helper.cc [rename] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/public/cpp/raster_thread_helper.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/service.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/service.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/BUILD.gn [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/direct_output_surface_ozone.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/direct_output_surface_ozone.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/display_compositor.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/display_compositor.h [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc [delete] https://crrev.com/b4a38edc75149162fcbdf01e42d5411cf8e72520/services/ui/surfaces/ozone_gpu_memory_buffer_manager.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/surfaces_context_provider.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/surfaces/surfaces_context_provider.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/BUILD.gn [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/frame_generator.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/frame_generator.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/frame_generator_unittest.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/platform_display.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/platform_display_init_params.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/platform_display_init_params.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/services/ui/ws/window_tree_host_factory.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/BUILD.gn [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/native_widget_mus.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/native_widget_mus.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_binding.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_binding.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_context_factory.cc [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/surface_context_factory.h [modify] https://crrev.com/e53bd8b6b93acc586ac72c445a5c4f1ff7f32534/ui/views/mus/window_manager_connection.cc
Comment 1 by sadrul@chromium.org
, Jul 25 2016