Issue 630891 link

Starred by 2 users

Issue metadata

Status:	WontFix
Owner:	serg...@chromium.org
Closed:	Jul 2016
Cc:	█ shey...@chromium.org seanmccullough@chromium.org zhangtiff@chromium.org
Components:	Infra>Sheriffing>SheriffOMatic
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	----
Milestone-SoMLegacy

Measure how many requests flakiness pipeline makes to monorail

Project Member Reported by serg...@chromium.org, Jul 24 2016

Issue description

We already have monitoring for chromium-try-flakes app and it reports each request to metric /chrome/infra/flakiness_pipeline/issue_tracker_requests via ts_mon: http://shortn/_RkEYwTy1xy. CL that added them: https://codereview.chromium.org/2150983004/. That same CL added counting of requests from builder_alerts, which is likely making many more requests. Unfortunately, reporting does not work for some reason and only requests from chromium-try-flakes are counted. I am going to add more logging in a follow-up CL to understand why.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a3aa5da1759aa7dc335e4ced86b1b1de4ea2cf11

commit a3aa5da1759aa7dc335e4ced86b1b1de4ea2cf11
Author: sergiyb <sergiyb@chromium.org>
Date: Sun Jul 24 18:01:56 2016

Add more logging to builder_alerts to see why metrics are not reported

TBR=tandrii@chromium.org
BUG= 630891 

Review-Url: https://codereview.chromium.org/2174233002

[modify] https://crrev.com/a3aa5da1759aa7dc335e4ced86b1b1de4ea2cf11/infra/services/builder_alerts/__main__.py
[modify] https://crrev.com/a3aa5da1759aa7dc335e4ced86b1b1de4ea2cf11/infra/services/builder_alerts/crbug_issues.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 24 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/dd3e7ea68ada60512b88cac61a62da25f4c63876

commit dd3e7ea68ada60512b88cac61a62da25f4c63876
Author: sergiyb <sergiyb@google.com>
Date: Sun Jul 24 19:16:08 2016

Comment 3 by estaab@chromium.org, Jul 25 2016

Components: -Infra Infra>Sheriffing>SheriffOMatic

Builder alerts is a SoM component, right? Please move this if I'm wrong.

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/e3b2904c595be09894eae1fdfdfef43712d2fe07

commit e3b2904c595be09894eae1fdfdfef43712d2fe07
Author: sergiyb <sergiyb@chromium.org>
Date: Mon Jul 25 13:22:52 2016

Add more logging to builder_alerts

TBR=tandrii@chromium.org
BUG= 630891 

Review-Url: https://codereview.chromium.org/2177873002

[modify] https://crrev.com/e3b2904c595be09894eae1fdfdfef43712d2fe07/infra/services/builder_alerts/alert_builder.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/50a73d5ad8191b2b8dcc2d66926f432db2d2a090

commit 50a73d5ad8191b2b8dcc2d66926f432db2d2a090
Author: sergiyb <sergiyb@chromium.org>
Date: Mon Jul 25 18:30:53 2016

Add ts_mon defaults in builder_alrets

R=sergeyberezin@chromium.org
BUG= 630891 

Review-Url: https://codereview.chromium.org/2183453002

[modify] https://crrev.com/50a73d5ad8191b2b8dcc2d66926f432db2d2a090/infra/services/builder_alerts/__main__.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/09f9cb9556e8d4de5e0103803324162f8387fb81

commit 09f9cb9556e8d4de5e0103803324162f8387fb81
Author: sergiyb <sergiyb@chromium.org>
Date: Mon Jul 25 23:18:12 2016

Log when leaving main and list remaining threads in builder_alerts

TBR=tandrii@chromium.org
BUG= 630891 

Review-Url: https://codereview.chromium.org/2176403002

[modify] https://crrev.com/09f9cb9556e8d4de5e0103803324162f8387fb81/infra/services/builder_alerts/__main__.py
[modify] https://crrev.com/09f9cb9556e8d4de5e0103803324162f8387fb81/infra/services/builder_alerts/alert_builder.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/634ed89a1ffc8811efcac46d0078bedf3a91cde6

commit 634ed89a1ffc8811efcac46d0078bedf3a91cde6
Author: sergiyb <sergiyb@chromium.org>
Date: Tue Jul 26 14:28:33 2016

Call sys.exit after logging threads

R=tandrii@chromium.org
BUG= 630891 

Review-Url: https://codereview.chromium.org/2185563002

[modify] https://crrev.com/634ed89a1ffc8811efcac46d0078bedf3a91cde6/infra/services/builder_alerts/__main__.py

Comment 8 by seanmccullough@chromium.org, Jul 26 2016

Labels: Milestone-SoMLegacy

Comment 9 by serg...@chromium.org, Jul 27 2016

Turns out Sheng was working on something similar: http://shortn/_jVr99QTgzy. I am going to remove all code that I have added to builder-alerts and chromium-try-flakes and kill the metrics.

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a89f0504f5d1d0418a915d650aa171f85de497f6

commit a89f0504f5d1d0418a915d650aa171f85de497f6
Author: sergiyb <sergiyb@chromium.org>
Date: Wed Jul 27 10:11:03 2016

Remove logging and metrics from builder alerts code

R=tandrii@chromium.org
BUG= 630891 

Review-Url: https://codereview.chromium.org/2186673003

[modify] https://crrev.com/a89f0504f5d1d0418a915d650aa171f85de497f6/appengine/chromium_try_flakes/issue_tracker/issue_tracker_api.py
[modify] https://crrev.com/a89f0504f5d1d0418a915d650aa171f85de497f6/infra/services/builder_alerts/__main__.py
[modify] https://crrev.com/a89f0504f5d1d0418a915d650aa171f85de497f6/infra/services/builder_alerts/alert_builder.py
[modify] https://crrev.com/a89f0504f5d1d0418a915d650aa171f85de497f6/infra/services/builder_alerts/crbug_issues.py

Comment 11 by serg...@chromium.org, Jul 28 2016

Status: WontFix (was: Started)

►

Issue 630891 link

Issue metadata

Measure how many requests flakiness pipeline makes to monorail

Issue description

Comment 1 by bugdroid1@chromium.org, Jul 24 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Jul 24 2016

Comment 2 Deleted

Comment 3 by estaab@chromium.org, Jul 25 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jul 25 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jul 25 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jul 25 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Jul 26 2016

Comment 7 Deleted

Comment 8 by seanmccullough@chromium.org, Jul 26 2016

Comment 8 Deleted

Comment 9 by serg...@chromium.org, Jul 27 2016

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jul 27 2016

Comment 10 Deleted

Comment 11 by serg...@chromium.org, Jul 28 2016

Comment 11 Deleted

Sign in to add a comment