WebGL test conformance/textures/misc/texture-upload-size Flaky on Windows |
||||||||
Issue descriptionPossibly just NVIDIA hardware, but maybe affects all Windows. Seems to be possibly in video playback? One failing build: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/26589 [2608:2864:0722/044654:FATAL:video_renderer_impl.cc(304)] Check failed: buffering_state_ == BUFFERING_HAVE_NOTHING (1 vs. 0) Backtrace: base::debug::StackTrace::StackTrace [0x6991D8E7+23] logging::LogMessage::~LogMessage [0x698C6601+49] media::VideoRendererImpl::OnTimeStateChanged [0x6AA129EA+180] media::RendererImpl::StartPlayback [0x6AA10F35+410] media::RendererImpl::OnBufferingStateChange [0x6AA0F68D+1030] media::RendererImpl::RendererClientInternal::OnBufferingStateChange [0x6AA0F283+17] media::AudioRendererImpl::OnBufferingStateChange [0x6AA0BE8A+97] base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall media::WebMediaPlayerImpl::*const &)(enum media::PipelineStatus),base::WeakPtr<media::WebMediaPlayerImpl> const &,enum media::PipelineStatus> [0x6A5D8B39+43] base::internal::Invoker<base::internal::BindState<void (__thiscall media::WebMediaPlayerImpl::*)(enum media::BufferingState),base::WeakPtr<media::WebMediaPlayerImpl>,enum media::BufferingState>,void __cdecl(void)>::Run [0x6A6EF998+23] base::debug::TaskAnnotator::RunTask [0x69923A87+247] base::MessageLoop::RunTask [0x698CFB2B+1211] base::MessageLoop::DoWork [0x698CEEEE+606] base::MessagePumpDefault::Run [0x699248E8+424] base::MessageLoop::RunHandler [0x698CF667+103] Full log attached.
,
Aug 2 2016
Dale, could you find someone to investigate the above assertion failure?
,
Aug 2 2016
I'll take a look, thanks!
,
Sep 23 2016
,
Sep 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdde31284d8d1fb76451c55e6a579b34f5aa35f1 commit fdde31284d8d1fb76451c55e6a579b34f5aa35f1 Author: dalecurtis <dalecurtis@chromium.org> Date: Sat Sep 24 01:25:45 2016 Transition to have nothing if background rendering evicts all frames. If we're background rendering it's possible for us to expire all frames if the audio renderer advances too far ahead. In this case we need to transition into the HAVE_NOTHING state so the Renderer is aware we don't have frames. It seems possible for this bug to permanently hang video playback in release builds since the renderer has no idea what state we're in and the video renderer will never transition to have enough. BUG= 630860 TEST=new unittest. Review-Url: https://codereview.chromium.org/2363983003 Cr-Commit-Position: refs/heads/master@{#420808} [modify] https://crrev.com/fdde31284d8d1fb76451c55e6a579b34f5aa35f1/media/renderers/video_renderer_impl.cc [modify] https://crrev.com/fdde31284d8d1fb76451c55e6a579b34f5aa35f1/media/renderers/video_renderer_impl.h [modify] https://crrev.com/fdde31284d8d1fb76451c55e6a579b34f5aa35f1/media/renderers/video_renderer_impl_unittest.cc
,
Sep 25 2016
Thank you Dale for fixing this and for adding a separate unit test!
,
Sep 27 2016
No problem, sorry it fell off the radar. I looked through the bots and didn't see any more instances. Given the seeming severity (though we have no reported cases), going to merge to M-54 too.
,
Sep 27 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 27 2016
Merged, but isn't showing up for some reason.
,
Sep 27 2016
Confirming that Cl is merged in M54 - https://chromium.googlesource.com/chromium/src.git/+/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698 If there is no pending work please remove Merge-Approved-54 and add merge-merged-2840.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698 commit 1271a3e84bbf2d53341ba16c9a5ec501ca1d0698 Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue Sep 27 20:02:18 2016 Merge M54: "Transition to have nothing if background rendering evicts all frames." If we're background rendering it's possible for us to expire all frames if the audio renderer advances too far ahead. In this case we need to transition into the HAVE_NOTHING state so the Renderer is aware we don't have frames. It seems possible for this bug to permanently hang video playback in release builds since the renderer has no idea what state we're in and the video renderer will never transition to have enough. BUG= 630860 TEST=new unittest. Review-Url: https://codereview.chromium.org/2363983003 Cr-Commit-Position: refs/heads/master@{#420808} (cherry picked from commit fdde31284d8d1fb76451c55e6a579b34f5aa35f1) Review URL: https://codereview.chromium.org/2371833005 . Cr-Commit-Position: refs/branch-heads/2840@{#549} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698/media/renderers/video_renderer_impl.cc [modify] https://crrev.com/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698/media/renderers/video_renderer_impl.h [modify] https://crrev.com/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698/media/renderers/video_renderer_impl_unittest.cc
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/370702c23c53ee244165be762667d6c8f71e81ce commit 370702c23c53ee244165be762667d6c8f71e81ce Author: Dale Curtis <dalecurtis@chromium.org> Date: Thu Sep 29 23:44:03 2016 Disable flaky VideoRendererImpl test on M54 branch. Test is not flaky on ToT, but M54 builds seem to lack some test upgrades that are on ToT, so disable for here. BUG= 630860 , 651015 (cherry picked from commit d3d389319c771c3ba80a0fa0c260979c31218cb0) Review URL: https://codereview.chromium.org/2378773012 . Cr-Commit-Position: refs/branch-heads/2840@{#592} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/370702c23c53ee244165be762667d6c8f71e81ce/media/renderers/video_renderer_impl_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698 commit 1271a3e84bbf2d53341ba16c9a5ec501ca1d0698 Author: Dale Curtis <dalecurtis@chromium.org> Date: Tue Sep 27 20:02:18 2016 Merge M54: "Transition to have nothing if background rendering evicts all frames." If we're background rendering it's possible for us to expire all frames if the audio renderer advances too far ahead. In this case we need to transition into the HAVE_NOTHING state so the Renderer is aware we don't have frames. It seems possible for this bug to permanently hang video playback in release builds since the renderer has no idea what state we're in and the video renderer will never transition to have enough. BUG= 630860 TEST=new unittest. Review-Url: https://codereview.chromium.org/2363983003 Cr-Commit-Position: refs/heads/master@{#420808} (cherry picked from commit fdde31284d8d1fb76451c55e6a579b34f5aa35f1) Review URL: https://codereview.chromium.org/2371833005 . Cr-Commit-Position: refs/branch-heads/2840@{#549} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698/media/renderers/video_renderer_impl.cc [modify] https://crrev.com/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698/media/renderers/video_renderer_impl.h [modify] https://crrev.com/1271a3e84bbf2d53341ba16c9a5ec501ca1d0698/media/renderers/video_renderer_impl_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/370702c23c53ee244165be762667d6c8f71e81ce commit 370702c23c53ee244165be762667d6c8f71e81ce Author: Dale Curtis <dalecurtis@chromium.org> Date: Thu Sep 29 23:44:03 2016 Disable flaky VideoRendererImpl test on M54 branch. Test is not flaky on ToT, but M54 builds seem to lack some test upgrades that are on ToT, so disable for here. BUG= 630860 , 651015 (cherry picked from commit d3d389319c771c3ba80a0fa0c260979c31218cb0) Review URL: https://codereview.chromium.org/2378773012 . Cr-Commit-Position: refs/branch-heads/2840@{#592} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/370702c23c53ee244165be762667d6c8f71e81ce/media/renderers/video_renderer_impl_unittest.cc
,
Jun 20 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 24 2016