New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630852 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Negative lookahead not respected in Network panel

Reported by gjpy...@gmail.com, Jul 23 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Steps to reproduce the problem:
1. Input the following regex expression ^((?!foo).)*$ in the filter panel
2. Check Regex option
3. View panel results

What is the expected behavior?
The panel results should exclude any network requests that contain "foo". 

What went wrong?
The panel only filters if both the Name and the Path contain the "foo" string.

Did this work before? No 

Chrome version: 51.0.2704.103  Channel: n/a
OS Version: OS X 10.11.5
Flash Version: Shockwave Flash 22.0 r0

Similar issue to https://bugs.chromium.org/p/chromium/issues/detail?id=375633

I am upload a fix for this right now.
 

Comment 1 by gjpy...@gmail.com, Jul 23 2016

Submitted fix: https://codereview.chromium.org/2180743002
Cc: paulir...@chromium.org pfeldman@chromium.org
Labels: M-54 Needs-Feedback
Thanks for the report, could you please help provide more details to verify the issue from TE end if it can be verified.

Untriaged and cced the reviewers to review and update further.

Comment 3 by gjpy...@gmail.com, Jul 25 2016

Hi Durga, I have add 3 screenshots with descriptions for the scenarios, which should clarify that the issue exists. http://imgur.com/a/nA2OB. I can confirm the issue doesn't exist for me after applying my fix locally.

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 25 2016

Labels: -Needs-Feedback Needs-Review
Owner: durga.behera@chromium.org
Thank you for providing more feedback. Adding requester "durga.behera@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by gjpy...@gmail.com, Aug 1 2016

Does anyone have an update on this? Iv'e not heard anything regarding a review of my pull request, presumably as it's Unconfirmed still? 
Components: -Platform>DevTools Platform>DevTools>Network
Labels: -Needs-Review Needs-Feedback
Owner: ----
Status: Untriaged (was: Unconfirmed)
paulirish@/pfeldman@ : Gentle ing..! Could you please review the fix and update further on this. 

Untriged so as to addressed further.
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Needs-Feedback
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c002b266f83798e8c652a641f74b381f7fb82171

commit c002b266f83798e8c652a641f74b381f7fb82171
Author: gjpyzer <gjpyzer@gmail.com>
Date: Thu Aug 11 03:34:59 2016

[Devtools] Filtering in the Network panel as ORing two regex tests breaks

Fixed regex filtering in the Network panel as ORing two regex tests breaks
in some situatons, such as negative lookaheads. For example, if you are to
filter out "foo", and you have the request Name property as "bob.js" and the
Path as "/path/foo", then the regex is true for Name and false for Path.
This results in: true || false === true. It would only filter out if both
contained "foo" in them.

We now concatenate the Path and Name together, with a "/" to join. This is
also more intuitive, as it will allow first character matching on Path.

BUG= 630852 

Review-Url: https://codereview.chromium.org/2180743002
Cr-Commit-Position: refs/heads/master@{#411252}

[modify] https://crrev.com/c002b266f83798e8c652a641f74b381f7fb82171/AUTHORS
[modify] https://crrev.com/c002b266f83798e8c652a641f74b381f7fb82171/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Comment 11 by ajha@chromium.org, Aug 30 2016

Cc: ajha@chromium.org
Labels: Needs-Feedback
Could anyone please attach any test page for the verification of this Fix.

Thanks in advance!
Status: Fixed (was: Assigned)
I added tests for this patch here: https://codereview.chromium.org/2253013007/
Labels: -Needs-Feedback
Status: Verified (was: Fixed)
Verified the fix as per in steps in #0. Confirmed "foo" is filtered in reg expression - ^((?!foo).)*$.

OS : Mac
Chrome Version : 54.0.2840.6
This is not working anymore, in Chrome 70

Sign in to add a comment