New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630837 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 624590



Sign in to add a comment

move components/page_load_metrics to chrome/

Project Member Reported by bmcquade@chromium.org, Jul 23 2016

Issue description

jam requested that we move this component to chrome/. Looks like a straightforward migration, so we should probably just do it. I'll take a shot at it.
 
Blocking: 624590
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f43370cfc7a963d2b757936fae875dedae2aff0

commit 9f43370cfc7a963d2b757936fae875dedae2aff0
Author: bmcquade <bmcquade@chromium.org>
Date: Tue Jul 26 23:33:50 2016

Migrate page_load_metrics out of components.

There's an effort underway to trim down components
(https://bugs.chromium.org/p/chromium/issues/detail?id=624590).

As part of this effort, we're moving the page_load_metrics component
to chrome/.

This change moves code out of components like so:
components/page_load_metrics/browser -> chrome/browser/page_load_metrics
components/page_load_metrics/renderer -> chrome/renderer/page_load_metrics
components/page_load_metrics/common -> chrome/common/page_load_metrics

This change does not include any logic changes - it just moves code
to its new home, updates includes and build dependencies, etc.

BUG= 630837 

Review-Url: https://codereview.chromium.org/2177743002
Cr-Commit-Position: refs/heads/master@{#407966}

[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/WATCHLISTS
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/chrome/browser/page_load_metrics/DEPS
[add] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/README
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/google_captcha_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/page_load_metrics_initialize.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/page_load_metrics_util.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/page_load_metrics/page_load_metrics_util.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/browser/ui/DEPS
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/chrome_browser.gypi
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/chrome_common.gypi
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/chrome_renderer.gypi
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/common/common_message_generator.h
[add] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/common/page_load_metrics/OWNERS
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/common/page_load_metrics/page_load_metrics_messages.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/common/page_load_metrics/page_load_timing.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/common/page_load_metrics/page_load_timing.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/BUILD.gn
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/DEPS
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/OWNERS
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/chrome_content_renderer_client.cc
[add] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/OWNERS
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
[rename] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/components/BUILD.gn
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/components/OWNERS
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/components/components.gyp
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/components/components_tests.gyp
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/DEPS
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/OWNERS
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/README
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/browser/BUILD.gn
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/browser/DEPS
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/common/BUILD.gn
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/common/page_load_metrics_messages.cc
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/renderer/BUILD.gn
[delete] https://crrev.com/65e6755e90d7f61c9e5d91c6cf7082a7b4cc9249/components/page_load_metrics/renderer/DEPS
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/tools/ipc_fuzzer/message_lib/BUILD.gn
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/tools/ipc_fuzzer/message_lib/DEPS
[add] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/tools/ipc_fuzzer/message_lib/OWNERS
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/tools/ipc_fuzzer/message_lib/all_messages.h
[modify] https://crrev.com/9f43370cfc7a963d2b757936fae875dedae2aff0/tools/ipc_fuzzer/message_lib/message_lib.gyp

Status: Fixed (was: Assigned)

Sign in to add a comment