IPCChannelMojoTest.SendFailWithPendingMessages is racy |
||
Issue descriptionThere's no guarantee that the Channel will receive an error before it's connected. The test seems to assume there is such a guarantee.
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c23d4643869946d5690720993d91955a26668f9 commit 8c23d4643869946d5690720993d91955a26668f9 Author: rockot <rockot@chromium.org> Date: Mon Jul 25 17:33:04 2016 Re-enable IPCChannelMojoTest.SendFailWithPendingMessages Simple fix, there's no need to quit the message loop on channel connection. If the expected error isn't encountered the test will hang. This seems sufficient and is not racy. BUG= 630831 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2175113002 Cr-Commit-Position: refs/heads/master@{#407503} [modify] https://crrev.com/8c23d4643869946d5690720993d91955a26668f9/ipc/ipc_channel_mojo_unittest.cc
,
Jul 25 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 23 2016