New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630831 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IPCChannelMojoTest.SendFailWithPendingMessages is racy

Project Member Reported by roc...@chromium.org, Jul 23 2016

Issue description

There's no guarantee that the Channel will receive an error before it's connected. The test seems to assume there is such a guarantee.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d582d02fb3e2a23d882c00072c601cb1781bef3

commit 7d582d02fb3e2a23d882c00072c601cb1781bef3
Author: rockot <rockot@chromium.org>
Date: Sat Jul 23 12:50:02 2016

Disable IPCChannelMojoTest.SendFailWithPendingMessages

It's flaky and needs to be fixed. Disabling for now to
green some bots where the flake has recently intensified.

BUG= 630831 
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2173323002
Cr-Commit-Position: refs/heads/master@{#407363}

[modify] https://crrev.com/7d582d02fb3e2a23d882c00072c601cb1781bef3/ipc/ipc_channel_mojo_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c23d4643869946d5690720993d91955a26668f9

commit 8c23d4643869946d5690720993d91955a26668f9
Author: rockot <rockot@chromium.org>
Date: Mon Jul 25 17:33:04 2016

Re-enable IPCChannelMojoTest.SendFailWithPendingMessages

Simple fix, there's no need to quit the message loop on channel
connection. If the expected error isn't encountered the test
will hang. This seems sufficient and is not racy.

BUG= 630831 
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2175113002
Cr-Commit-Position: refs/heads/master@{#407503}

[modify] https://crrev.com/8c23d4643869946d5690720993d91955a26668f9/ipc/ipc_channel_mojo_unittest.cc

Comment 3 by roc...@chromium.org, Jul 25 2016

Status: Fixed (was: Started)

Sign in to add a comment