New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630824 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in sse41::blit_row_s32a_opaque

Project Member Reported by ClusterFuzz, Jul 23 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5130952057815040

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sse41::blit_row_s32a_opaque
  Sprite_D32_S32::blitRect
  SkScan::FillIRect
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=401651:401798

Minimized Testcase (0.47 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97yzmiY5Mp1gB6ysaOOhH2is1vZ8rg14z25Qin87Yg4dHfeptn5UhlCpujZWSKkrpySM2bmaKaJZ5T64XFXkBjNskABxsP5L0e5RFXe4zhquz0PabwOieaMqBG1PMT_PwhpBwz77QYzsWPT_ZX7phhsC8O8jA?testcase_id=5130952057815040

Filer: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: caryclark@chromium.org reed@chromium.org
Components: Internals>Skia
Labels: Pri-1
Owner: senorblanco@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 23 2016

Labels: M-53
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 23 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 24 2016

Labels: -Security_Impact-Head Security_Impact-Beta
Cc: -reed@chromium.org senorblanco@chromium.org enne@chromium.org
Owner: reed@chromium.org
I don't see anything obvious in the regression range, and I have no commits there AFAICT. The only major thing I can see from the Chrome side is enne@'s switch to --enable-begin-frame-scheduling.

Assigning to reed@ for delegation / triage.

Comment 6 by reed@chromium.org, Jul 25 2016

Cc: fmalita@chromium.org mtklein@chromium.org
Owner: reed@google.com
Status: WontFix (was: Assigned)
The failure here ( Uninitialized bytes in __msan_check_mem_is_initialized at offset 0 inside [0x7efa7f668000, 992) ) is reminding us that sse41::blit_row_s32a_opaque() requires its src array to be initialized.  Whatever image we're blitting here is not marked as fully initialized by MSAN.

This is also harmless at this level of the stack... despite the panic from MSAN if it were to branch on them, blit_row_s32a_opaque() will never behave badly even when given uninitialized inputs.  But it does perhaps indicate a problem with whatever's created that image.
Project Member

Comment 8 by ClusterFuzz, Jul 31 2016

ClusterFuzz has detected this issue as fixed in range 408734:408781.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5130952057815040

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sse41::blit_row_s32a_opaque
  Sprite_D32_S32::blitRect
  SkScan::FillIRect
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=401651:401798
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=408734:408781

Minimized Testcase (0.47 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97yzmiY5Mp1gB6ysaOOhH2is1vZ8rg14z25Qin87Yg4dHfeptn5UhlCpujZWSKkrpySM2bmaKaJZ5T64XFXkBjNskABxsP5L0e5RFXe4zhquz0PabwOieaMqBG1PMT_PwhpBwz77QYzsWPT_ZX7phhsC8O8jA?testcase_id=5130952057815040

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 9 by mmoroz@chromium.org, Aug 16 2016

Status: Available (was: WontFix)
Re-opening just for a minute.
Project Member

Comment 10 by ClusterFuzz, Aug 16 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5667112511340544

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sse41::blit_row_s32a_opaque
  Sprite_D32_S32::blitRect
  SkScan::FillIRect
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=406944:407004

Minimized Testcase (0.47 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97UWz3MGBEq3vx7NMfKLgt4hpuTJK11V5N8o7w6Ul7HePx9uwpMIVHK3atkupeL2nEjP0h0GwNdEyv-ahDZcdyDSd8wzifTQR5pZQucZj0SO_OSsEIdMxubbaZbvqv04g4toi0ejXD9ggHx53Fe02y_BLKeLQ?testcase_id=5667112511340544

Issue manually filed by: mmoroz

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
Status: WontFix (was: Available)
Project Member

Comment 12 by ClusterFuzz, Sep 14 2016

ClusterFuzz has detected this issue as fixed in range 418377:418438.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5667112511340544

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sse41::blit_row_s32a_opaque
  Sprite_D32_S32::blitRect
  SkScan::FillIRect
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=406944:407004
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_msan_chrome&range=418377:418438

Minimized Testcase (0.47 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97UWz3MGBEq3vx7NMfKLgt4hpuTJK11V5N8o7w6Ul7HePx9uwpMIVHK3atkupeL2nEjP0h0GwNdEyv-ahDZcdyDSd8wzifTQR5pZQucZj0SO_OSsEIdMxubbaZbvqv04g4toi0ejXD9ggHx53Fe02y_BLKeLQ?testcase_id=5667112511340544

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment