New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 630823 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

FindIt breakages

Project Member Reported by infe...@chromium.org, Jul 23 2016

Issue description

https://cluster-fuzz.appspot.com/testcase?key=5130952057815040

Analysis of failed component others is not supported by Findit.

Suspected Project: others

How are you monitoring the results of your changes, I have seen ton of breakages recently with FindIt.
 
Labels: -Pri-1 Pri-0
Also this - https://cluster-fuzz.appspot.com/testcase?key=5078527401787392

Sharu, please take a look asap.
Sure, let me look into it.
This is because when we cannot find a dep path match for a file path, we return default value 'others' instead of 'chromium'. It's used to be fine, however recently there are a lot of cases where the file paths are like 'third_party/...', 'cc/...' instead of 'src/third_party/...', 'src/cc'

Set the default value to 'src/', 'chromium' can solve this.

Sorry, since I didn't make any functional change in clusterfuzz for quite a while and I am busy with developing features of findit appengine, so I am not actively monitoring the results of findit for clusterfuzz.

Comment 4 by aarya@google.com, Jul 25 2016

Cc: manoranj...@chromium.org
That is a bad hack to rely on in the first place. Recent sanitizer changes removed src/, we should find some other proper way to do this. Can you ask around with fellow TE which do ClusterFUzz triage on why they didn't notice this. +cc Manu expliticly.
There is better way to do that(it's doing ok from the fracas crash results monitoring), actually when I rewrite this part in findit appengine (already integrated with Fracas, will be integrated with clusterfuzz as well), I changed the clusterfuzz method to be the same.

The fix cl is as below:
https://chromereviews.googleplex.com/476097013/
Status: Fixed (was: Assigned)
New version deployed, the fix works :)

Sign in to add a comment