Both Async Load (bug 605703) and Download of pages depend on integration with Download UI. This issue tracks progress of it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68cf753deab115193dac19ba10aacf454f4641f0 commit 68cf753deab115193dac19ba10aacf454f4641f0 Author: fgorski <fgorski@chromium.org> Date: Tue Jul 26 21:16:33 2016 Offline Page download bridge * This creates a stub of the bridge, which is not yet wired to the back-end. * It also provides Java side tests for the bridge functionality. BUG= 630817 Review-Url: https://codereview.chromium.org/2171963002 Cr-Commit-Position: refs/heads/master@{#407916} [add] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [add] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java [modify] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/android/java_sources.gni [add] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java [modify] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/browser/android/chrome_jni_registrar.cc [add] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [add] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/68cf753deab115193dac19ba10aacf454f4641f0/chrome/chrome_browser.gypi
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b commit d35eb5bffa7c8ab10a33ec736644c5e91df3e32b Author: dimich <dimich@chromium.org> Date: Tue Jul 26 21:44:11 2016 Add support for OfflinePagesDownloadBridge. This adds initial DownloadUIAdapter and DownloadUIItem. Adapter is a class that caches filtered subset of OfflinePages that should be shown in DownloadsUI. DownloadUIItem mimics DownloadItem and is a collection of fields needed for UI. BUG= 630817 Review-Url: https://codereview.chromium.org/2176013002 Cr-Commit-Position: refs/heads/master@{#407923} [modify] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/BUILD.gn [modify] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/components_tests.gyp [modify] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages.gypi [add] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages/downloads/BUILD.gn [add] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages/downloads/download_ui_adapter.cc [add] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages/downloads/download_ui_adapter.h [add] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages/downloads/download_ui_adapter_unittest.cc [add] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages/downloads/download_ui_item.cc [add] https://crrev.com/d35eb5bffa7c8ab10a33ec736644c5e91df3e32b/components/offline_pages/downloads/download_ui_item.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa953a82b27d712228289c6238b671e900fc1221 commit fa953a82b27d712228289c6238b671e900fc1221 Author: dimich <dimich@chromium.org> Date: Thu Jul 28 17:22:54 2016 Make sure the Async test cases availabel today generate correct ClientID. BUG= 630817 Review-Url: https://codereview.chromium.org/2180113003 Cr-Commit-Position: refs/heads/master@{#408410} [modify] https://crrev.com/fa953a82b27d712228289c6238b671e900fc1221/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java [modify] https://crrev.com/fa953a82b27d712228289c6238b671e900fc1221/chrome/browser/ui/webui/offline_internals_ui.cc [modify] https://crrev.com/fa953a82b27d712228289c6238b671e900fc1221/components/offline_pages/background/request_coordinator.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2cd4cbf8f13d712668c82cb8361822f33be2558 commit e2cd4cbf8f13d712668c82cb8361822f33be2558 Author: fgorski <fgorski@chromium.org> Date: Mon Aug 01 16:50:53 2016 [Offline pages] Adapting OfflinePageDownloadBridge to DownloadUIAdapter * Wiring OfflinePageDownloadBridge to DownloadUIAdapter * Making DownloadUIAdapter into SupportsUserData::Data available through OfflinePageModel BUG= 630817 Review-Url: https://codereview.chromium.org/2180973002 Cr-Commit-Position: refs/heads/master@{#408981} [modify] https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558/chrome/browser/BUILD.gn [modify] https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558/components/offline_pages/downloads/download_ui_adapter.cc [modify] https://crrev.com/e2cd4cbf8f13d712668c82cb8361822f33be2558/components/offline_pages/downloads/download_ui_adapter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95772ca18525a1d0d673ff755f1921df38a3b0dd commit 95772ca18525a1d0d673ff755f1921df38a3b0dd Author: chili <chili@chromium.org> Date: Fri Aug 05 00:11:53 2016 [Offline Pages] Add new download namespace BUG= 630817 Review-Url: https://codereview.chromium.org/2208293002 Cr-Commit-Position: refs/heads/master@{#409939} [modify] https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd/components/offline_pages/client_namespace_constants.cc [modify] https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd/components/offline_pages/client_namespace_constants.h [modify] https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd/components/offline_pages/client_policy_controller.cc [modify] https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd/components/offline_pages/client_policy_controller_unittest.cc [modify] https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd/components/offline_pages/offline_page_model_impl_unittest.cc [modify] https://crrev.com/95772ca18525a1d0d673ff755f1921df38a3b0dd/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c36e6e41cb0c8ba0da3791cfbd42cfbd3601365c commit c36e6e41cb0c8ba0da3791cfbd42cfbd3601365c Author: dimich <dimich@chromium.org> Date: Wed Aug 10 02:14:40 2016 Fix OfflinePageDownloadBridge. Calls native->Java did not work due to missed JNI initialization. BUG= 630817 Review-Url: https://codereview.chromium.org/2235573002 Cr-Commit-Position: refs/heads/master@{#410923} [modify] https://crrev.com/c36e6e41cb0c8ba0da3791cfbd42cfbd3601365c/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ec49e50517e2c62e6de74c4159eb63032e2e9dc commit 8ec49e50517e2c62e6de74c4159eb63032e2e9dc Author: fgorski <fgorski@chromium.org> Date: Wed Aug 10 23:37:16 2016 [Offline pages] Downloads UI: Extening DownloadSharedPreferenceEntry to include offline page Introduces DownloadSharedPreferenceEntry version 3, which: * Adds item type to distinguish between offline page and download * Introduces more tests for parsing and serialization * Moves tests to jUnit. BUG= 630817 Review-Url: https://codereview.chromium.org/2230603003 Cr-Commit-Position: refs/heads/master@{#411185} [modify] https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java [modify] https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc/chrome/android/java_sources.gni [modify] https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java [add] https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc/chrome/android/junit/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntryTest.java [add] https://crrev.com/8ec49e50517e2c62e6de74c4159eb63032e2e9dc/chrome/android/junit/src/org/chromium/chrome/browser/download/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9623e1995016f0d61c2333426fad9e3adc231e2 commit c9623e1995016f0d61c2333426fad9e3adc231e2 Author: dimich <dimich@chromium.org> Date: Fri Aug 12 22:35:31 2016 Implement deleteItem and openItem on OfflinePageDownloadBridge. BUG= 630817 Review-Url: https://codereview.chromium.org/2221293002 Cr-Commit-Position: refs/heads/master@{#411802} [modify] https://crrev.com/c9623e1995016f0d61c2333426fad9e3adc231e2/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/c9623e1995016f0d61c2333426fad9e3adc231e2/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java [modify] https://crrev.com/c9623e1995016f0d61c2333426fad9e3adc231e2/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/c9623e1995016f0d61c2333426fad9e3adc231e2/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/c9623e1995016f0d61c2333426fad9e3adc231e2/components/offline_pages/downloads/download_ui_adapter.cc [modify] https://crrev.com/c9623e1995016f0d61c2333426fad9e3adc231e2/components/offline_pages/downloads/download_ui_adapter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9 commit b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9 Author: dimich <dimich@chromium.org> Date: Sat Aug 13 00:32:39 2016 Hook up the OfflinePageDownloadBridge to UI actions open/delete/download BUG= 630817 Review-Url: https://codereview.chromium.org/2243063002 Cr-Commit-Position: refs/heads/master@{#411832} [modify] https://crrev.com/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6 commit 2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6 Author: fgorski <fgorski@chromium.org> Date: Mon Aug 15 18:09:19 2016 [Offline pages] Download UI: Adding Download Service Delegate for notifications Extracts an interface through which DownloadNotificationService communicates with DownloadManagerService, so that offline page related download items can be handled using the same interface. BUG= 630817 Review-Url: https://codereview.chromium.org/2228193002 Cr-Commit-Position: refs/heads/master@{#411988} [modify] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [add] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java [modify] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/java_sources.gni [modify] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java [modify] https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ac57dc9821219deb7579832e8eda43de60a415 commit e3ac57dc9821219deb7579832e8eda43de60a415 Author: dimich <dimich@chromium.org> Date: Mon Aug 15 20:55:20 2016 Implement OfflinePageDownloadBridge::startDownload BUG= 630817 Review-Url: https://codereview.chromium.org/2247823002 Cr-Commit-Position: refs/heads/master@{#412042} [modify] https://crrev.com/e3ac57dc9821219deb7579832e8eda43de60a415/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/e3ac57dc9821219deb7579832e8eda43de60a415/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/e3ac57dc9821219deb7579832e8eda43de60a415/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76dda65295540570a8d35f6cc5cc491283fd41cd commit 76dda65295540570a8d35f6cc5cc491283fd41cd Author: dimich <dimich@chromium.org> Date: Mon Aug 15 22:19:35 2016 Add a force-offline header to the download page open request. This will force offline copy to be loaded even when device is online. BUG= 630817 Review-Url: https://codereview.chromium.org/2249843002 Cr-Commit-Position: refs/heads/master@{#412070} [modify] https://crrev.com/76dda65295540570a8d35f6cc5cc491283fd41cd/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b8554ab6bfdb57cdb48e368dce702237c4f01fe commit 9b8554ab6bfdb57cdb48e368dce702237c4f01fe Author: jianli <jianli@chromium.org> Date: Mon Aug 15 22:33:58 2016 Allow opening an offline download file as offline page BUG= 630817 Review-Url: https://codereview.chromium.org/2246143003 Cr-Commit-Position: refs/heads/master@{#412073} [modify] https://crrev.com/9b8554ab6bfdb57cdb48e368dce702237c4f01fe/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e8c5f4e30270447969f04bfe4d676b6d94f25b9 commit 9e8c5f4e30270447969f04bfe4d676b6d94f25b9 Author: fgorski <fgorski@chromium.org> Date: Fri Aug 19 19:49:14 2016 [Offline pages] Downloads UI: Adding bridge for issuing notifications Changes: * Updates DownloadNotifiactionSerivce to include handling of offline pages * Adds openItem and destroy methods to DownloadServiceDelegate (to handle offline pages and prevent memory leaks) * Adds notification bridge for offline pages related downloads (implemented on C++ and Java side) only calls from c++ to Java. * Adds interface to components that will be implemented by the bridge * Updating OPDownloadBridge to issue notification when current page is captured. * Adding copy constructor to DownloadUIItem BUG= 630817 Review-Url: https://codereview.chromium.org/2239133002 Cr-Commit-Position: refs/heads/master@{#413214} [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [add] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/java_sources.gni [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [add] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc [add] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.h [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/chrome/chrome_browser.gypi [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/components/offline_pages.gypi [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/components/offline_pages/downloads/BUILD.gn [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/components/offline_pages/downloads/download_ui_item.cc [modify] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/components/offline_pages/downloads/download_ui_item.h [add] https://crrev.com/9e8c5f4e30270447969f04bfe4d676b6d94f25b9/components/offline_pages/downloads/offline_page_download_notifier.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6e1def19ac161b674482e96e7d346dcfca2a92d commit a6e1def19ac161b674482e96e7d346dcfca2a92d Author: dimich <dimich@chromium.org> Date: Sat Aug 20 03:54:40 2016 Add 'title' field to DownloadUIItem and thread through bridges to OfflinePageDownloadItem. Also call destroy() on the bridge to fix mem leak BUG= 638395 , 630817 Review-Url: https://codereview.chromium.org/2263753002 Cr-Commit-Position: refs/heads/master@{#413315} [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridgeTest.java [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/components/offline_pages/downloads/download_ui_adapter_unittest.cc [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/components/offline_pages/downloads/download_ui_item.cc [modify] https://crrev.com/a6e1def19ac161b674482e96e7d346dcfca2a92d/components/offline_pages/downloads/download_ui_item.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c871abdd9427c8e502131990d66415980f29c2d commit 3c871abdd9427c8e502131990d66415980f29c2d Author: fgorski <fgorski@chromium.org> Date: Wed Aug 24 21:59:38 2016 [Offline pages] Enabling notifications for pages saved later * Adding observer of Request Coordinator (as user data) * Forwarding the notifications from observer to OPNotificationBridge * Making RequestCoordinator capable of supporting user data * Minor fixes to interfaces (virtual destructors added) BUG= 630817 R=dimich,petewil Review-Url: https://codereview.chromium.org/2260963003 Cr-Commit-Position: refs/heads/master@{#414162} [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/chrome/browser/android/offline_pages/request_coordinator_factory.cc [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/background/request_notifier.h [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/downloads/BUILD.gn [add] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/downloads/download_notifying_observer.cc [add] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/downloads/download_notifying_observer.h [add] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/downloads/download_notifying_observer_unittest.cc [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/downloads/download_ui_item.cc [modify] https://crrev.com/3c871abdd9427c8e502131990d66415980f29c2d/components/offline_pages/downloads/download_ui_item.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ee7a4109cbc763067538c360c36ff2e1ba3ee13 commit 9ee7a4109cbc763067538c360c36ff2e1ba3ee13 Author: dimich <dimich@chromium.org> Date: Thu Aug 25 19:34:18 2016 Modify RecentTabHelper to be always-on and observe the loading of the pages. Expose is_page_ready_for_snapshot() on it which is set when the page can be successfully captured. Move the feature flag check from creating the tab helper to before the actual snapshot. BUG= 630817 Review-Url: https://codereview.chromium.org/2278773002 Cr-Commit-Position: refs/heads/master@{#414509} [modify] https://crrev.com/9ee7a4109cbc763067538c360c36ff2e1ba3ee13/chrome/browser/android/offline_pages/recent_tab_helper.cc [modify] https://crrev.com/9ee7a4109cbc763067538c360c36ff2e1ba3ee13/chrome/browser/android/offline_pages/recent_tab_helper.h [modify] https://crrev.com/9ee7a4109cbc763067538c360c36ff2e1ba3ee13/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc [modify] https://crrev.com/9ee7a4109cbc763067538c360c36ff2e1ba3ee13/chrome/browser/ui/tab_helpers.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14ba6e1ac8051f481d2bc42b2750d0cb2b5968bd commit 14ba6e1ac8051f481d2bc42b2750d0cb2b5968bd Author: dimich <dimich@chromium.org> Date: Thu Aug 25 20:27:21 2016 Hook up the Background Loader to StartDownload for offline pages. If the page in the tab is not ready to be captured right from the tab, we will post a background loader request and exit. The page will be loaded when conditions permit. BUG= 630817 Review-Url: https://codereview.chromium.org/2274373002 Cr-Commit-Position: refs/heads/master@{#414526} [modify] https://crrev.com/14ba6e1ac8051f481d2bc42b2750d0cb2b5968bd/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a708e3e93a3a287edb614234f4f39f9e3d2a735 commit 1a708e3e93a3a287edb614234f4f39f9e3d2a735 Author: fgorski <fgorski@chromium.org> Date: Thu Aug 25 22:17:55 2016 [Offline pages] Hooking up cancel/pause/resume buttons for offline page related notifications * Adding cancel/pause/resume implementations on the bridge and wiring them to the request coordinator * Updating request coordinator to not report completion more than once for success and failure of offliner. BUG= 630817 R=dimich@chromium.org,qinmin@chromium.org Review-Url: https://codereview.chromium.org/2277123002 Cr-Commit-Position: refs/heads/master@{#414556} [modify] https://crrev.com/1a708e3e93a3a287edb614234f4f39f9e3d2a735/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/1a708e3e93a3a287edb614234f4f39f9e3d2a735/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/1a708e3e93a3a287edb614234f4f39f9e3d2a735/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/1a708e3e93a3a287edb614234f4f39f9e3d2a735/components/offline_pages/background/request_coordinator.cc [modify] https://crrev.com/1a708e3e93a3a287edb614234f4f39f9e3d2a735/components/offline_pages/background/request_coordinator.h [modify] https://crrev.com/1a708e3e93a3a287edb614234f4f39f9e3d2a735/components/offline_pages/background/request_coordinator_unittest.cc
w00t.
Comment 1 by bugdroid1@chromium.org
, Jul 26 2016