New issue
Advanced search Search tips

Issue 630811 link

Starred by 3 users

Issue metadata

Status: Verified
Owner: ----
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

kitchen does not produce property value annotations

Project Member Reported by no...@chromium.org, Jul 23 2016

Issue description

https://luci-milo.appspot.com/swarming/task/302e06423b0f0010
does not display build properties because kitchen does not emit SET_BUILD_PROPERTY annotations for each property in the beginning

this happens since logdog integration
 

Comment 1 by d...@chromium.org, Jul 23 2016

It's deciding not to emit them because the annotation stream should contain them. I'll add logic to emit the annotations if tee is true.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/d2d28c63688f5697c611914c872da8971bde0cf5

commit d2d28c63688f5697c611914c872da8971bde0cf5
Author: dnj <dnj@chromium.org>
Date: Sat Jul 23 02:17:33 2016

Kitchen: always emit annotations if teeing.

Kitchen will not emit annotations if LogDog is enabled. However, if
Kitchen is teeing, there may be additional consumers (e.g., Milo)
reading the tee'd annotation stream. This makes it so that those
annotations will continue to be emitted if teeing.

BUG= chromium:630811 
TEST=None

Review-Url: https://codereview.chromium.org/2174103002

[modify] https://crrev.com/d2d28c63688f5697c611914c872da8971bde0cf5/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/d2d28c63688f5697c611914c872da8971bde0cf5/go/src/infra/tools/kitchen/cook_logdog.go

Comment 4 by no...@chromium.org, Jul 23 2016

Status: Verified (was: Untriaged)

Sign in to add a comment